Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2813856rwb; Mon, 15 Aug 2022 11:52:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR4bH7pQeXw5QdUe2kbyRRdPSjJRonMi5qJTaNewho/ODn5RMh9AU3l3H3YbgdafakxIeFHs X-Received: by 2002:a17:907:75c1:b0:730:aa62:7f65 with SMTP id jl1-20020a17090775c100b00730aa627f65mr10882223ejc.355.1660589575726; Mon, 15 Aug 2022 11:52:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660589575; cv=none; d=google.com; s=arc-20160816; b=LvoJpoX6G5/PNlsBtj6DZjQexlBPu0d6MYwCIFADOgytm0YysjjGJAvXZB8Kjyya1m nhAcmszJmz65uUyscqshjQCMs66InzTXQ1ixoTqTRk3e0LVQWrfVzEyjOoVtpYFcG5J1 on6r1kwj86xQaW+LTYa6HBYzugOypXmZCS4ilzmGVoNOJBF0o1L2tT1Z3LNL8izbqkUv rqvPtCTzzaDHXi/+wxRRTEIfBZpG9s+d3rW13W8i+sykIl6dglxHXAhjrGUCwZO10D5m uYbrlT67+dWN90hfZsXGDUfGZ0XlMj4on12P9LIu5+u5kQ3VEhLYc28vAJ/IfsHFsoO0 hGeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bDK7Hrkfo7BzFOwBAl99PC14uWQwzmaNVzRQYRe0UNQ=; b=kmgyvgndzAWUkVyDVFgXH9L58bPMGxwOXsPBT9SfXxgtigCk+AIOPdZkB85VA09SvE B3KAxyTdrDJrPrpwgv/HuXT40ep4gP87ys9+R2RA/pgQ8VelyPwTk7HuaPjHmE/lQ73/ 3hZG5KdeYCHokd1htQKdUg/PrI6MRly/9AmA6Ztsoaq52O4jNFT8g5vD9EAFpCu5VdsS cIlPTxgqwdZI5LHGDDfreS/n7kVcTZ83HvjzQ/8+YALkD2PLap6WM3GoDx34YzLpYSGr 8bpZ7ldZpq4p/qgOynjBiRx77cgaHibRGHY90EaqBv8Geb6sPgh/Jn3QribO/9QzQqYg lR+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LtWBUY2j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di3-20020a170906730300b0072af8809a85si8601501ejc.332.2022.08.15.11.52.25; Mon, 15 Aug 2022 11:52:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LtWBUY2j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239656AbiHOSSH (ORCPT + 99 others); Mon, 15 Aug 2022 14:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239478AbiHOSRP (ORCPT ); Mon, 15 Aug 2022 14:17:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B74B7; Mon, 15 Aug 2022 11:15:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD47AB8106C; Mon, 15 Aug 2022 18:15:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AC6AC433C1; Mon, 15 Aug 2022 18:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660587311; bh=d0+uaXnzk2ajdnldlX+pjv1VYjPMK/590gVPt1rVsX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LtWBUY2jtftIbQcGoXND4Z1xHJSwwPTeyoxqxM4XJnpj/tJwmBNuJS36ixoQWiNWK rU+o6HvTdTliyA9IgnKLuOZ5w2PULI4+1ycW3ihNhUAuanGgQx7nsBo9kBVODyZB8k g1+czifNltXz8FOjvfTtxUTn9HBrqh5Tckgp1XJY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Vetter , Helge Deller Subject: [PATCH 5.15 044/779] fbcon: Fix accelerated fbdev scrolling while logo is still shown Date: Mon, 15 Aug 2022 19:54:48 +0200 Message-Id: <20220815180339.129054379@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Helge Deller commit 3866cba87dcd0162fb41e9b3b653d0af68fad5ec upstream. There is no need to directly skip over to the SCROLL_REDRAW case while the logo is still shown. When using DRM, this change has no effect because the code will reach the SCROLL_REDRAW case immediately anyway. But if you run an accelerated fbdev driver and have FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION enabled, console scrolling is slowed down by factors so that it feels as if you use a 9600 baud terminal. So, drop those unnecessary checks and speed up fbdev console acceleration during bootup. Cc: stable@vger.kernel.org # v5.10+ Acked-by: Daniel Vetter Signed-off-by: Helge Deller Link: https://patchwork.freedesktop.org/patch/msgid/YpkYxk7wsBPx3po+@p100 Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/core/fbcon.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -1706,8 +1706,6 @@ static bool fbcon_scroll(struct vc_data case SM_UP: if (count > vc->vc_rows) /* Maximum realistic size */ count = vc->vc_rows; - if (logo_shown >= 0) - goto redraw_up; switch (fb_scrollmode(p)) { case SCROLL_MOVE: fbcon_redraw_blit(vc, info, p, t, b - t - count, @@ -1796,8 +1794,6 @@ static bool fbcon_scroll(struct vc_data case SM_DOWN: if (count > vc->vc_rows) /* Maximum realistic size */ count = vc->vc_rows; - if (logo_shown >= 0) - goto redraw_down; switch (fb_scrollmode(p)) { case SCROLL_MOVE: fbcon_redraw_blit(vc, info, p, b - 1, b - t - count,