Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2814309rwb; Mon, 15 Aug 2022 11:53:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR6UiNNOwC/jhmRAykhQ3dVnXuerj/zRCVEnkbzwLHnlYBAoCtLN2pP34aDohyFBcUHE/CFn X-Received: by 2002:a17:907:75c1:b0:72f:248d:5259 with SMTP id jl1-20020a17090775c100b0072f248d5259mr11401465ejc.227.1660589618270; Mon, 15 Aug 2022 11:53:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660589618; cv=none; d=google.com; s=arc-20160816; b=TjjlPIdMVwOSqjC0VEqjS6RvMyYhJw+XWfphmwM1uUEYm+KULVTEt2WoG+Br7VB860 iFx6Uf4Y4CxJSqgCoQVUhDLRWfUsIFkly4wVeh6P4dN/96XSRxJ05F//VWtAjLyobPNw aoUOFbipk+N7oesm5QMbZ8pgywIKdFYnU2N4bUOUDWqdzl/xL+glxKYgQQpiigspZPZg kSNx2Xidwabkd80F2KM9Q4uEYIiwC1oIJRSdt5lsISybvZSactnDlPGiwSjsWvxQ/hGf 3EZJ85DQNDOrjuMMUfsbL5X+B1UII1PByzor6k++r3BMtirneX6SPuWI4veFVHy6Wyy1 L6og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wJziB5aijrZPvg9NyTSZCYYZnVC8WfKDlAPlBBRT8lY=; b=K9bXfml+BFSBtQtSUUtpmWIFl0wmqBdMHbqelKSV9GpOBm449NahysVHNbFCZ6fza+ gPUdnsZwymcKX42hWb/bCyOEZEql3RfrI4vPcB0HbHrV9X4OjuUYQdH/0YgMLbd2sZ/d T5Li4vrHK1PKSgLGB9n/h7OaKPptNNowZ+TAJYaUjn19Ff0E2R09IW37pDCyqKn5ssGL Jg7tTOYkD3S9aJ39NaBcHxp6nqShk4Lrro8JirASxeC4c52S++syyK3na8NCkC3dugG1 L25x5SPaKs1mVilBDSGDUqTxeBNAxxdew7crRs7zO5BK+Y26Rth84K1Vyrbe3vmFHEbi aCrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Gl2fZmop; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga23-20020a1709070c1700b00726b8cf8debsi9355530ejc.869.2022.08.15.11.53.10; Mon, 15 Aug 2022 11:53:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Gl2fZmop; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229946AbiHOSof (ORCPT + 99 others); Mon, 15 Aug 2022 14:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243911AbiHOSlk (ORCPT ); Mon, 15 Aug 2022 14:41:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E223C1C; Mon, 15 Aug 2022 11:25:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 46DE960FB5; Mon, 15 Aug 2022 18:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E21CC433C1; Mon, 15 Aug 2022 18:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660587914; bh=MwQx0kl1Vvr/QAikUnONp1UQCcEMBPy/CsbZtyschfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gl2fZmopXa/pR0IzJdSBhPDKGDEYOBPfg55ToEyCQ6E5htNBnFPAHDAEoTRqMN0ac QbCZ+t6jtv2h4j/aJm4gWGXreM29q5Hn6jT+i/s6KNV5uMXW6Znfchma+0tOwbeZZ8 a/JTsrAN101gdKDqsCDCBmGL46g3C6nJNUXgQ6x8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Steev Klimaszewski , Kalle Valo , Sasha Levin Subject: [PATCH 5.15 236/779] ath10k: do not enforce interrupt trigger type Date: Mon, 15 Aug 2022 19:58:00 +0200 Message-Id: <20220815180347.366469325@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 1ee6c5abebd3cacf2ac4378d0ed4f57fd4850421 ] Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge rising - but instead rely on Devicetree to configure it. All Qualcomm DTSI with WCN3990 define the interrupt type as level high, so the mismatch between DTSI and driver causes rebind issues: $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/unbind $ echo 18800000.wifi > /sys/bus/platform/drivers/ath10k_snoc/bind [ 44.763114] irq: type mismatch, failed to map hwirq-446 for interrupt-controller@17a00000! [ 44.763130] ath10k_snoc 18800000.wifi: error -ENXIO: IRQ index 0 not found [ 44.763140] ath10k_snoc 18800000.wifi: failed to initialize resource: -6 Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.0.c8-00009-QCAHLSWSC8180XMTPLZ-1 Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1 Fixes: c963a683e701 ("ath10k: add resource init and deinit for WCN3990") Signed-off-by: Krzysztof Kozlowski Tested-by: Steev Klimaszewski Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20220513151516.357549-1-krzysztof.kozlowski@linaro.org Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/snoc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index f79dd9a71690..73fe77e7824b 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1249,13 +1249,12 @@ static void ath10k_snoc_init_napi(struct ath10k *ar) static int ath10k_snoc_request_irq(struct ath10k *ar) { struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); - int irqflags = IRQF_TRIGGER_RISING; int ret, id; for (id = 0; id < CE_COUNT_MAX; id++) { ret = request_irq(ar_snoc->ce_irqs[id].irq_line, - ath10k_snoc_per_engine_handler, - irqflags, ce_name[id], ar); + ath10k_snoc_per_engine_handler, 0, + ce_name[id], ar); if (ret) { ath10k_err(ar, "failed to register IRQ handler for CE %d: %d\n", -- 2.35.1