Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2822355rwb; Mon, 15 Aug 2022 12:03:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR4+PKABycimTG1RfBfwmTD/aMheKCVkNF63XKeNMQxjT1cerwKXTwazDBjwO0S5brF8vk5W X-Received: by 2002:a17:907:28d6:b0:731:10ff:86a6 with SMTP id en22-20020a17090728d600b0073110ff86a6mr11364847ejc.128.1660590190053; Mon, 15 Aug 2022 12:03:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660590190; cv=none; d=google.com; s=arc-20160816; b=U4DDIUWn6hxMuc9mGv6H81H++8IlLaYtXyavS0LHHXbnwjpf58Wtr2vR+FxZCWQzTp p9MVt6L5kF8ISFCjv1ks3MlwIBsj+xaoELXnv/wlZHJJWCwIhjighJfN/YlaTNSBhlGS FUqnvkpqocANQsKr/RcOLbeTh+mU1h3yyOBH6V2VeilrEtCoYV+toFu08gLUnoFVgvKk DxFnuF+qad1lk8WG2S3KycQ9XhE82MTMZJxNIDz1P9i6wpvOKThGwZlI9rpSERWqKpjm 3VGmfSNwH4W1hAAnSh8+PA1ayIKrPxT1gKDQGFqpESPH/udbeIz/EIZBzyQ0QHcKjgq/ p1Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fYq/9QiZNL6gvbBusQeFm/J1hvTfbR0mbna07LPfALg=; b=Ok70fYk+fMcw+vZRN1OYPQAsE2n3zTUbtCevlwEvC6UXQ9BzohuyZ+PaJGViPUkEHV q86CCbu1pRE8J4e0fI9DpagAjnTkOmZ3mEFKIrVSWhaGpLZdFCtE/FeeENX1y1KmnLyN 2826/GXy25Azyf+NhKSGMaRlCLUGabHclCsezqhAI+JLQeVBbRlsDD+zhrMIuGCP+CKL Vt7SYk25E4FhQ0YxKnUrgmDcCYe4coJOVg34KglrNXpx8yjqd2pIDMZ+87+66/PU1/Uz XJuJjdEYmRkmnZbo8htgB1GzjGDWR4+DiW3LXEJjzy1/WNJe/rluskhPF73hfdSZ8pbL fx+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GNuy19mQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id du20-20020a17090772d400b00734ba6143a7si8706257ejc.930.2022.08.15.12.02.39; Mon, 15 Aug 2022 12:03:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GNuy19mQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244370AbiHOSxe (ORCPT + 99 others); Mon, 15 Aug 2022 14:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244185AbiHOSu0 (ORCPT ); Mon, 15 Aug 2022 14:50:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C085C4333A; Mon, 15 Aug 2022 11:28:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 89860B81062; Mon, 15 Aug 2022 18:28:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0241C433D6; Mon, 15 Aug 2022 18:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660588127; bh=FXcmKym8+v4WXGSA74E5HXWL4LuU9++qS5FPtliBTcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GNuy19mQPr1E2jK2VETAJpclZx1djr8HXQCYEnNUJpISsnH8jIEwVabMj957FXVPE 2GLp0tT2Rx3rSkUuzl5AHaf9QTbB5T0h7pzWlDp794oM/GiLZzHKhZRY+cGYoADqvY ymdgv/uwhhUYye/mVSOjR7Q4mQ1m2r0jFApaqzVM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Stevenson , Maxime Ripard , Sasha Levin Subject: [PATCH 5.15 304/779] drm/vc4: dsi: Add correct stop condition to vc4_dsi_encoder_disable iteration Date: Mon, 15 Aug 2022 19:59:08 +0200 Message-Id: <20220815180350.288301178@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson [ Upstream commit 7bcb9c8d0bc9f3cab8ac2634b056c2e6b63945ca ] vc4_dsi_encoder_disable is partially an open coded version of drm_bridge_chain_disable, but it missed a termination condition in the loop for ->disable which meant that no post_disable calls were made. Add in the termination clause. Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling") Signed-off-by: Dave Stevenson Link: https://lore.kernel.org/r/20220613144800.326124-17-maxime@cerno.tech Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_dsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 333ea96fcde4..b7b2c76770dc 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -803,6 +803,9 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder) list_for_each_entry_reverse(iter, &dsi->bridge_chain, chain_node) { if (iter->funcs->disable) iter->funcs->disable(iter); + + if (iter == dsi->bridge) + break; } vc4_dsi_ulps(dsi, true); -- 2.35.1