Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938982AbXFIBR1 (ORCPT ); Fri, 8 Jun 2007 21:17:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751381AbXFIBRR (ORCPT ); Fri, 8 Jun 2007 21:17:17 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:3381 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750795AbXFIBRQ (ORCPT ); Fri, 8 Jun 2007 21:17:16 -0400 From: Herbert Xu To: trond.myklebust@fys.uio.no (Trond Myklebust) Subject: Re: networking busted in current -git ??? Cc: arekm@maven.pl, florin@iucha.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Organization: Core In-Reply-To: <1181339007.6675.12.camel@heimdal.trondhjem.org> X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686)) Message-Id: Date: Sat, 09 Jun 2007 11:16:14 +1000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 44 Trond Myklebust wrote: > > It appears to be something in the latest dump from davem to Linus, but I > haven't yet had time to identify what. You want this patch which should hit the tree soon. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- [IPV4]: Do not remove idev when addresses are cleared Now that we create idev before addresses are added, it no longer makes sense to remove them when addresses are all deleted. Signed-off-by: Herbert Xu diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 354e800..0cf813f 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -327,12 +327,8 @@ static void __inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap, } } - if (destroy) { + if (destroy) inet_free_ifa(ifa1); - - if (!in_dev->ifa_list) - inetdev_destroy(in_dev); - } } static void inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/