Return-Path: <linux-kernel-owner+w=401wt.eu-S1032517AbXFIBWW@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1032517AbXFIBWW (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jun 2007 21:22:22 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753594AbXFIBWN
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 8 Jun 2007 21:22:13 -0400
Received: from rhun.apana.org.au ([64.62.148.172]:3401 "EHLO
	arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1753196AbXFIBWM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jun 2007 21:22:12 -0400
Date: Sat, 9 Jun 2007 11:22:08 +1000
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Chris Wright <chrisw@sous-sol.org>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
       davej@redhat.com
Subject: Re: [patch 23/32] IPV4: Correct rp_filter help text.
Message-ID: <20070609012208.GA31945@gondor.apana.org.au>
References: <20070608071553.469107000@sous-sol.org> <E1HwpdD-0008Il-00@gondolin.me.apana.org.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1HwpdD-0008Il-00@gondolin.me.apana.org.au>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1441
Lines: 33

On Sat, Jun 09, 2007 at 11:20:43AM +1000, Herbert Xu wrote:
> Chris Wright <chrisw@sous-sol.org> wrote:
> > 
> > --- linux-2.6.20.13.orig/net/ipv4/Kconfig
> > +++ linux-2.6.20.13/net/ipv4/Kconfig
> > @@ -43,11 +43,11 @@ config IP_ADVANCED_ROUTER
> >          asymmetric routing (packets from you to a host take a different path
> >          than packets from that host to you) or if you operate a non-routing
> >          host which has several IP addresses on different interfaces. To turn
> > -         rp_filter off use:
> > +         rp_filter on use:
> > 
> > -         echo 0 > /proc/sys/net/ipv4/conf/<device>/rp_filter
> > +         echo 1 > /proc/sys/net/ipv4/conf/<device>/rp_filter
> >          or
> > -         echo 0 > /proc/sys/net/ipv4/conf/all/rp_filter
> > +         echo 1 > /proc/sys/net/ipv4/conf/all/rp_filter
> 
> BTW, this documentation is actually wrong.  You can't enable rp_filter

So to fix the documentation, we should change the word "or" to "and".

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/