Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2869208rwb; Mon, 15 Aug 2022 13:00:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR7aYqLu4c3TT9mhwraw05s965G0M1Ds2k9ubtS2lEJXqjtP2oBH+6QPwRoDMvil/iBnwiw9 X-Received: by 2002:a17:907:728c:b0:730:c005:5d93 with SMTP id dt12-20020a170907728c00b00730c0055d93mr11491470ejc.265.1660593605391; Mon, 15 Aug 2022 13:00:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660593605; cv=none; d=google.com; s=arc-20160816; b=VKsoOfGZxFmDcuEsnFmfDvU2Mxi3YGsOKgZds/Ac6Zu3pabr9TBeBn5QA+4Gr0pYgJ XvjKBYVjTWXKWNCiac5DcCK+vdoOLk7g6NRfpKDYIW+I7dFlLv5EibD39xI83RrYR6/y sgsinA2U77l0jHWsXE5/3tlr1WfLMNc3clJgYgGdcJBAzvWelefsa2ayQvnDsY2pWWGL 9Qi7/ubv1akxQMhWwg2A9Gu82voUZSR2noPDA00CuLod77g+wgayUrfoq0157iMjGeTk OxjzDdJSEQxFeJ+wUCwBJiwRv+9B4j7GMssH+TCQt0h6LWxtOlfsrO7PjwoK4/1FCr06 AGzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=vLER9ahWMnnAVUjZqdQ45knecrK2MCT78YL5vPl0AyM=; b=f4hZUSjirLVFJz9BERyeMLCfwUEYhdmPpsnc/8irNKGgy9na4IrE/1kE4Nd1v0Iofi PH0Sw8+aCmeTxxLstU7JkwIZnxfbIum1Ic8/fnEYOJfd8lMJt/COK8Ya4egckZqVym3T QeBR9IdHtnsGfwck3K3Blw29NtmYIw0/3uf38ldxGC9XEweYXHKromJELpRo7MUg6Q0F KSqyoB3DB+d63XkN8Ut5CX1qrbgL3Ku94I19iw++HTBENSvszYwI4NL9w5O0IsSgkIMU XjFJdq2WhBHiybKnUCNQe7E2j2YrS7y/erI+mGL9eO95XGiMxVNFJeNEsfr/ZToV0eUE 6bPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IVr2mMMD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a17090655cf00b00722ebccb11asi6397399ejp.101.2022.08.15.12.59.31; Mon, 15 Aug 2022 13:00:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IVr2mMMD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245003AbiHOT3P (ORCPT + 99 others); Mon, 15 Aug 2022 15:29:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245561AbiHOT0B (ORCPT ); Mon, 15 Aug 2022 15:26:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48DB32A972; Mon, 15 Aug 2022 11:41:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8C7D61052; Mon, 15 Aug 2022 18:41:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34EF2C433D6; Mon, 15 Aug 2022 18:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660588884; bh=vLER9ahWMnnAVUjZqdQ45knecrK2MCT78YL5vPl0AyM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=IVr2mMMDTz0rzFchBqIJhG8SPJGCa5MUJnMpZg3URb3AeLBZhnne+L1PgvKfPI3bs Zw0fh/evjFcCki+V9JR5wqAFEdPwLU7VkoVO8gsnH4aEqCgUxY8Duc2E6B+cEAwUWG vOSkmf1AKb19m3h9bd0zA1ixoXQEpxzGmg7WStDBTxuwKTh4eBPVN1ZVr5KI6I9yAt nmydNPRGmHJdz795iJ5uKoQ9tm9K0et8KTCB6Z/VC5zjevP1/Orjx2EcUyvyxFfKpd Nh65ZdxnkRXw00HjwdS61ixI4JjaE5bI1I50+5Kj6PvEm+PdjZT+HYHbNwcX/DlokH MyMv8dk9Benfw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220510084315.1706978-1-zheyuma97@gmail.com> References: <20220510084315.1706978-1-zheyuma97@gmail.com> Subject: Re: [PATCH] clk: max9485: Register a callback to disable the regulator From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Zheyu Ma To: Zheyu Ma , mturquette@baylibre.com Date: Mon, 15 Aug 2022 11:41:22 -0700 User-Agent: alot/0.10 Message-Id: <20220815184124.34EF2C433D6@smtp.kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Zheyu Ma (2022-05-10 01:43:15) > The driver should register a callback which can disable the regulator > when it fails to probe. >=20 > Signed-off-by: Zheyu Ma > --- Looks like there's going to be a devm_regulator_get_enable() API that we can use instead. Please do that. https://lore.kernel.org/all/cover.1660292316.git.mazziesaccount@gmail.com/