Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2875642rwb; Mon, 15 Aug 2022 13:06:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR7CY4dv4vpwMQrAxlFze4/SbiDwVDODSr1ofF7SFnrfhtM0QZJaokDCMfbFHGDaxagaxH8D X-Received: by 2002:a05:6402:400e:b0:440:253e:961a with SMTP id d14-20020a056402400e00b00440253e961amr16002032eda.285.1660593986873; Mon, 15 Aug 2022 13:06:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660593986; cv=none; d=google.com; s=arc-20160816; b=mmRbnbTlo81VDuhiLRMq7qr8OtQ+q5YNft2ArAyK8Zmf4k1Grb+JKO4gEielTtJI+N zrH5zPOpSTvP4utQc87Kx4qNFZvg3WeCgwoAgyusAx6T/a2JaCp9BONspagZsxAIsMgo 83V68An2f/Qe9lVqufNHFotBvJCuHWdFoViVb7fgoYMfRbW6fRBqIFP8eu9hiNYQHxxw JfoG+cW4FtCRlQto6zt5Q6LUEkI6IFzTS4mEM948pP9LNOg6/bKKgKhx+WrmRDpBG2po LfUIiVcvZx2ACQ7EVEaueYrgA4NgqWkcNdm9A3SsFKznO3iBdhkwXeR65mODeVQxeYfv MMZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mIc0nFmK7oxC6PGrwdNilAEilzxe+qWIbfB1oTdt5vg=; b=UkBuURaU4x+n3dCEbbhojDYlQm3jwCecYdgNP0qrYxwZRcuM31BYyk1aOUDAFolrYa yvDh/fQRV3d/cHHrG8/r1Bk1YS/3zHrUBWqc/LKrHoy7/K/qQhRUPditNgs7Umxv/wb7 cx+LqXc3rqNo4TRI5YstpvDaerdjOInd9G7Uyu9eZmOG8evfSMz46SWdFTOF7CwxYSc5 LdS/0DhGCG+tBDP7bd5AAjKAjIwCPzqcnvpNo8XiPhObVnM9d+squ/EyCIOlW56dE5tT eC+DhTpRjeqH8i03oj3D2MBy6iWH3MbcbwnKUSP0ifphYr7hlk0VBKQWVzSgL3GsyNGr A95Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eU4IN1Oc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m7-20020a056402510700b0043c25d25046si9609260edd.249.2022.08.15.13.05.59; Mon, 15 Aug 2022 13:06:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eU4IN1Oc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244583AbiHOTAH (ORCPT + 99 others); Mon, 15 Aug 2022 15:00:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245061AbiHOS4h (ORCPT ); Mon, 15 Aug 2022 14:56:37 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 215202CC81; Mon, 15 Aug 2022 11:31:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 93D1ACE125C; Mon, 15 Aug 2022 18:31:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86F6BC433C1; Mon, 15 Aug 2022 18:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660588284; bh=b7hS5d454oaulv4KcfZU56i0AKfffymxFdCbBxiLZoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eU4IN1OcGYH02YASoYAXQwyUJekauG2bXCkWVNOesIEtGMNWogtmHrg9cC27h+kRS KpeKIzX9CqCcpSGJ6hPBwG4yHPAzbfiauHdLP5X682HfsdSBE7aSl6UpOtPtU/LZyK 0AXfJwPvRbG8NHJG4E8YXrtYsFo61slEmocHx3d0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gergo Koteles , Lorenzo Bianconi , Felix Fietkau , Sasha Levin Subject: [PATCH 5.15 326/779] mt76: mt76x02u: fix possible memory leak in __mt76x02u_mcu_send_msg Date: Mon, 15 Aug 2022 19:59:30 +0200 Message-Id: <20220815180351.223926042@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lorenzo Bianconi [ Upstream commit cffd93411575afd987788e2ec3cb8eaff70f0215 ] Free the skb if mt76u_bulk_msg fails in __mt76x02u_mcu_send_msg routine. Fixes: 4c89ff2c74e39 ("mt76: split __mt76u_mcu_send_msg and mt76u_mcu_send_msg routines") Co-developed-by: Gergo Koteles Signed-off-by: Gergo Koteles Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c index 2953df7d8388..c6c16fe8ee85 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c @@ -108,7 +108,7 @@ __mt76x02u_mcu_send_msg(struct mt76_dev *dev, struct sk_buff *skb, ret = mt76u_bulk_msg(dev, skb->data, skb->len, NULL, 500, MT_EP_OUT_INBAND_CMD); if (ret) - return ret; + goto out; if (wait_resp) ret = mt76x02u_mcu_wait_resp(dev, seq); -- 2.35.1