Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2878415rwb; Mon, 15 Aug 2022 13:09:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR43/esT80Wwn0gtIfl3gCkFCNmTjVzYSqKbvz6kzdak0hYLgEjgQU3liRl0mkHyuVgWuRLy X-Received: by 2002:a17:902:cf0c:b0:16f:9023:e07b with SMTP id i12-20020a170902cf0c00b0016f9023e07bmr18161449plg.143.1660594166069; Mon, 15 Aug 2022 13:09:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660594166; cv=none; d=google.com; s=arc-20160816; b=H52RsqDi2Rw7F43Rc9U/68ps2k40u+0JDJZM9TNcI453eGmgRB7Zdv5ChQ6PpG9Cpy PcU53vEmkL9R8aqyeO5a/jP8qQxc/qEAmJQi6yyKhV7alyMqM0jomF/uVMC6osddofEp Y5HEzPj3sjUaElthp2dqE81H/T8j++y9S4VAFPR3W/zx+ZnCrfek6/k1NR/Y4Kpv1Y20 hjXT8Za3o/YpppK/aazm1aY4S75NHPU4vCzC9Au4Nf1a1oq0InWK4Ok9Bsj4kIe5yOix tVrvBhmkJa2WXVCF4RQHf6xPUsm90fqvKN23kPIvJCjY3/VuAaG1wxCmN1CXxseBI4op nduw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ktJKPXnkCcB2uBXEubUsdAUetXCCR5KnWgj0g0K4Nv4=; b=uaG4VFEnnpPL8zjR8JJg73pjNdbmtXUVxkHq8lXBloR7vjoU53tJGKRq4eA09zVj5b bLb5sRqQ5b3Pv6W3G6L22n4ia1f+awpxKysJce4HZUqY0hS3um02yNvChOUURVS48r/J f+JeIcHPehLDt0mGxiGpvwog18MeXExCHDal2BC68fRxXK5iH2F2+7uF888A3tanmIyx yA8hGYnclYHwdGyC7uCi76IGs44kFcLE79HtN5+BEIM2CZIGJ6JVYKjfZXlJWzB2vQX/ eKR/52Q+ficnRwFfeTgvBKb6d+O+DWz9FT8DTntwjLZM6Ew2xt3krW59BNvf3UWzjZZ/ Kvqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U3S4xFfF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w15-20020a63f50f000000b0041bdf3cfd82si10414130pgh.171.2022.08.15.13.09.14; Mon, 15 Aug 2022 13:09:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=U3S4xFfF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343873AbiHOTNV (ORCPT + 99 others); Mon, 15 Aug 2022 15:13:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343667AbiHOTJx (ORCPT ); Mon, 15 Aug 2022 15:09:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2832E2B194; Mon, 15 Aug 2022 11:36:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D69F3B8105D; Mon, 15 Aug 2022 18:36:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 133EFC433C1; Mon, 15 Aug 2022 18:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660588578; bh=VRjsAXF3WC4tJ6gSQwHyFOt8YAAM7NKxdLNNLzkDUzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U3S4xFfFVE2yonKGTEx7alKfWrgoaSJA9HT229xX/O1/az09MyTj8s2kcqDdBUkJe TDLk4BigsPsrLtSTJoCf2LFG2RpowZ04Rjesg+0DyLxNFf2IkLhuwVYiaD3TQ1omA2 oFNfhinyD4VJeorISxzCjw3tDM097i2Tzyqyg8Hg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sergey Shtylyov , Mathias Nyman , Sasha Levin Subject: [PATCH 5.15 448/779] usb: host: xhci: use snprintf() in xhci_decode_trb() Date: Mon, 15 Aug 2022 20:01:32 +0200 Message-Id: <20220815180356.429769912@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sergey Shtylyov [ Upstream commit 1ce69c35b86038dd11d3a6115a04501c5b89a940 ] Commit cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing") apparently missed one sprintf() call in xhci_decode_trb() -- replace it with the snprintf() call as well... Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Fixes: cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing") Signed-off-by: Sergey Shtylyov Signed-off-by: Mathias Nyman Link: https://lore.kernel.org/r/20220630124645.1805902-2-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/xhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index 79fa34f1e31c..101f1956a96c 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -2395,7 +2395,7 @@ static inline const char *xhci_decode_trb(char *str, size_t size, field3 & TRB_CYCLE ? 'C' : 'c'); break; case TRB_STOP_RING: - sprintf(str, + snprintf(str, size, "%s: slot %d sp %d ep %d flags %c", xhci_trb_type_string(type), TRB_TO_SLOT_ID(field3), -- 2.35.1