Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2882506rwb; Mon, 15 Aug 2022 13:14:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR5BsYCgELbJQeGcnwm1A2WmA1Hbj0nnEscw9QuWEXrr1QiylTYccPPsIPLAp60N8tdmpIdA X-Received: by 2002:a05:6a00:1821:b0:52e:3c7c:9297 with SMTP id y33-20020a056a00182100b0052e3c7c9297mr17863436pfa.54.1660594475460; Mon, 15 Aug 2022 13:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660594475; cv=none; d=google.com; s=arc-20160816; b=ceDCgJ4NjYGW1DwmWVDgsD3CrCRtJtuIy/DmW1pLNNM4M5xlCvnoZYVSeq4yC2K096 VNy/jQ8RVgfB6FgBEn/0m0BllIVJMRqNyzt7npSDgBlaBboXR92Ib/w5+uMqKxHkBjpp gdaQB1bg1QwKuxScS2SuVbe5Uo3276gq2+PhDhjkTcN/s9MMYrwEBfJDt91avCx/NvXY JQ8Na3jkdfrRoglwmqXDjvdHcbjA/hjYEXbDGtKnb3OTrXMtrnCVasOGhRcIIq6YpfY8 BiZLaSWOdk8S7kx2dIJtTV+oUUOEDTDFCO3tzRsPmOsnfn801htnTF6pMzmP+oTw9eIE 3jFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zBxbOd875xJu16M5kqCWAiG1LKuOeJzWCm0WhVsiNy0=; b=hosXc5/Y8hVsMaBo86RgxuoIFHgmVM22OxH5sqUSg+X/OlD4b7BoOImHHt8pqq0XB7 o67S3glisOIo2eiBwEFJqfWXayuxRyf59R1DeJrre5WgV/eG9tu02UuyY+ITj440ajBs UsTG7Db7zvIixAipZX+IDUO/Rov6zFOPyudd3pWeFf14Y85hZ5DWYQVRC+p8lYUR7EX3 aQ2S5DWHajuRLqV/3/G5IC3WTItWJpM4wPi0n6XSuOwbhTYG7zCexudqLfjGC88RsAcL T1uzTQyeeHi71mnuqG7syXG8/ga/Ja6uNUW1A78tagZcThaooFpkyJO56hLt4yZNqNtF Av5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fizCgBQQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x185-20020a6331c2000000b004228fdf0856si10761871pgx.348.2022.08.15.13.14.24; Mon, 15 Aug 2022 13:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fizCgBQQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343570AbiHOTI5 (ORCPT + 99 others); Mon, 15 Aug 2022 15:08:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245660AbiHOTGC (ORCPT ); Mon, 15 Aug 2022 15:06:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F22A64E84B; Mon, 15 Aug 2022 11:34:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AB89BB8106C; Mon, 15 Aug 2022 18:34:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1237C433D6; Mon, 15 Aug 2022 18:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660588476; bh=bzFVUVkb0hL4tUDIprYYW0i2vps8384MfZ5C8L4/c+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fizCgBQQCFR855xgKGxmmkD6t/hnYlzILT+9YbPSe66wrUFoGpl/2Ye7czR3qlH5M ev1D/q88KRDU9IRy4eyqOSHlU/px7dZaXX1SIUpWOvlHmcDH8drq8J+6UoVYXVSAef 2ZOY0AC6OdSQNED/UWjFNjWbM244emDn2n6czQ+E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Stern , Miaoqian Lin , Sasha Levin Subject: [PATCH 5.15 415/779] usb: ohci-nxp: Fix refcount leak in ohci_hcd_nxp_probe Date: Mon, 15 Aug 2022 20:00:59 +0200 Message-Id: <20220815180355.002184956@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 302970b4cad3ebfda2c05ce06c322ccdc447d17e ] of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 73108aa90cbf ("USB: ohci-nxp: Use isp1301 driver") Acked-by: Alan Stern Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220603141231.979-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/ohci-nxp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c index 85878e8ad331..106a6bcefb08 100644 --- a/drivers/usb/host/ohci-nxp.c +++ b/drivers/usb/host/ohci-nxp.c @@ -164,6 +164,7 @@ static int ohci_hcd_nxp_probe(struct platform_device *pdev) } isp1301_i2c_client = isp1301_get_client(isp1301_node); + of_node_put(isp1301_node); if (!isp1301_i2c_client) return -EPROBE_DEFER; -- 2.35.1