Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2882688rwb; Mon, 15 Aug 2022 13:14:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR7s/OzP/Cff/MuMGhvzKgFByTjhMpSHQxxB9FrEelYyA5peBvpVUr2v4UpQ5nW5FFrnD2cl X-Received: by 2002:a05:6402:400b:b0:43d:b0a1:dee with SMTP id d11-20020a056402400b00b0043db0a10deemr16103734eda.223.1660594489367; Mon, 15 Aug 2022 13:14:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660594489; cv=none; d=google.com; s=arc-20160816; b=k0KigQHn48Ha8VFlwKq8cKoHUT/BVRRORjTzcuy40r3zFxwaF0J6Qbpi4LU1k+3E6l IGk/rsO6vzfoFzCcZhVfb3Z90M6aByJ6c91i8s+E9xs4pyI8N6usKq5efERMpdIWt1h+ JxRTwTtnLto/wk0NCiF+fShsjAO9VvndNGBOEOolIGpHm2gxTaElGXq9ZD2CwiD+3EzR prqMXv9jkXzL2uvJ1GpId+xfZnxw7pI0STaB2sU9ZBkiF5hKjA3c5UqaiCOFrgZ+BPB+ y8n5b7fdSAPDTo+tBHmZ+X6DRBrvCGBwoxiEiDGxrfBJ2820yytjaXbImgmAkhDaOsfB rQRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sHcDbWYeCoqHPsDs5XGUkfBXglNcgcS7xE+ffz9HjFc=; b=aSSamJ5kg65Il2kAzOJ3Tf1xOP0NS2zeMUhil8DGhdexlN725hkAQjobYkr0JVrUAw /J0WPvC4dvhIgu0jWPgu3sQoU8XgKdnY0lY+nFYCFTQ0UAxJYOE/dwhkjjE/BpdI6xqK SBKNI1sXpGC+bWsUMxRhZQbP5pcGAosVZnm1r6zppvJDsA00jZwKs37oaANbeTNO8Z0r 6kgf+RInxYsHYPq5GgFE/VIxlAAa85uXvzk0YLs1mr5VDw+W2B1gX5aEEl8TMXu4eAzO lDnl2wyo9mTI2swW/LJXa2csiqUMZMdHT1w3cciClJu0TtM3YL5nNOscyR2zVNmaMWG7 hUkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OHSBeCqt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc30-20020a170907169e00b0072b02ef4ad9si10506646ejc.307.2022.08.15.13.14.23; Mon, 15 Aug 2022 13:14:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OHSBeCqt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243671AbiHOTaA (ORCPT + 99 others); Mon, 15 Aug 2022 15:30:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343604AbiHOT0L (ORCPT ); Mon, 15 Aug 2022 15:26:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44CF73ED6B; Mon, 15 Aug 2022 11:41:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D657E61120; Mon, 15 Aug 2022 18:41:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD8CCC433D6; Mon, 15 Aug 2022 18:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660588898; bh=atgAS25s2COpB8BFvUkh8vDm4Mkm8/SqFe6Oe0UtabQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OHSBeCqtZkLeMvvCmyf3WdQKwAkItTccoz9urkEG0SfXxGZusO4r7zaaDuFDJZzr4 WOUgyxrWyPQ3IWHeAi1zLRzaMeZAqSl8urY2yBqyQ7zUSIGKdZZz/8ajvswcyjY8OK 7sLQqY0BlSu0PCsA1TOOiyHsCe6wNDvlpE7q9/Vs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bean Huo , Christoph Hellwig , Jens Axboe , Sasha Levin Subject: [PATCH 5.15 549/779] nvme: use command_id instead of req->tag in trace_nvme_complete_rq() Date: Mon, 15 Aug 2022 20:03:13 +0200 Message-Id: <20220815180400.793451288@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bean Huo [ Upstream commit 679c54f2de672b7d79d02f8c4ad483ff6dd8ce2e ] Use command_id instead of req->tag in trace_nvme_complete_rq(), because of commit e7006de6c238 ("nvme: code command_id with a genctr for use authentication after release"), cmd->common.command_id is set to ((genctl & 0xf)< 12 | req->tag), no longer req->tag, which makes cid in trace_nvme_complete_rq and trace_nvme_setup_cmd are not the same. Fixes: e7006de6c238 ("nvme: code command_id with a genctr for use authentication after release") Signed-off-by: Bean Huo Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/nvme/host/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h index 35bac7a25422..aa8b0f86b2be 100644 --- a/drivers/nvme/host/trace.h +++ b/drivers/nvme/host/trace.h @@ -98,7 +98,7 @@ TRACE_EVENT(nvme_complete_rq, TP_fast_assign( __entry->ctrl_id = nvme_req(req)->ctrl->instance; __entry->qid = nvme_req_qid(req); - __entry->cid = req->tag; + __entry->cid = nvme_req(req)->cmd->common.command_id; __entry->result = le64_to_cpu(nvme_req(req)->result.u64); __entry->retries = nvme_req(req)->retries; __entry->flags = nvme_req(req)->flags; -- 2.35.1