Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2883637rwb; Mon, 15 Aug 2022 13:15:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR5sGWi6lKHqEKDG28bsdZs+27P99PuMnZNuMD8Z6nfB4aE2E6FetCVXBohgq1wH5S7Mn6E5 X-Received: by 2002:a17:907:3d94:b0:731:744f:63ab with SMTP id he20-20020a1709073d9400b00731744f63abmr11199698ejc.541.1660594555480; Mon, 15 Aug 2022 13:15:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660594555; cv=none; d=google.com; s=arc-20160816; b=IZGh9zRGUt/nBrt+e89hd01HTOIls41bXLn65vO7EzeSxaG1ojqPQfSjjASIX9qFjf ve7wDz4uilkvXqFHlsuDEYpi2Xn9aMgujTghdALwnXmKZxbwiuEVtE/IIXKInP37srG1 RH5Oibw8PSRcHm6UaEwzOfgzp+TL/RyYdhk7mnsxh61APTDIVtXPvCSxl4n2ApSeRqcC 5k0EFWv5IBmZJa1NYBUHjqZs+6bn/cmVIjlXnXsfQdz1K15hHrHeaqkGju7sjxZfcef7 G2/mrNzzLJf5kshwJ1pUr1ZbsYJHyYy7v8ZRAx0hj70/J+N6k3FzXvN3Nq8T/Vl2mquS cHvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aVEVHyBqB2NU8bhqbrebewB9XchztGknaPQzcd3I6ng=; b=HLyfz12YP6pJn8VQSLoQWpXpjdcBf3H6Iq/tyMFULdqxL7boUBxu2UOTbx8869B3qI whaHiL5UBj0EsNv/7BkzOLUaFAesG/NdvPF/tee8rxwVokDlIvhyzOUU2GzFlaCkgW4D 0fMhPsjfDnC6NdS9NlXfDSlcCPdpcpAzzYv0m03Z3++mi6MRjM5Kzf0ibw7iLkx/8jlM yYUJ7fEQ0X1YnT68EiTSSfshi7f+wG6EYYInyvA07ARo6aFVE4kwYV1B9Duej1+GiGB2 G0pCCI3zy4MuS5b235exDmdV7CUTh1tF5nhxa/S6Q5Hjr9nt8oaTH/gwPJ2viFCTR74f oy2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2Vfbnlr1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w9-20020a05640234c900b0043d62064bc8si9931810edc.231.2022.08.15.13.15.29; Mon, 15 Aug 2022 13:15:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2Vfbnlr1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344321AbiHOTkA (ORCPT + 99 others); Mon, 15 Aug 2022 15:40:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344455AbiHOTgm (ORCPT ); Mon, 15 Aug 2022 15:36:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 282F731211; Mon, 15 Aug 2022 11:46:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B923A611DD; Mon, 15 Aug 2022 18:46:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC5FBC433D6; Mon, 15 Aug 2022 18:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660589168; bh=mUVe9/nmN1h9AHULm+LGHsm4E1xXlvp9qIYrPIpf/lU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2Vfbnlr1dxSa6hhiifsuXUVtRBKWPTWQQTOE6NCBQZOtsx+xOssruU0KJTkVYNtnp jst2hoDhSJOwBV7hwVjt24PM4vpeWL85H4QrHU+7JASAYSaFVsOYgBupcv+9cgRLtN cXJ7fxRSV39m4MR07rqh8ypw6RUvjbNfSjbf5QvA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Mark Brown , Sasha Levin Subject: [PATCH 5.15 627/779] ASoC: qcom: q6dsp: Fix an off-by-one in q6adm_alloc_copp() Date: Mon, 15 Aug 2022 20:04:31 +0200 Message-Id: <20220815180404.173912748@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 673f58f62ca6fc98979d1cf3fe89c3ff33f29b2e ] find_first_zero_bit() returns MAX_COPPS_PER_PORT at max here. So 'idx' should be tested with ">=" or the test can't match. Fixes: 7b20b2be51e1 ("ASoC: qdsp6: q6adm: Add q6adm driver") Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/0fca3271649736053eb9649d87e1ca01b056be40.1658394124.git.christophe.jaillet@wanadoo.fr Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/qcom/qdsp6/q6adm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c index 3d831b635524..4ae97afe9062 100644 --- a/sound/soc/qcom/qdsp6/q6adm.c +++ b/sound/soc/qcom/qdsp6/q6adm.c @@ -217,7 +217,7 @@ static struct q6copp *q6adm_alloc_copp(struct q6adm *adm, int port_idx) idx = find_first_zero_bit(&adm->copp_bitmap[port_idx], MAX_COPPS_PER_PORT); - if (idx > MAX_COPPS_PER_PORT) + if (idx >= MAX_COPPS_PER_PORT) return ERR_PTR(-EBUSY); c = kzalloc(sizeof(*c), GFP_ATOMIC); -- 2.35.1