Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2893691rwb; Mon, 15 Aug 2022 13:28:58 -0700 (PDT) X-Google-Smtp-Source: AA6agR44vNEOl0jTC62vIUvLBLsHPqBwdGiytb18PVOtQV9r2VDC3rLu660lMSXi7lmmrZB1mgNm X-Received: by 2002:a05:6402:2079:b0:43d:a218:9b8a with SMTP id bd25-20020a056402207900b0043da2189b8amr15662766edb.357.1660595338357; Mon, 15 Aug 2022 13:28:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660595338; cv=none; d=google.com; s=arc-20160816; b=pHZgYXj7vV3ydnxp+zP8qHDePe9aJ9o7Vwd9PcfGOAKeexgOZw3StGozeCFkt3T8vJ eljJKNRz9YRqDMoZimtqmUqVHOa1hqeRXg/dwmjS9WSQJNhT3cdPne7cOiYo/9f/yRn2 A2UwYEzh5oalcJLj7Jlz0UdKuXQexevtvgLGVNyiaZlPsTlSHUm7xRYRYaD+LupuoIMm FVmTXCHNP11GUJNja8XbXlhBRQHvjfQ/Z48geE5S2pXPbphGDKXUfcKcQmIb+A5pAEoY HoqlaSinANleCwltM+P9EZO6uHe/ZX7mmOl3rDHRDXnRn1FP03616tYB7aQJM06X4ulT egKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QZ2vbRVQ/BPtfd9N+OipsAHz+V08m4EWCE5TE1Phj28=; b=QJO1xloU/sTum7dRbOXTgPsbXOCv3awlnXcZUMz+HRcMv98c8cX+SOXqTPtPF/da/I 1qUc8oQ9S06lh7vZ/rVbSPjVKTsrh8+P6FV2e9ZVYizS9lEPHK26n5naxCKkob8FHY4l WNnwrVMs9fyo/s7Smh6ISRP2tXhE91IhxXJSXRe6kLiuopNNsVFD9msG5dWVOT6i/T9P sgBATcJj5ZQq7CbBKnTuxUjkRmIKkyl2JSh+LrHf90vSaYMFDGEix7/9JRRHl2obZe6u k0LlR1ry5Xh3jEIGTPjPsHCG22tQWggCVWZLjDBti8OwaGWbvlZF6eAsiYiA9dVTKOXk 9Frg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bR9ieCzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hh18-20020a170906a95200b0072abb95e8e4si7335880ejb.598.2022.08.15.13.28.26; Mon, 15 Aug 2022 13:28:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bR9ieCzQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347408AbiHOUZS (ORCPT + 99 others); Mon, 15 Aug 2022 16:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240593AbiHOURE (ORCPT ); Mon, 15 Aug 2022 16:17:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24A40F48; Mon, 15 Aug 2022 12:00:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD2F2B8110B; Mon, 15 Aug 2022 19:00:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25208C433B5; Mon, 15 Aug 2022 19:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660590013; bh=FU1YbE1E2NkvVleTcRnvyZW61eUHNYJXk19HtY0RX9A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bR9ieCzQucUwbzRG2hTXlxUYajypsp2tviRcVGbNG5VtJXm0stsxlc4UCnlfU9Mwf TdAAmFsgI9urgWZzFjZ/xnryuvenrVHAp5GaLwJqTksYr1qZ7qKg7/mIbrKQdvW662 +CjFroXSdGLVj+nEC4u8IyC+5en07boZh+nXTRqI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jack Pham , Linyu Yuan Subject: [PATCH 5.18 0122/1095] usb: typec: ucsi: Acknowledge the GET_ERROR_STATUS command completion Date: Mon, 15 Aug 2022 19:52:01 +0200 Message-Id: <20220815180434.641471278@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linyu Yuan commit a7dc438b5e446afcd1b3b6651da28271400722f2 upstream. We found PPM will not send any notification after it report error status and OPM issue GET_ERROR_STATUS command to read the details about error. According UCSI spec, PPM may clear the Error Status Data after the OPM has acknowledged the command completion. This change add operation to acknowledge the command completion from PPM. Fixes: bdc62f2bae8f (usb: typec: ucsi: Simplified registration and I/O API) Cc: # 5.10 Signed-off-by: Jack Pham Signed-off-by: Linyu Yuan Link: https://lore.kernel.org/r/1658817949-4632-1-git-send-email-quic_linyyuan@quicinc.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/ucsi/ucsi.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -76,6 +76,10 @@ static int ucsi_read_error(struct ucsi * if (ret) return ret; + ret = ucsi_acknowledge_command(ucsi); + if (ret) + return ret; + switch (error) { case UCSI_ERROR_INCOMPATIBLE_PARTNER: return -EOPNOTSUPP;