Date: Sat, 09 Jun 2007 01:02:49 -0700 (PDT)
Message-Id: <20070609.010249.77260306.davem@davemloft.net>
To: grundler@parisc-linux.org
Cc: auke-jan.h.kok@intel.com, linux-kernel@vger.kernel.org,
       linux-pci@atrey.karlin.mff.cuni.cz, gregkh@suse.de
Subject: Re: [PATCH 1/2] [RFC] PCI: read revision ID by default
From: David Miller <davem@davemloft.net>
In-Reply-To: <20070609065953.GA1747@colo.lackof.org>
References: <20070608224630.31777.17807.stgit@localhost.localdomain>
	<20070609065953.GA1747@colo.lackof.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 920
Lines: 21

From: Grant Grundler <grundler@parisc-linux.org>
Date: Sat, 9 Jun 2007 00:59:53 -0600

> On Fri, Jun 08, 2007 at 03:46:30PM -0700, Auke Kok wrote:
> > Currently there are 97 occurrences where drivers need the pci
> > revision ID. We can do this once for all devices. Even the pci
> > subsystem needs the revision several times for quirks. The extra
> > u8 member pads out nicely in the pci_dev struct.
> 
> Good idea. I always wondered why we read the invariants so often
> in the code.

BTW, if you add code like this, you also have to add the
appropriate code to do this for all the platforms that probe
the PCI bus using a firmware device tree like sparc64
and powerpc do.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/