Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2913357rwb; Mon, 15 Aug 2022 13:57:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR5TprdNPLpj7/42KkWkLz3jPmZAjSwiPSKF8Qecl/XcqOyE4DJ8fjaS9Cb0Lnpk3GcbvWPM X-Received: by 2002:a63:e343:0:b0:41c:d5cd:a39 with SMTP id o3-20020a63e343000000b0041cd5cd0a39mr15428809pgj.512.1660597037248; Mon, 15 Aug 2022 13:57:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660597037; cv=none; d=google.com; s=arc-20160816; b=TGpkDORQ1vxKLFsGFKMb82KkDImG3v3Dt0Y0rh0a8QaxvIVJBiUMlVARsz35Xj/v/y Mj/pu1FYnM5reDIzst+sRsRVvvz+XJtcDMcKWQ8xc6uPo418C/UVRxJehgYECJb7BFN7 I1Mna/C6uNBAOaCG5CakaR0hzYF5c+lxmjyv32V1GnHb6/QG5ss9m1S5VoQxgBsa8trL HIY4EAgEg2/3nBzyOzUCkVZ/KIOY5AzzeBa9FYMxZBzsTEMqNx3qwM+fnpbKlpFJlzv2 1uNTh77f14kI1CXNd2IF/V9jxP1Pdw1yJmgIGc2D9A4iAA/GHP5RnMTv+i8HwDTePMMj seKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BoE41Tn8AJTsSjrAMRvU+7/sep5q4S8/qRf3qtw5qLA=; b=hLgX7MibQZX7ryVqY5aYM3Y9Olpgm8HqvQxQlfr7UeG1XhNJjeKV11Kw4RUC72YYX/ LdxiMctq+L+yp7gKT3Ov0BESLBglgA/Adh63S5w5Gf/GQv/KrxPrB1SvWZkU60yOGwjS mQY0NzOvpvnBIP703McQmLnUjTlITQ7uJzr+A2d5PlEY23+B/vCMtdc1Hnf5w/H66A2v a4uWc2aDJUpfQSOxxjsEqrmVCC/gl7xGG60XNrRjv3Gp6HjBH9pLyB5N9on2/CZutsOF GnRrlK72xLYEw8lspiF+lgg/dEhayZra3FjvEVT6LO4aYYoOoxNT+ytjDQwzyJKlRSKG RR2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bkgFwWL5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q20-20020a056a00085400b0052d48fddef5si11604933pfk.49.2022.08.15.13.57.06; Mon, 15 Aug 2022 13:57:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bkgFwWL5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245756AbiHOTIT (ORCPT + 99 others); Mon, 15 Aug 2022 15:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242806AbiHOTE1 (ORCPT ); Mon, 15 Aug 2022 15:04:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 744732A415; Mon, 15 Aug 2022 11:34:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 083A461024; Mon, 15 Aug 2022 18:34:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A22DC433C1; Mon, 15 Aug 2022 18:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660588454; bh=Y2YVxMxFUYn+u8NnVUBKFgPVl4Mn/bDpZE1Y3UP0Zr4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bkgFwWL5lTdwxXBrSTV6pnBu8ITiprsS7aqwvSFqyovpQURhp/qrKaQe9jlKhck49 Ri4z0ZvN75OyxOCCAHzZ794sizg0pBMg+0AcsJ9CGXsCs8sglLIYz7t2c2V+KHAbRA 7ImMldNQ8g6ai8VGSdsRTXLYlfnp1Ilgdo38NptM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Linus Walleij , Miquel Raynal , Sasha Levin Subject: [PATCH 5.15 391/779] mtd: maps: Fix refcount leak in ap_flash_init Date: Mon, 15 Aug 2022 20:00:35 +0200 Message-Id: <20220815180354.002946786@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180337.130757997@linuxfoundation.org> References: <20220815180337.130757997@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 77087a04c8fd554134bddcb8a9ff87b21f357926 ] of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection") Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20220523143255.4376-1-linmq006@gmail.com Signed-off-by: Sasha Levin --- drivers/mtd/maps/physmap-versatile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/maps/physmap-versatile.c b/drivers/mtd/maps/physmap-versatile.c index 297a50957356..a1b8b7b25f88 100644 --- a/drivers/mtd/maps/physmap-versatile.c +++ b/drivers/mtd/maps/physmap-versatile.c @@ -93,6 +93,7 @@ static int ap_flash_init(struct platform_device *pdev) return -ENODEV; } ebi_base = of_iomap(ebi, 0); + of_node_put(ebi); if (!ebi_base) return -ENODEV; -- 2.35.1