Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2928907rwb; Mon, 15 Aug 2022 14:14:33 -0700 (PDT) X-Google-Smtp-Source: AA6agR4MfsOQ0c2I5k+1CQFiO0Ces1ZFcNbq5r0663K3i7qfh9Ro0gCwVfwsY49fvJaz9qWbpWJX X-Received: by 2002:a17:903:11c7:b0:170:cde7:d24a with SMTP id q7-20020a17090311c700b00170cde7d24amr19080367plh.91.1660598073470; Mon, 15 Aug 2022 14:14:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660598073; cv=none; d=google.com; s=arc-20160816; b=aHLSyGpqsnfmaNcz0gZM3IfgxilWc8btLJYEKdVENw++TeAO38Q+zCF8miXpLLRd9E BZMiYTqLPIc7M0VhxIAkk2rQy53MKC4Lj7nRE/wbHEqJaR3Q2T/B2RjODTGKDDqUcfcr TqgQZLCBPdK9Fz018C5Mgvma/Z22ilzSwKT3cc7Q+/jL2+4f8TM2hItqIKngrdsIRrDI sFbFMh18dYStM7xeg50JSuUE5rVtMOqUJp6YtSR5hf7v93+K3skdPM5N2ZC5IJ30QkHj 11FDKYIpDB6XRma53AfR6aTfcFl/DaQmgpt41yal2eig42ZDsQ0URfGraCg5EgY5FSgV Lf5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SXVCv8gXMsJD+EBRErMsBOBjVplsUT7enrb0K63+X7M=; b=ymM4ADyzgNRKAd4f9Q8HoEDnwGgx5vMNKlEjk88Gwn+U1RdXPQTcvMshbmm/sJp+rv T5HXFwyhiCH8dyDW8HzcqKdFjfT1xApQO0YSN3dfKkvEESLxofXpHcp1XD56TCsrez9s lwPI20pLwdl3O2IAENDZnuA5rqQ5mUA5dMccL8hZMfaIZo3E2UwBSexS2hKfLpkK+nnY y27Cq/CTPqq86m61xtX6OCgRu4JUzaTlwvps6/Oa8OMI5p/mAY42V3eNuYkYKTE4b8PW EkE5j+Qf+zV6P1RvO76cx2+kpfYoJ+tz71DqozbYFcN64LhztIg7uxG0jxreoUCfxlqU 579w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FJMIE1uH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n9-20020a17090a9f0900b001f581939d79si15604979pjp.28.2022.08.15.14.14.21; Mon, 15 Aug 2022 14:14:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=FJMIE1uH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242339AbiHOVFH (ORCPT + 99 others); Mon, 15 Aug 2022 17:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347622AbiHOVCM (ORCPT ); Mon, 15 Aug 2022 17:02:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9A01CB5EC; Mon, 15 Aug 2022 12:14:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 514FC60F27; Mon, 15 Aug 2022 19:14:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35445C433B5; Mon, 15 Aug 2022 19:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660590845; bh=KcEV8SKvsjL468XkPQvCHNAT9nTCGEg25sQJaScv6vE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FJMIE1uHqRV733J8vdWkcMPQ9bmi44MUW1pihXuGQhKi0zczI1Xp4PEIt2BfqFO+7 EJHhUWJrDtsX5SVo6ZDJfAH0rgcmvtqLUoFRXuaU85n+9PD6QSAQ7DY3MtFXCzRm9j PjLBTH4d9DPogI/bqynnlaCi2VT0xOGbe6MFhLtU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Stevenson , Maxime Ripard , Sasha Levin Subject: [PATCH 5.18 0389/1095] drm/vc4: dsi: Register dsi0 as the correct vc4 encoder type Date: Mon, 15 Aug 2022 19:56:28 +0200 Message-Id: <20220815180445.778843063@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson [ Upstream commit 4d9273c978d4c1af15d7874c10c732ec83d444d0 ] vc4_dsi was registering both dsi0 and dsi1 as VC4_ENCODER_TYPE_DSI1 which seemed to work OK for a single DSI display, but fails if there are two DSI displays connected. Update to register the correct type. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Dave Stevenson Link: https://lore.kernel.org/r/20220613144800.326124-15-maxime@cerno.tech Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 81a6c4e9576d..97a258c934af 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -1518,7 +1518,8 @@ static int vc4_dsi_bind(struct device *dev, struct device *master, void *data) return -ENOMEM; INIT_LIST_HEAD(&dsi->bridge_chain); - vc4_dsi_encoder->base.type = VC4_ENCODER_TYPE_DSI1; + vc4_dsi_encoder->base.type = dsi->variant->port ? + VC4_ENCODER_TYPE_DSI1 : VC4_ENCODER_TYPE_DSI0; vc4_dsi_encoder->dsi = dsi; dsi->encoder = &vc4_dsi_encoder->base.base; -- 2.35.1