Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp2950954rwb; Mon, 15 Aug 2022 14:43:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR7H/WwPmQJ2fGnoISWoRwn3PMVA+RtY77Glq70smb1NYH+BuiKX9mXGDUJypcRQJYQgQ3D4 X-Received: by 2002:a05:6402:e96:b0:443:a086:e3e8 with SMTP id h22-20020a0564020e9600b00443a086e3e8mr7963062eda.330.1660599824349; Mon, 15 Aug 2022 14:43:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660599824; cv=none; d=google.com; s=arc-20160816; b=hWd8tJHJqlMuUea88Ipb33gwq3+nJGk2sLE2txAhT11gnjWnLtYALZJFnTi5UM76l8 Qh8U+NFHmkx8fzOwXQK88MbzJwHd0nMDTMo3GqN+LmH/bCfUb8awtL8sg83HPoCVdLnU +xri3b/cIXm5bxVvXrg1HQB/iQUJ5vbj70ZqwLLTUzz/GicrzSSmDiM/Get7nBYZz0KJ V01vaBf1GDtq8RIBG6+wlyk/76wobY3xQLa4BzVkHuNvLMpCU9wyPBflqxp8PXFrgV5x eCpYJ+0EEFRloF152N3cfgcBwAU2yHfv4oiur5b74sAnHX+tr96+EPTmUAyO8oSIoH56 qljg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jzXgD4fhdmhcQ0G1q25J9Zke2AgwOW5z4FQgbMPKVog=; b=Gc+CepBeU31l9TJ/vLFRoAIAWm76N+vk9MBtzUiBcLiZksZm0rLESXYBlhXQVFS+I8 X84UKAresmETyCffEjEqSGsZxUknx20fF2OLAmlyYyjlySHSCt11+sR5bsqKQupi2zG0 4HfPNcE3jcSFY//o95LSfL0d6+irMadwbS/ezu9UekiHXWn6/MORXTJ5nrJH57j3vN9C pgLMtvbfqyIT6umT47Bwali5FV73Ufp6n57e9ruqGzzVTt1ISJCLWiYe8joLiT3XCgtT Z9xvqTUbJfFZQXSCiqOlF58XMs4zXggJPXBqT4qfq2OPtLvhBEblMIeKaqlAwcbLF8jH Sm+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q9DMmt65; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a056402280900b00442c272f4f7si10063235ede.537.2022.08.15.14.43.12; Mon, 15 Aug 2022 14:43:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q9DMmt65; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349461AbiHOVlM (ORCPT + 99 others); Mon, 15 Aug 2022 17:41:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348802AbiHOVhf (ORCPT ); Mon, 15 Aug 2022 17:37:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69AC510AA; Mon, 15 Aug 2022 12:27:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 06665610A4; Mon, 15 Aug 2022 19:27:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0407EC433C1; Mon, 15 Aug 2022 19:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660591628; bh=F1SgTCp/dDpk7c09QkTIr99nEeGl0qlY6WtZRHGFq90=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q9DMmt65T48mK8Je9pxaRmfKmfnRi+7I7ur1Jifuhio19XbKm4PwFS/VqOfkf03mB 7dwpxZR0Q3OP9iyy0RZ4AdysdHihdOk+5DqxFkjYzZ0NJJc3dl1CwsQC0vRHCEUc+y aQmjqhJs0KDiOgU0t2zzkuHurm0heYZ5iPHPYNi0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , =?UTF-8?q?Nuno=20S=C3=A1?= , Sasha Levin Subject: [PATCH 5.18 0641/1095] iio: dac: ad7303: Fix alignment for DMA safety Date: Mon, 15 Aug 2022 20:00:40 +0200 Message-Id: <20220815180455.908832388@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Cameron [ Upstream commit 69e51448ddfb9062efdf83e2d3179498e0aeb293 ] ____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition. Update the comment to include 'may'. Fixes: f83478240e74 ("iio:dac: Add support for the AD7303") Signed-off-by: Jonathan Cameron Acked-by: Nuno Sá Link: https://lore.kernel.org/r/20220508175712.647246-58-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/dac/ad7303.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c index 91eaaf793b3e..558af7926a89 100644 --- a/drivers/iio/dac/ad7303.c +++ b/drivers/iio/dac/ad7303.c @@ -44,10 +44,10 @@ struct ad7303_state { struct mutex lock; /* - * DMA (thus cache coherency maintenance) requires the + * DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. */ - __be16 data ____cacheline_aligned; + __be16 data __aligned(IIO_DMA_MINALIGN); }; static int ad7303_write(struct ad7303_state *st, unsigned int chan, -- 2.35.1