Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3016087rwb; Mon, 15 Aug 2022 16:12:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR4i7fs4YCgEJQcxbtkMT6e1EkNcO1jNGkb4NXvIZUamHa+M58E5kGA77h623bZzFWYgPJ0x X-Received: by 2002:a17:907:728c:b0:730:c005:5d93 with SMTP id dt12-20020a170907728c00b00730c0055d93mr11875223ejc.265.1660605144982; Mon, 15 Aug 2022 16:12:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660605144; cv=none; d=google.com; s=arc-20160816; b=FUO9UhGEwX2wa5Ey/Z1rOg1cRAT5gTGnMpu+ojgHbIl8jMbXcHElrkz9r8Ivg7kNVq 5V/gQVnY9fQ5yRN6i/No3QH8BbWw59FwgVcVgV+OxgcQAZMHVqTRa8GTaehXct/D46XA R5ISxUKoVo6kw0W0/i9onV3/FdCYtj0HHhETOM86RPf/BQpKrIP7D90fUYZGVGtpeOcr fCz1qtNU4CjHUuT691QX9KggNO13cNeui3BDgCfSaHnEMYWrUQcm8IM4zjnFhMGgxvA+ 6U0Cs5LswXZ17EOFL9yny6w9ZjHzlDTRxp+C9ukNlWHthiUpfaz3wKiVyf4qGimNmFLh GjsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6qt7cdkkdhmCM2WnVyvQWV2LWwGsC5gX2llS5nOPwLY=; b=OtDui9eAoWvvfJ2HRqPnRs0ch4qtgSDUrymCsuvqwMQRA6RfkI8XQvCaFKN58Tn/lq kfGAF07RdTrEWHAQmnA0YTjsjzZmc0XTUzJR1QPi0BkQhxpJwv3b6QLmZQS2fNFS2Oub swQS6lsTUU314d23ypFcP99w5oYCgUr6/ctAHUoZdMR13T+dHMRPiGKLMshJ3AosUIWb gg2dm47PvLIGsuiaMDaSWwU//0KnnomfPAiYb8EDXt9rGTSnb/447dBSMmNXsN0lXOtF SPdjAIB5dySeyiz1RbXYryDTWMXJRH5QLYSl0QYtYY7txAiGExzpoPeWH0Xppc4ud2tA 36ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ujuPzGws; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020a1709063b8c00b007320345ef3bsi7301330ejf.583.2022.08.15.16.11.59; Mon, 15 Aug 2022 16:12:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ujuPzGws; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349076AbiHOVik (ORCPT + 99 others); Mon, 15 Aug 2022 17:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349013AbiHOVg2 (ORCPT ); Mon, 15 Aug 2022 17:36:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02051AF0E4; Mon, 15 Aug 2022 12:25:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A0118B81123; Mon, 15 Aug 2022 19:25:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01F8CC433D6; Mon, 15 Aug 2022 19:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660591545; bh=LKS5fls3b0rL9L9SXSmCMaU/hrG7AW6TsELGrKgnn0I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ujuPzGws9vu8CinPTN70X42t8PlMCO1o9+Z+EZ3L4aO38n95xZSpaoOYYXdtBezVx J9cBjTYBheU5bGal4qcD+TE3JfaB1E9FfYXEpX7nldYz740Mj760z5iWAmOgz1iX+K HOa3vgKf29hO1umM2CwhnSl8sAIAPiWaH6XexMyU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , =?UTF-8?q?Nuno=20S=C3=A1?= , =?UTF-8?q?M=C3=A5rten=20Lindahl?= , Sasha Levin Subject: [PATCH 5.18 0613/1095] iio: adc: ti-adc084s021: Fix alignment for DMA safety Date: Mon, 15 Aug 2022 20:00:12 +0200 Message-Id: <20220815180454.864609448@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Cameron [ Upstream commit bb102fd600d1d6c0020a4514197c0604c4a218d9 ] ____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition. Update the comment to include 'may'. Fixes: 3691e5a69449 ("iio: adc: add driver for the ti-adc084s021 chip") Signed-off-by: Jonathan Cameron Acked-by: Nuno Sá Acked-by: Mårten Lindahl Link: https://lore.kernel.org/r/20220508175712.647246-30-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/adc/ti-adc084s021.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/ti-adc084s021.c b/drivers/iio/adc/ti-adc084s021.c index c9b5d9aec3dc..1f6e53832e06 100644 --- a/drivers/iio/adc/ti-adc084s021.c +++ b/drivers/iio/adc/ti-adc084s021.c @@ -32,10 +32,10 @@ struct adc084s021 { s64 ts __aligned(8); } scan; /* - * DMA (thus cache coherency maintenance) requires the + * DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache line. */ - u16 tx_buf[4] ____cacheline_aligned; + u16 tx_buf[4] __aligned(IIO_DMA_MINALIGN); __be16 rx_buf[5]; /* First 16-bits are trash */ }; -- 2.35.1