Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3016695rwb; Mon, 15 Aug 2022 16:13:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR5hdpX/ZSJthFaTYxS+I+Krt5YmlD4haoPJGOLD47rJk7MqOj7N5u6ji/Y1cPsQDNDnBtvx X-Received: by 2002:a17:906:228a:b0:731:3a33:326 with SMTP id p10-20020a170906228a00b007313a330326mr11542813eja.253.1660605190063; Mon, 15 Aug 2022 16:13:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660605190; cv=none; d=google.com; s=arc-20160816; b=MhY9CQlKjufhwlLGzN8WJEpYQ+mVDitkC8aF3niGC4kc4Aklzf+q+jRXtLdMILpB4U BQpGYL6kIyK6KglvPOpVIL0Mt4ujI2XkTOxY0IrENq5V9Mbcph72Akq9alKdt1hzePmU pUtlg3f56Lq4CqE2EYQ5vbd6J++2X3eG9236RGvl1Wyrn418qrWwaRtzgs8vGfjsHtH5 5QDz0dGmrhKWUzg2HaR6K6Wan8Z/hXX2nVhZ2XkVBiBV+ayuXyvnxq2y9Le6wTbL/vO7 wyLCAawvfLt3meTy8N39/4aWT4x+I8Ux7Cw9NPeeUeC9hwarMd6VZRePKIrZUnxIS3Yk oB+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=m9WOQth+XLuj8z4W+tPXm+LoEN5Y7NPq4AaPQjlWqJw=; b=dCMegE0IMOT9jKkLqyVyWVD+rZIGN0ciXZgCxM6MaHkKBGAM053vQC6e6hAhbgpcKR NrUalHb6Ss8BPx1E5Cdy/gXz1c63OaqezgbHGg/8jnQmrQmEvGBbaAGucpZPfSbPnN5c g++3f8QNVWW62cxF1MLtekn2FdscpqiA5nHmnb3bfgMvSsBEV91KV99hYyAa/vkjPtkM 45zlzSiTMh+QNcWeViprXYXtsN80df1hrp3wZmO99o3LaHgMmTa0yYKF10epnp8jSWdz C5RctVfaTEAkzmwOTzmjlnHWWjJ87Omva9WYPLcJTIC2/9EZsNKnMZdMyKOt456xn1+M 5sfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="u/9wcbI1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds4-20020a170907724400b007331436454esi8943165ejc.603.2022.08.15.16.12.44; Mon, 15 Aug 2022 16:13:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="u/9wcbI1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349322AbiHOVyu (ORCPT + 99 others); Mon, 15 Aug 2022 17:54:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350565AbiHOVvi (ORCPT ); Mon, 15 Aug 2022 17:51:38 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8408510774F; Mon, 15 Aug 2022 12:33:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 21AFAB80EAD; Mon, 15 Aug 2022 19:33:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 587B0C433D6; Mon, 15 Aug 2022 19:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660591985; bh=B9x94GFAJ58C5q5QEsDUkX1JGRSes5Nt9uSoHJvL1ec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u/9wcbI1PnQsM98rZn9xqlYW6SXANnPUFUD3W2RhKr3iEyMRy8CCLO9mwcUPJdrF5 XMM0Vq7N9h+n3GRHRK3aCtz144zeHtQESr4dlnPxPrTZSlU9+xOG9GtSwgI1zfWdGj 30jiKgwSmMy0p6zAY2eKOxL//mBNUyPXyI7PCaBg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kai Huang , Michael Roth , Sean Christopherson , Paolo Bonzini Subject: [PATCH 5.19 0040/1157] KVM: x86: Tag kvm_mmu_x86_module_init() with __init Date: Mon, 15 Aug 2022 19:49:56 +0200 Message-Id: <20220815180441.036484267@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Christopherson commit 982bae43f11c37b51d2f1961bb25ef7cac3746fa upstream. Mark kvm_mmu_x86_module_init() with __init, the entire reason it exists is to initialize variables when kvm.ko is loaded, i.e. it must never be called after module initialization. Fixes: 1d0e84806047 ("KVM: x86/mmu: Resolve nx_huge_pages when kvm.ko is loaded") Cc: stable@vger.kernel.org Reviewed-by: Kai Huang Tested-by: Michael Roth Signed-off-by: Sean Christopherson Message-Id: <20220803224957.1285926-2-seanjc@google.com> Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/kvm/mmu/mmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -1654,7 +1654,7 @@ static inline int kvm_arch_flush_remote_ #define kvm_arch_pmi_in_guest(vcpu) \ ((vcpu) && (vcpu)->arch.handling_intr_from_guest) -void kvm_mmu_x86_module_init(void); +void __init kvm_mmu_x86_module_init(void); int kvm_mmu_vendor_module_init(void); void kvm_mmu_vendor_module_exit(void); --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -6275,7 +6275,7 @@ static int set_nx_huge_pages(const char * nx_huge_pages needs to be resolved to true/false when kvm.ko is loaded, as * its default value of -1 is technically undefined behavior for a boolean. */ -void kvm_mmu_x86_module_init(void) +void __init kvm_mmu_x86_module_init(void) { if (nx_huge_pages == -1) __set_nx_huge_pages(get_nx_auto_mode());