Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aac4a43d-4999-1da5-a617-b512ae0b3982@oracle.com>
Date:   Mon, 15 Aug 2022 12:19:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 1/1] sched/fair: Fix inaccurate tally of ttwu_move_affine
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     mingo@redhat.com, vincent.guittot@linaro.org,
        juri.lelli@redhat.com, dietmar.eggemann@arm.com, mgorman@suse.de,
        linux-kernel@vger.kernel.org,
        Daniel Jordan <daniel.m.jordan@oracle.com>
References: <20220810223313.386614-1-libo.chen@oracle.com>
 <YvonlUOgMbla6dSh@worktop.programming.kicks-ass.net>
From:   Libo Chen <libo.chen@oracle.com>
In-Reply-To: <YvonlUOgMbla6dSh@worktop.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDlXTDY1b0V1QVRQYWhLZVo3N0ROeU9YOHRjYml1UXRsRmdWb08wL2IzQncx?=
 =?utf-8?B?cllZVS9UL0Z0SXF6dlJ4VkxuVThrVDRVUFVrbk0rNWRLdlBDTnFLYVU5S2Jo?=
 =?utf-8?B?cXpCQ1dBWWJzZHRPeDlML1Y1RVFlTDczYy91dThQMERBQi9pYlV1MXZUWWM5?=
 =?utf-8?B?eXpPRmxIbi92a3V3WHFoUDVycGFnYzJjTkJ6dTBVdTZDY3RHTWIzYVduT2lG?=
 =?utf-8?B?YVM0VDZhWkkzV3UrM2RKbGE2ZGpaallPcmRMS1hkMjgydW9XVFJhYWhRVTRx?=
 =?utf-8?B?eHROU0t1WHJqZnprblBDTitld2srdDg5bFB2RlE1cUsvMHRQb01XdVhyMjRP?=
 =?utf-8?B?M0JrZzFKUGZHdEV2MkRGdWlXM3U1aFFXa2dYWFBWS3hLS1JLcVBYbHdSRDBQ?=
 =?utf-8?B?dENoL25MaDJ1Q05LL1A0N2krVGFjcXdmY1Zhb0psaXhKMmxtcXB3R2s5RFg1?=
 =?utf-8?B?Mm1DbnExYW94bnpHTmtycmU3SWJkdlJVQWkwd2pQU0FNMEcyU2JGb1RPYWwx?=
 =?utf-8?B?eVh4Z25zQS9EQ3BzcnRYbE4zdCthUTNQWWxMeEdVbnpvQkFteUE0aWFtMGhJ?=
 =?utf-8?B?Q1gyQVJUVjVvMVdNNnZBT2tMOUlZb3ZsSnVJSC9JSDArd3U1L0pLN2NNZ3Vo?=
 =?utf-8?B?Wk9PTG42SjRESGVQQmxTVzdvbVlOSG9ScTZzRjY2eVVORk52RlFteGR4bEVZ?=
 =?utf-8?B?djJmS20zUlk4elNYdHZzTkJUc2xuNndvT1IrWmJHblNNQ1NPMkFuRzJ4Vkp0?=
 =?utf-8?B?ZmJSUnRsTzY3Ky81UVMweHhVVW9vTjU2b245d1pvcXNSYVN4TXNoZkJ4TG9y?=
 =?utf-8?B?MFJSc250NWFaV0pXTXVha3g1cXJMWTNTeUdrN1dGcmhTMHVCVlBGd1NUTlI3?=
 =?utf-8?B?dFdGZFRjeGI2eXd1b0VoREg3ZjBrNzFla1lmdU1mTEdIaWZaQWlLeTh2Uyts?=
 =?utf-8?B?UmcrUXZTUDc0bHVPUU8wZGdjbG1pMW1qUndtZTNIcEdVSmdIUTR4Vnh5KzBr?=
 =?utf-8?B?M3A4bW5URWQ2ZUFaUlB6c3YzalZsRklWN21GRWJucVlnaDN4cFJCcEJmTXNr?=
 =?utf-8?B?emVnTkp3UThyK1QrQzhLMXFFYkVNTTJNQnd0UFhGalEzZlVkM3JBbmM4R2wy?=
 =?utf-8?B?N3I3cGxaeHB0aFIwbnk3TUZxeG5uYVdBOGdBbVRwMDZ5cnRpS29mbmhRUU1u?=
 =?utf-8?B?Wkx4UTNyUVNPbzRBVTZOYUo3Sm1kS1gvR2c5blE2NS80UXVIakQzZjFKQUJN?=
 =?utf-8?B?V3hCSm9wRTI1b296NmNHaXdwQjd5OHo3K0NnQTJVOXhJNnJIa0tsbWx0dytT?=
 =?utf-8?B?NUhiYUVtWVZURkVrZ1BpVjZhdUNncGtWQnVvTGNtSmxKTDl2eFdzWnd1WXZK?=
 =?utf-8?B?cnJ4Z1NwNnloZkZEaWRwcEV2SjIwbDRUaExYR0NraGZvWEp4RExxNTdESzcv?=
 =?utf-8?B?T2hJb2JsV3kvcWNmL0llZUlWcHcyRlA5NlR1WUNLOEs3R0ZHb3h3VTQ3YkFZ?=
 =?utf-8?B?RHg3UzFKQWoxanVCbU14Sk5NS3VVU0VFSFV6UEpzaHRtVm9OeGxaWTlDN0xY?=
 =?utf-8?B?aTRRcDZFeWgxcnVXUk9semZ6MU44VXRQbUFRaVNuM0JQNE1jSW1ya2pQUDNv?=
 =?utf-8?B?VGxacVFLSmp4Nkx3WnhsUVFNbXp5aEl4MEN6K3lLcUdJL1hJdFJVTkFWbXhM?=
 =?utf-8?B?MjZIQitBd0xPWUpPd2Y4MDF3K2tJb1ErYUp3cjVMR2RzZ01lY1c4eG1IZG1x?=
 =?utf-8?B?VGJ6eUd3OExPUVBaUEllV0RTRmNvaGtBTk9ob2xKbm12a0NwM2c3SmcrWUpZ?=
 =?utf-8?B?RW1jNlEwSHV5K05HNVQ0YWNsM0xSNVdma1llaDVYMk5HRjhQOG1RWTBDdy83?=
 =?utf-8?B?ZlhBNGRxZjg1L09ocldNa0F5TWJmSGZKUHRVamhSNll0cGo4anFhdTI1Q1Qw?=
 =?utf-8?B?bUNnbUp6SnJ1M3pkQldQVHlYbzNFQW5ya0t3Nkx5NWtvUlQ2SDVzZURPdHAz?=
 =?utf-8?B?elc4amt1RkN2NjZDNXVISkRvbGEvUDZkUS9TcElwZ3ZDK29rc3ZoSUNpZkNh?=
 =?utf-8?B?QjJZZjdSa0hlMnRsQmZSZnB1VnpaM0RGWHdmaG1Nb0VBYkxPYU1wMkU3NndL?=
 =?utf-8?B?MG9jQU43MWFGSmE1YjBVVFFicWZEdjhlc2F4YzN4WmovYTBxYzJDWnp0UXNO?=
 =?utf-8?Q?buH8ga6AZqgVmyfUO2746ZI=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?L0tNVGNFM0xDOXY1MU8vTGkxeitQZVpDK1JmMHhxRkpiejROSWgydlhoYXhC?=
 =?utf-8?B?OC84eC9DaDNiSU95eXcrNmtZcjZBN1VsR1B6bG1zSW9qdlNrV2NZRGwrODY0?=
 =?utf-8?B?M3NwbkVlUkpVSmxydlVnZzRQQTU3UCtuSUVidnJZN3MrdnJ4b2ZvaE80YlFQ?=
 =?utf-8?B?N2tqKzJTbUhvTERGbG1DNWxIYU42MUZSWFhZNVNjckY3K09NU3N4VzJUaHBX?=
 =?utf-8?B?SHhFZnJDOXYvRWpmZzFBbE1vOUQ3NTBkWDM0YWliUk9lY2NJRTJKOHpjU3pU?=
 =?utf-8?B?dDJGaE1nSXJ0RVVHWnNMY0dTODBXOWx6TmhHTDVXZmpXU3daT2JmTnYzR3dW?=
 =?utf-8?B?OVVUdllxQURqeUp5bnFacGJYaFNwUldPcVdnZWxNYUdUcEtJK3NFUklucktU?=
 =?utf-8?B?Y3lZaW1sa3BGd1dkNC9PNTRzeDJUUXBPUjVENUN5YXlmSFdOZDU0dmNxMW5C?=
 =?utf-8?B?d1N5K0gvQ0pJRTh1UGhvRVFNWklpL2tVbVQvNXFrZlZST09UT05JaFFSbEsz?=
 =?utf-8?B?NktZMTQzNEtheTlDeUxsNkFtdEZmYllBZHg1Z21OV0ZVVm1PbjNYSTBVdDdy?=
 =?utf-8?B?ZVE3OHE4ZUVzMkY5ZW1hQnN0aDFLK1NrQzRWU3U2dWZ2MUQveHJJbWYwU1pD?=
 =?utf-8?B?UTE5bTNzS1YvOUpSR2pNVERFemlhNmEzc0tFUHJXRjFLR2JrNnFCTjdOS0xj?=
 =?utf-8?B?WTRpdGErSXZHWEs3MERRbndEeVJieUhmS2dNTk5YWThvQ3NkdUtkS0FpZklz?=
 =?utf-8?B?dXFTc0dqSGVFNzdMT2d0Q2NMMGdocW82MWtac2NIcDdidytrd012U0p4ZXJF?=
 =?utf-8?B?TDJjOWRVVTJIUnM2WEtKNGpkYU94cW92WWRNYm5NZWt6UElKaVIzRkVVc0Zx?=
 =?utf-8?B?SnFrKzBxa2drTHBRZ3dHSzVLWFZUbjdaUlpmUEhHNElOZHo5NEJVNXlpUUxR?=
 =?utf-8?B?S3lpVFgrZUkvU2RleENUelRaUytpbnFOQnFqbFpoME92TVd4M0NRM1JIY29S?=
 =?utf-8?B?MS9BOWxiQUQwRVVrQXdMSFR3SUVDUlMrNGZ5MmlYaUlRSnlXMDdYVk11MnN1?=
 =?utf-8?B?aXB2MWZ4cW5tQlU5UzMzVGUzT1NaU0pUSkhUUXdMMDU0clJibmdrUi9oQ1lY?=
 =?utf-8?B?VzBsSGRURi8xQW1NSUVUcmI2OWc5aUJHSEtST3BKU0FDU1g2UDROKzh3dGxz?=
 =?utf-8?B?M3hVZnJWOVNSZDE2aFc1K0xVaVdTSzQ5aU5GaFRBYk9JSFhab2hudWI1aVNt?=
 =?utf-8?B?cnV4bThGMDM0dERLZ0VXK1kva1Q3aDF4KzVTU0NpT0QvbC82UDlHS09XNFp3?=
 =?utf-8?B?M2pHMnptWjFVMXdhcU4vR1hwQ2NaeUYxWlB0WS9PVHZPWStYSVJEYWY0SGVx?=
 =?utf-8?B?Ym1kUkZNL0VJWGhhZzZWMm94Z3pyY081bjAwYUYrYzVmejZ4cVlFQWF2V0Zn?=
 =?utf-8?Q?EHC1zM29?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 60117c0b-1c85-4c2c-b38a-08da7ef304d1
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2022 19:19:05.1069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DJJWEJokAwvFezssPJuCClLDMP7ntUSgIH8YYOsuoS2KFMj87jG8L5XPWthbu1Jg0uqTK1IGmJg137hH5dk8qA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6177
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-15_08,2022-08-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208150073
X-Proofpoint-ORIG-GUID: -mRl_wcgF48clhsVPr6oaVdEC-goWKu2
X-Proofpoint-GUID: -mRl_wcgF48clhsVPr6oaVdEC-goWKu2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/15/22 04:01, Peter Zijlstra wrote:
> On Wed, Aug 10, 2022 at 03:33:13PM -0700, Libo Chen wrote:
>> There are scenarios where non-affine wakeups are incorrectly counted as
>> affine wakeups by schedstats.
>>
>> When wake_affine_idle() returns prev_cpu which doesn't equal to
>> nr_cpumask_bits, it will slip through the check: target == nr_cpumask_bits
>> in wake_affine() and be counted as if target == this_cpu in schedstats.
>>
>> Replace target == nr_cpumask_bits with target != this_cpu to make sure
>> affine wakeups are accurately tallied.
>>
>> Fixes: 806486c377e33 (sched/fair: Do not migrate if the prev_cpu is idle)
>> Suggested-by: Daniel Jordan <daniel.m.jordan@oracle.com>
>> Signed-off-by: Libo Chen <libo.chen@oracle.com>
>> ---
>>   kernel/sched/fair.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index da388657d5ac..b179da4f8105 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -6114,7 +6114,7 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p,
>>   		target = wake_affine_weight(sd, p, this_cpu, prev_cpu, sync);
>>   
>>   	schedstat_inc(p->stats.nr_wakeups_affine_attempts);
>> -	if (target == nr_cpumask_bits)
>> +	if (target != this_cpu)
>>   		return prev_cpu;
>>   
>>   	schedstat_inc(sd->ttwu_move_affine);
> This not only changes the accounting but also the placement, no?
No, it should only change the accounting. wake_affine() still returns 
prev_cpu if target equals to prev_cpu or nr_cpumask_bits, the same 
behavior as before.


Libo