Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3022222rwb; Mon, 15 Aug 2022 16:19:42 -0700 (PDT) X-Google-Smtp-Source: AA6agR6v3cdVJ1JE/fPkXL/xoxL5MYFZ5SzGwqki13EXeo6+G73WqAsZkfgyBMgNSphJ38ennjSB X-Received: by 2002:a17:907:7fa7:b0:731:51b4:5020 with SMTP id qk39-20020a1709077fa700b0073151b45020mr11534815ejc.352.1660605582103; Mon, 15 Aug 2022 16:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660605582; cv=none; d=google.com; s=arc-20160816; b=s3jDCBFlfkoE3enX+cEJ5R7YUcmjXDT8rlW6AnW0NBfQS0KtOfFufumg7uayjXURsF ubc0imq2AIAxm2dvq5iXHBYzSt8Y5+slqd2VIi/3zIjhPU/PE0WO8nTSIb0jh0t2ky/p h2MPsa/EcHcZdACOnQdp/3JTYATCmmpHMgdasjhFJUYi1Gqnx3RlUbBaYDWlc/yUkF+c XK3Zg6Hlfo84E1fS4Vx9lqWooYcr5Qkvueyw4VlDAEtPVt/QN0gOhJ9xGlSqq73/B3QB cH7oyKlOuam5BlfVwHaeTZEr9Bz7mnHRRlZBuZNqyUV0ZBCVsS7YdOga3CEQefVBcXh3 7muw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CzR+G/L1wbGIkY3jJlBIxwh6XUJw90Be3uBN1joGMH0=; b=CKGctLCybjkrSoS6HiZ77n8uCC0TweuN61yuA/OfoDrUkJ0yHanXw6jrC4ZrUI4G60 nh6gmmTc+PKWECl/lSCuttOz1eQ346r1SBtWB7DDn82Gl4iCRGdMAuze3WBhF/ed4mar To2Ys8Upnn9YcIeZylY33e9jTnouLCSm7O7cYHXakEEyyU1wswBT7tMBUOvps4o44MEv dKV82h5/gI2xtggHLSW2y4Nqo68R6lH/iWa4WHgGVM/hB0d5qkwEVhRlzqjkB0Gw8lHq ksT6d7Xt6XBA5M8w2DKs6ZvjHkfLWC4LYXPhriCRVKbb9tIe6LnkaMiqYFaV5vtM/dVB y6xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fTyF1Ho3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p17-20020a056402075100b004381b6af19csi8284841edy.155.2022.08.15.16.19.17; Mon, 15 Aug 2022 16:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=fTyF1Ho3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348872AbiHOVkb (ORCPT + 99 others); Mon, 15 Aug 2022 17:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239483AbiHOVhA (ORCPT ); Mon, 15 Aug 2022 17:37:00 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB48EBC; Mon, 15 Aug 2022 12:26:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 2E1B4CE12C4; Mon, 15 Aug 2022 19:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BEBFC433C1; Mon, 15 Aug 2022 19:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660591603; bh=MYq0vri+hL6QZjF+gfUQ6522RBfujaX6ufFN70VX1Qs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fTyF1Ho3Mec4OLEU09mT7EuA2tST94H+v03cI691NFlv6nDI3ob19Jjh90JS44YBd G2tyCIItArGCO0CKozp+pWlNe+UVsLKBEvwMMikNUWn8Ppj/4t33tRRhacgN36P4Bj T1eAfpIaAmax0VXPKG6cRlwjC2N74Ar4N9iGwow8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , =?UTF-8?q?Nuno=20S=C3=A1?= , Sasha Levin Subject: [PATCH 5.18 0634/1095] iio: dac: ad5755: Fix alignment for DMA safety Date: Mon, 15 Aug 2022 20:00:33 +0200 Message-Id: <20220815180455.655796517@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Cameron [ Upstream commit d0c167ceff2d833ee493dd58164dc87bd36e48aa ] ____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition. Update the comment to include 'may'. Fixes: c499d029d805 ("iio:dac: Add ad5755 driver") Signed-off-by: Jonathan Cameron Acked-by: Nuno Sá Link: https://lore.kernel.org/r/20220508175712.647246-51-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/dac/ad5755.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c index 7a62e6e1d5f1..bbb345323b69 100644 --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -189,14 +189,14 @@ struct ad5755_state { struct mutex lock; /* - * DMA (thus cache coherency maintenance) requires the + * DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. */ union { __be32 d32; u8 d8[4]; - } data[2] ____cacheline_aligned; + } data[2] __aligned(IIO_DMA_MINALIGN); }; enum ad5755_type { -- 2.35.1