Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3026647rwb; Mon, 15 Aug 2022 16:24:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR6F1Pnvd0kDquQF4RRL1s1OtSSZ5dtcHduS59kmuZ9qRBnA7GDBGladK6/U/1Ps9WPpGpMT X-Received: by 2002:a17:907:87b0:b0:731:3dfd:bc8d with SMTP id qv48-20020a17090787b000b007313dfdbc8dmr11334951ejc.607.1660605791497; Mon, 15 Aug 2022 16:23:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660605791; cv=none; d=google.com; s=arc-20160816; b=QiLE/dIfORyhs+o5baNUDjBla57Ncl9nGXoHTQ6oUwmaSU0tzvtbq90g8fvs0xMWrE xk1oNP8xkwcjKjKmq3CpdPxWDFUzlW5+pHVseWH6SdLKVMymxPWwFOMO9Lch4kUxo2lj qdo5aHfpV9RPhaVUHpB470E8xhmO+kDUoAZGnQXACnMjXnC1qcnqAwI9e9yQ0dJBqdDs 300I0TRBs5E3FMtX6GDSXHZwW/8wy47NNbHelzzZgm83ACmzUvrXvwoLKFk32jTi+a3j fMt6kp/pLzOYp1MNGvgLYAB+76jun0DrAtkwWVJLBz7j9OAJdFLr8cfbssqoyL/8r0/0 UrAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=krpFJMKnaHw4LccCuHoYK4yHy3Uen5evcW8YpZkY5aY=; b=QXsEscQSrIsCE96FMcl3y7gU7Z/OwM7uz+yVnBb4meP4UM6f05+yB+urLNBzWKWZ3D elPf68KMuJwVf/JA25Dn0fpZ7Tog4kbMGvcqIEeQTRObOOq1lUNMwfMfeeSaarhLkQcH RXipoZBhTPd3gfMlY/tN0pOgSIpBnZYrhPpFKOA/xnMGYDkPrFQro4iffy8omsU7q/IO eTlLySHuymCd+z0QPTgKfnLocodQ7sdEHAqUH/uDWBRonib3FZbDCYouxEvkih/RGaj3 5M4ktN/qxyVp5gF8lXXuN+4D7wMnAZ/RV9p0aAPUgyP6fpYZFlo+1zvtWETpSW/zyZcU zCqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dYLtOJK9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n19-20020a1709065e1300b0073045295788si7543827eju.533.2022.08.15.16.22.46; Mon, 15 Aug 2022 16:23:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dYLtOJK9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351096AbiHOW1g (ORCPT + 99 others); Mon, 15 Aug 2022 18:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349406AbiHOWV3 (ORCPT ); Mon, 15 Aug 2022 18:21:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CA2BB5A58; Mon, 15 Aug 2022 12:43:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E0A761215; Mon, 15 Aug 2022 19:43:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16665C433C1; Mon, 15 Aug 2022 19:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660592620; bh=P6zsy+Br50IxBtDghnh0AItILePGuWVPwZtgnBjUs34=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dYLtOJK9Fqje69L8m6W5CO9Bv5qV90yWOT0cuQ+DbncWQ0ne2KSn1pZLGUOAMXHDo PreaIin5kNPJav+iJWnV/AShWfPCqxain+3gy17qTgJH8gHpynwPTA/I74vSQw9bu8 p/iiSsxVlBTvyhgBDiBFwRjb8KbdgGWVOKM8o1PM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bean Huo , Christoph Hellwig , Jens Axboe , Sasha Levin Subject: [PATCH 5.18 0817/1095] nvme: use command_id instead of req->tag in trace_nvme_complete_rq() Date: Mon, 15 Aug 2022 20:03:36 +0200 Message-Id: <20220815180503.076313071@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bean Huo [ Upstream commit 679c54f2de672b7d79d02f8c4ad483ff6dd8ce2e ] Use command_id instead of req->tag in trace_nvme_complete_rq(), because of commit e7006de6c238 ("nvme: code command_id with a genctr for use authentication after release"), cmd->common.command_id is set to ((genctl & 0xf)< 12 | req->tag), no longer req->tag, which makes cid in trace_nvme_complete_rq and trace_nvme_setup_cmd are not the same. Fixes: e7006de6c238 ("nvme: code command_id with a genctr for use authentication after release") Signed-off-by: Bean Huo Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/nvme/host/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/trace.h b/drivers/nvme/host/trace.h index 37c7f4c89f92..6f0eaf6a1528 100644 --- a/drivers/nvme/host/trace.h +++ b/drivers/nvme/host/trace.h @@ -98,7 +98,7 @@ TRACE_EVENT(nvme_complete_rq, TP_fast_assign( __entry->ctrl_id = nvme_req(req)->ctrl->instance; __entry->qid = nvme_req_qid(req); - __entry->cid = req->tag; + __entry->cid = nvme_req(req)->cmd->common.command_id; __entry->result = le64_to_cpu(nvme_req(req)->result.u64); __entry->retries = nvme_req(req)->retries; __entry->flags = nvme_req(req)->flags; -- 2.35.1