Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3030673rwb; Mon, 15 Aug 2022 16:29:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR78cWGTrgYC2F1fCqfp7sE/MK7sv6Vz2iYkp7SvdK7asRt/jd8rAUMB7I73fxf/AS8zvZhJ X-Received: by 2002:a05:6402:34c6:b0:43d:8cea:76c0 with SMTP id w6-20020a05640234c600b0043d8cea76c0mr16917902edc.268.1660605823055; Mon, 15 Aug 2022 16:23:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660605823; cv=none; d=google.com; s=arc-20160816; b=A2+RC7vzVsWKLBLD/ieSSqI4TVPjsA88pOhu9HuA3n/au7pKHG7ic1EKlatjSQG+LL iD6iqE95ZwxGTIKNW2TkFGR7rgwzg21ua4iO8lXHZ18opucrw2wCXqxKRNw3Wqi1pR2J rJI1EFURNdUtNgOOD+mAklqNK91QoLliKnRS+Q4rFGEckwS37/X67c6ZDhhS+XqSAmgS EilTGCjdHDJO4jnuFxgz75ONUmVq8jwDH4d/U4dQFOwELZdbc4eTaBfYYVlVYLc0daYx Hlc+I1e5vWrXvMrcmucELEPbbQdzLFVORbuggRPKjqIv1nNLOe+ODTKkySerw7slRj34 uuRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hZ4SygZiRu7JPlOoF3oLl7fTkOMR8nonZRjsEDKQ0+g=; b=z7gTjjMogNRuGl/B7OqR0udIM4aX1MM0HZuKXgf5l+H44/qSSLPPrc+h037fMhfHsq 06jjT7yyLy3KGxY/IcHfDRkgkDs7Mk0/w3CCQ4t9TCCcZzXTubAgtdryvwK6gnUUYzb0 GneELOVI7Lw1ryXgbVbIozpTcYMvw1q6eSFc41mVzlLC60LtoYoZyhPhHUPZ67ROnDEk y+YTqv2p9xov93d8US9q8MnkTyUBdKSUozApPxBz76TNttmtH0Q0/GJyloTRWIPlN44R QRwUJ1gLiVBQvZPn0wNJZMyUl+F9IB/az5jtoxFhxF7SKyHxX4rLFq8RDSy2kUg7svAj zb/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RVs3aSDH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ji2-20020a170907980200b00733e46f4543si9299686ejc.820.2022.08.15.16.23.18; Mon, 15 Aug 2022 16:23:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=RVs3aSDH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347319AbiHOWTa (ORCPT + 99 others); Mon, 15 Aug 2022 18:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245684AbiHOWPk (ORCPT ); Mon, 15 Aug 2022 18:15:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 852306745A; Mon, 15 Aug 2022 12:39:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48120B80EAD; Mon, 15 Aug 2022 19:39:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98D82C433B5; Mon, 15 Aug 2022 19:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660592366; bh=NnNp7DWWOboATNhkynY0ZdcfWWZJZrnmvFmpd0g1rf4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RVs3aSDHMCZrozmDbROchD1tQkB/8iKtW3UmRlM4PvW6CaRYK2tXHXwIw3PtC6Uc2 81wKCHQ5u80FveA7XXQOUciFkYXBTyTJjO7NEcPwoYqKVBMiVBCPTLbiuU4Ewz8lvi YR0CBoU3bimDdYHBWfUNDsP0z/9CSUOheBBYU1Rc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jianglei Nie , Dennis Dalessandro , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.18 0776/1095] RDMA/hfi1: fix potential memory leak in setup_base_ctxt() Date: Mon, 15 Aug 2022 20:02:55 +0200 Message-Id: <20220815180501.371731518@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jianglei Nie [ Upstream commit aa2a1df3a2c85f855af7d54466ac10bd48645d63 ] setup_base_ctxt() allocates a memory chunk for uctxt->groups with hfi1_alloc_ctxt_rcv_groups(). When init_user_ctxt() fails, uctxt->groups is not released, which will lead to a memory leak. We should release the uctxt->groups with hfi1_free_ctxt_rcv_groups() when init_user_ctxt() fails. Fixes: e87473bc1b6c ("IB/hfi1: Only set fd pointer when base context is completely initialized") Link: https://lore.kernel.org/r/20220711070718.2318320-1-niejianglei2021@163.com Signed-off-by: Jianglei Nie Acked-by: Dennis Dalessandro Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/file_ops.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/file_ops.c b/drivers/infiniband/hw/hfi1/file_ops.c index 3ebdd42fec36..686d170a5947 100644 --- a/drivers/infiniband/hw/hfi1/file_ops.c +++ b/drivers/infiniband/hw/hfi1/file_ops.c @@ -1179,8 +1179,10 @@ static int setup_base_ctxt(struct hfi1_filedata *fd, goto done; ret = init_user_ctxt(fd, uctxt); - if (ret) + if (ret) { + hfi1_free_ctxt_rcv_groups(uctxt); goto done; + } user_init(uctxt); -- 2.35.1