Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3083948rwb; Mon, 15 Aug 2022 17:44:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR7POLfT4qAd0zMOfIM0sN/0E8+UiJZ95DO9W/UUsCknd7ZtCAWIBQaC0wdHv+AcLlNO4SqW X-Received: by 2002:a17:902:e744:b0:16e:f6c2:3731 with SMTP id p4-20020a170902e74400b0016ef6c23731mr19997578plf.104.1660610651102; Mon, 15 Aug 2022 17:44:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660610651; cv=none; d=google.com; s=arc-20160816; b=qr2UTs6z+kJJUCzjzKvhDwkycfARnEPA2XdBFApse+tTYrLi+TFItX/iExu8XyJZsK viVmutmKo4x4/u4MN6WqYJ3q900LQMXegv+YKfs43MHh5PnOYTprihZUsVTU0bu164wt ELnBdanjPS5OW9u1pSrLklzGivYD3ZWEFLUvyGPcFPU4bevgQ1x0dnneZxOUW3VYjQwS 76qKlQmYOf9PkVUSNmYjk4xlWcg9GDZuFqZ49FQhA9GIAI/WObXAKYo6iqpOQeoyvzKT CGpzl/QegiBGy9XYGgMYumICGCCaxrL69EHm/TuRQSafn0+WoZXE69H+oIGU29Lqn0SU nb2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UltWS3kXE2mu6qm6i6MPdP49uG3gKvFVmgzT29mI4y4=; b=dvs7gSFFgsBm04Hq/EMq4wnEbQ6Q1Hn0wtjWzlxmRGS/wNYhYf55UEhYUdJRJW25n6 jwfwhnRBAR717nxBEK3FoS+w0hwfSSlGd+oM+E1tYHGlECLwNThB3b4HOQPWRYujVd2H tqHysNKzCWrw2wdx4RpPrqp5YKLzV2R6aHfJZDgEvhUryOdg3+wV5CzvdyPnoIV8cLmC YagH4ndg9f83MMCe65MQ3bYmMaq3cywUm9sOq3j8aZoO2G/NAHeyVpxlnEGhtdxEqzcD ApjnRANA/KXii9JfUlhkEQdbxRdNqKnjbn723TJQN1RfkPwDD8PySN7SW5TedU8g0pkP SM0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=INXs3dCR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c4-20020a170902d48400b0016ee6e782a4si13132955plg.560.2022.08.15.17.44.00; Mon, 15 Aug 2022 17:44:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=INXs3dCR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345362AbiHOXdS (ORCPT + 99 others); Mon, 15 Aug 2022 19:33:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345396AbiHOX0s (ORCPT ); Mon, 15 Aug 2022 19:26:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E32A80F52; Mon, 15 Aug 2022 13:06:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 50894B810C5; Mon, 15 Aug 2022 20:06:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87050C433C1; Mon, 15 Aug 2022 20:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660594012; bh=RhHLeYGdNEDcEC9n0pCBwyvJaJEEUECb9tN9lvLQVCc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=INXs3dCRb7zt6q6uqj3RJ1sBsmpDebeYyWHUebY/YsDJV4Ggbjtg4mDG05w5fg8aF UeYwjqwTpuLxAcase/evdp3+jGP2IHOJgs9C0QCGOUrjighLCujK8twFMTfpu9ffZ4 1WG+uQh+X4qNZyhzFh+3+F/jFRglr9sMsaCFxkwg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mikulas Patocka , Mike Snitzer , Sasha Levin Subject: [PATCH 5.18 1042/1095] dm raid: fix address sanitizer warning in raid_status Date: Mon, 15 Aug 2022 20:07:21 +0200 Message-Id: <20220815180512.194205458@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180429.240518113@linuxfoundation.org> References: <20220815180429.240518113@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mikulas Patocka [ Upstream commit 1fbeea217d8f297fe0e0956a1516d14ba97d0396 ] There is this warning when using a kernel with the address sanitizer and running this testsuite: https://gitlab.com/cki-project/kernel-tests/-/tree/main/storage/swraid/scsi_raid ================================================================== BUG: KASAN: slab-out-of-bounds in raid_status+0x1747/0x2820 [dm_raid] Read of size 4 at addr ffff888079d2c7e8 by task lvcreate/13319 CPU: 0 PID: 13319 Comm: lvcreate Not tainted 5.18.0-0.rc3. #1 Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011 Call Trace: dump_stack_lvl+0x6a/0x9c print_address_description.constprop.0+0x1f/0x1e0 print_report.cold+0x55/0x244 kasan_report+0xc9/0x100 raid_status+0x1747/0x2820 [dm_raid] dm_ima_measure_on_table_load+0x4b8/0xca0 [dm_mod] table_load+0x35c/0x630 [dm_mod] ctl_ioctl+0x411/0x630 [dm_mod] dm_ctl_ioctl+0xa/0x10 [dm_mod] __x64_sys_ioctl+0x12a/0x1a0 do_syscall_64+0x5b/0x80 The warning is caused by reading conf->max_nr_stripes in raid_status. The code in raid_status reads mddev->private, casts it to struct r5conf and reads the entry max_nr_stripes. However, if we have different raid type than 4/5/6, mddev->private doesn't point to struct r5conf; it may point to struct r0conf, struct r1conf, struct r10conf or struct mpconf. If we cast a pointer to one of these structs to struct r5conf, we will be reading invalid memory and KASAN warns about it. Fix this bug by reading struct r5conf only if raid type is 4, 5 or 6. Cc: stable@vger.kernel.org Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer Signed-off-by: Sasha Levin --- drivers/md/dm-raid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index e362a7471512..92e6b731f9d6 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -3514,7 +3514,7 @@ static void raid_status(struct dm_target *ti, status_type_t type, { struct raid_set *rs = ti->private; struct mddev *mddev = &rs->md; - struct r5conf *conf = mddev->private; + struct r5conf *conf = rs_is_raid456(rs) ? mddev->private : NULL; int i, max_nr_stripes = conf ? conf->max_nr_stripes : 0; unsigned long recovery; unsigned int raid_param_cnt = 1; /* at least 1 for chunksize */ -- 2.35.1