Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3086383rwb; Mon, 15 Aug 2022 17:47:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR6Iqp80eRV3yyc+uLT+pgCv8v0ImbrwzM9HwQ9+jh8PQU5LtVejtH9AgQelu9/kHWBcufjR X-Received: by 2002:a05:6402:35c1:b0:43d:fd2c:ae15 with SMTP id z1-20020a05640235c100b0043dfd2cae15mr17295822edc.63.1660610870695; Mon, 15 Aug 2022 17:47:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660610870; cv=none; d=google.com; s=arc-20160816; b=duTw269EWrFpPeT4aRx7WuQsBhEa6SxinwjVfe/3sWe2jgqZyaW0g/ht39YlAhPdBQ zPiozROle9eXeO8uYIykCaNS/GyVQ9QDKX4/v1nYQY/MKs1DHxcHMShrx7msCxR1LZ3I szpu4MuBXSdwmSuINy4Jl8Cj3HCENrTwRBMDm8spHW89g+ZP4lbIzkVEyVj2DP+BHm68 P6lPMp/KUZXFo8e2OAFbptj4C0BtrEKaSz+auBuLaZsfEq+foAFQEpER9K7FS06H+xYQ FbrnZFSLmNTWfECNibcvPCrURh+pRHDkHOLckNa3tXMh8X0uH6pSzXbjyuCYzyNijIb9 dbxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YUuMjdk3ksvYXzm7UP4XLZIdgLqcHYlP7V0QfKGH1z8=; b=ObfDRrBmknLCjYCAnc8CQsMiAc3VvEfZD1f4yfzdmQuN8GsbnFZ1WCIFJhv0Epb/u0 9mjCUCKwMMDJQoIvukqQMQWb7SwgW8HzSVHCX/Qrp9asjYJPzCmigevAoan/+Ym5AaBL X9HjSZ/HEP4rS52pDLHc16OpFO3hA6vqKcx+Za/55xXC18HLOLGhVaPUcZH2+kTHTg/H C4rItlK0CRSebbu+TQ2Rp+WLFclGtHypn5o75AVhdmKDWDrGTLGRVS80NzwerSz+VdvZ 3+c8RbFLOrW6n8U5jg0C6LChOOWyHqecLo3PJb9/jdgc3pVQ1+Q18fq6TMLml54rfaJH /ijg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=z3pzHovr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a056402354c00b0043bb8df080fsi8523642edd.606.2022.08.15.17.47.25; Mon, 15 Aug 2022 17:47:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=z3pzHovr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351907AbiHPAIc (ORCPT + 99 others); Mon, 15 Aug 2022 20:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354879AbiHPAAk (ORCPT ); Mon, 15 Aug 2022 20:00:40 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B196797530; Mon, 15 Aug 2022 13:21:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 689E8B80EB1; Mon, 15 Aug 2022 20:21:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B101DC433C1; Mon, 15 Aug 2022 20:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660594912; bh=NsVV9z4D0is7Au0wRGSembh84gMxq1mQKQCq5GKTZn0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z3pzHovrrE//+OFldNg1tAQkd4bG+Uq1zSttOBxAXn+/xE46dXUTB8V+E3AgFRQe/ nMmi8HmU7u1DryRmi5utBbTJfPkIKK2EGwtlEIQcfMfM+Yb/5vhAA/WQ70ghmb4o/G kYFGecLF4ZPK6paKeugjJligyW6tN6dXVoMWy+V4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Linus Walleij , Miquel Raynal , Sasha Levin Subject: [PATCH 5.19 0598/1157] mtd: partitions: Fix refcount leak in parse_redboot_of Date: Mon, 15 Aug 2022 19:59:14 +0200 Message-Id: <20220815180503.575139766@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 9f7e62815cf3cbbcb1b8cb21649fb4dfdb3aa016 ] of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 237960880960 ("mtd: partitions: redboot: seek fis-index-block in the right node") Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20220526110652.64849-1-linmq006@gmail.com Signed-off-by: Sasha Levin --- drivers/mtd/parsers/redboot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/parsers/redboot.c b/drivers/mtd/parsers/redboot.c index feb44a573d44..a16b42a88581 100644 --- a/drivers/mtd/parsers/redboot.c +++ b/drivers/mtd/parsers/redboot.c @@ -58,6 +58,7 @@ static void parse_redboot_of(struct mtd_info *master) return; ret = of_property_read_u32(npart, "fis-index-block", &dirblock); + of_node_put(npart); if (ret) return; -- 2.35.1