Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3087175rwb; Mon, 15 Aug 2022 17:49:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ECH08QIH0EXq2tVItz4o/GJO2aZOznmqUokPlm6bXE2iqVW9mRnHxRF5cq5fpJyKzBICU X-Received: by 2002:a17:907:969f:b0:730:b649:ff90 with SMTP id hd31-20020a170907969f00b00730b649ff90mr11979298ejc.337.1660610942794; Mon, 15 Aug 2022 17:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660610942; cv=none; d=google.com; s=arc-20160816; b=VcZkFmkQgFHQkSxGAnm8241+zyfsIGuqMJHf6nYqpDJl3wOQRMnpB5zHEF7BF5Wvjx hL3joPUyFzOuzp/9FhOezT2yf3aLj0KLKOQHt/E30ANdYNrdYSbt2ODNgeKYv9zQUWbk VQXJU5j3W9GUziAL39MMWibr0eJVSHzkYS5zpuOzmp932v1x5W1kGjVY0FnYiv30PMZw JKFWAgTOfiAnoUCTBsqM2xEcvsnb1TDx8sF1XKmaje8LVK9j962QQ/Lpw/U7rACS/AHl KngERidocmQ+dJ+cdqmiJUA0sH/p68KHF99OAqbShOd5DQQauoVusvnbdCGIdsK35U1G zCNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SXVCv8gXMsJD+EBRErMsBOBjVplsUT7enrb0K63+X7M=; b=VZNPN7DBS05f36l7jtH3As9Kj4OW9d46hdNW9IZsFYe7JNMGQNHs4SzxpYueHDR997 qHyc1q+V1G9hGR2jYkMpSgvLEV0hYn5Z5cqMA9bBQXdbyBafjmDBG+s3Yx7wgNgoVUyS hgZA0qf3Ry1LWaHo9M+KBRe/1BH+qvOaGQcLTSW5lKkZP1x7CTN8V8ChIVHnj0mi0Kf0 G/Mb4eAEIKZgmh7H95uZLbEYIScx0l1Oy4xtPSsAWvTmEWYmGgJvpjNejMShLrXVpcWG L91EPCasm9ErczoP1eRi9uRbu2jGxoDeKh/tzlAw4O1pUU/5W2LtP797iiCsVf7pEi7P /TPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZKGzdOFG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r2-20020a056402034200b0043e64d81518si8334371edw.619.2022.08.15.17.48.37; Mon, 15 Aug 2022 17:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZKGzdOFG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354488AbiHOXpq (ORCPT + 99 others); Mon, 15 Aug 2022 19:45:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354300AbiHOXlt (ORCPT ); Mon, 15 Aug 2022 19:41:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7BDD2A954; Mon, 15 Aug 2022 13:11:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6FEEBB80EAD; Mon, 15 Aug 2022 20:11:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A092C433C1; Mon, 15 Aug 2022 20:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660594309; bh=KcEV8SKvsjL468XkPQvCHNAT9nTCGEg25sQJaScv6vE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZKGzdOFGSrVb+3zARUOaLbGjxnSJfQoemiGxeBAdPzBhCO4NkDKkhugm65OlHk1SZ pRJCizB/kFqCpR5NF39xKfmbXHH+jCaYR7/lw4RrkgZ7F3ClAAkvW4ZEO4ujZcXP4B 30AR2C4pDT9vVdANoZUWkKs69FSqQwHxa/AooAXA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Stevenson , Maxime Ripard , Sasha Levin Subject: [PATCH 5.19 0412/1157] drm/vc4: dsi: Register dsi0 as the correct vc4 encoder type Date: Mon, 15 Aug 2022 19:56:08 +0200 Message-Id: <20220815180456.117894646@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Stevenson [ Upstream commit 4d9273c978d4c1af15d7874c10c732ec83d444d0 ] vc4_dsi was registering both dsi0 and dsi1 as VC4_ENCODER_TYPE_DSI1 which seemed to work OK for a single DSI display, but fails if there are two DSI displays connected. Update to register the correct type. Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") Signed-off-by: Dave Stevenson Link: https://lore.kernel.org/r/20220613144800.326124-15-maxime@cerno.tech Signed-off-by: Maxime Ripard Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_dsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 81a6c4e9576d..97a258c934af 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c +++ b/drivers/gpu/drm/vc4/vc4_dsi.c @@ -1518,7 +1518,8 @@ static int vc4_dsi_bind(struct device *dev, struct device *master, void *data) return -ENOMEM; INIT_LIST_HEAD(&dsi->bridge_chain); - vc4_dsi_encoder->base.type = VC4_ENCODER_TYPE_DSI1; + vc4_dsi_encoder->base.type = dsi->variant->port ? + VC4_ENCODER_TYPE_DSI1 : VC4_ENCODER_TYPE_DSI0; vc4_dsi_encoder->dsi = dsi; dsi->encoder = &vc4_dsi_encoder->base.base; -- 2.35.1