Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220719103954.6737-1-strochuk@ispras.ru> <fac8ce6e-6f5f-598d-35cc-7bf01ac90f30@amd.com>
 <f750ab62-7deb-21a1-753e-1ee838386265@amd.com>
In-Reply-To: <f750ab62-7deb-21a1-753e-1ee838386265@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 15 Aug 2022 16:21:58 -0400
Message-ID: <CADnq5_ORzjVFR9nxaJO6giVoGT8_BVtdq8PURjPrzOd7jpoH7g@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: remove useless condition in amdgpu_job_stop_all_jobs_on_sched()
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
        Andrey Strachuk <strochuk@ispras.ru>,
        Alex Deucher <alexander.deucher@amd.com>,
        dri-devel@lists.freedesktop.org, ldv-project@linuxtesting.org,
        Jack Zhang <Jack.Zhang1@amd.com>,
        Guchun Chen <guchun.chen@amd.com>,
        Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org,
        Surbhi Kakarya <surbhi.kakarya@amd.com>,
        Melissa Wen <mwen@igalia.com>, amd-gfx@lists.freedesktop.org,
        Daniel Vetter <daniel@ffwll.ch>,
        Hawking Zhang <Hawking.Zhang@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Applied.  Thanks!

On Fri, Aug 12, 2022 at 7:13 AM Christian K=C3=B6nig
<christian.koenig@amd.com> wrote:
>
> @Alex was that one already picked up?
>
> Am 25.07.22 um 18:40 schrieb Andrey Grodzovsky:
> > Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> >
> > Andrey
> >
> > On 2022-07-19 06:39, Andrey Strachuk wrote:
> >> Local variable 'rq' is initialized by an address
> >> of field of drm_sched_job, so it does not make
> >> sense to compare 'rq' with NULL.
> >>
> >> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >>
> >> Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
> >> Fixes: 7c6e68c777f1 ("drm/amdgpu: Avoid HW GPU reset for RAS.")
> >> ---
> >>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 4 ----
> >>   1 file changed, 4 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> >> index 67f66f2f1809..600401f2a98f 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> >> @@ -285,10 +285,6 @@ void amdgpu_job_stop_all_jobs_on_sched(struct
> >> drm_gpu_scheduler *sched)
> >>       /* Signal all jobs not yet scheduled */
> >>       for (i =3D DRM_SCHED_PRIORITY_COUNT - 1; i >=3D
> >> DRM_SCHED_PRIORITY_MIN; i--) {
> >>           struct drm_sched_rq *rq =3D &sched->sched_rq[i];
> >> -
> >> -        if (!rq)
> >> -            continue;
> >> -
> >>           spin_lock(&rq->lock);
> >>           list_for_each_entry(s_entity, &rq->entities, list) {
> >>               while ((s_job =3D
> >> to_drm_sched_job(spsc_queue_pop(&s_entity->job_queue)))) {
>