Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3252405rwb; Mon, 15 Aug 2022 22:21:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR7pVC8HOljbjHECCQRZZt28MoIxB+3NTm6MTsn3AH5sqngm4KallJZJtR2qGBb8gEHCnOhj X-Received: by 2002:aa7:9f1d:0:b0:52e:2401:e630 with SMTP id g29-20020aa79f1d000000b0052e2401e630mr19251846pfr.18.1660627314554; Mon, 15 Aug 2022 22:21:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660627314; cv=none; d=google.com; s=arc-20160816; b=tx00/JpmDMsZjZYaf1FpiWJpHOJ/sh2GLhNOEkmy8M2xOoGBnPc3jf9NfLOF84ujAG mwXu96ff8S2XcU2HLLcgtv4fqjdVRCXttH667mCsuBMtOpAog+Tp9nDDVXo/RRiS8e4J +GUEonECqwMWTuN06eLff15Nhoixd8swrzEvHBPNFzBJKueBWZ6moGAGpxkOJKnMFoFn SiUqogGVO9YQOPJaUrKdPL2rakxt3ze0xDhDhiD219F2zH5gCmCu/+5AvyimTm3Uy49e NQyfaw8oCBA7qq43bf9+ZzMbMHmuItBEiDCoZhKEt0KQDn0XS2h2M7pAHXIfQ1BO44Qo 2ZtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QZdV0ZKv0764bIby6b7QLti2laZ7IfDYjqmU4hSnLco=; b=NTW6f5adHTqRXTnoVB0Ctin/EEb4nFMpd/KeCf+bX4I6a+XbS0o3tnvfz1HIBaSSdj KiXKY83ja3lBWmsvIjskoTQmYT2mko5jFOum3QmwiMcRj6OSriuLtfzE+HNi6dOK1gwZ g5uzymR2lGDUr0g+/Jpcsl9e7Blt+eIa2l/99r8Sqd4mBsd2Ez5u723AbAbSrXHOAxng LR9+vwF6P1hKceJ4qXE1ie45cMmtqtB2Y6auBECRF8taQuvt7eWeaDn2XFJIFR7hkNgI KJkc5MhoOHS6vlsnyF0MoaHwKeW2ELYXWqDLmlM36G8AkMnD3Zbm0rlsUtltkDn1vK0k 3dOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aD5fBxo6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rj1-20020a17090b3e8100b001fa63199641si1057523pjb.181.2022.08.15.22.21.41; Mon, 15 Aug 2022 22:21:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aD5fBxo6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbiHPEgW (ORCPT + 99 others); Tue, 16 Aug 2022 00:36:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231147AbiHPEfZ (ORCPT ); Tue, 16 Aug 2022 00:35:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 916DF163ADE; Mon, 15 Aug 2022 13:26:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 17F01B81197; Mon, 15 Aug 2022 20:26:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51CD2C433D6; Mon, 15 Aug 2022 20:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660595170; bh=fy0P1Y/raRrozkyDmclCqU9rl0tFH47uvzW5g2BUwik=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aD5fBxo6bb6AzJz1BYu/ZuHgSQVvbmPX/lkAUW2bwMS1pyLAKd2hwtL948rSyAgBs E6gz+M2NJF81ByecGdATjiqW1rBUoY+rme7qUIVOyzkHgJzdVScPMBplhGJvsD4XBZ aY+FtKvzMiQ1hYULPSnMUgAwwXg4bp4zO/j1kSxA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , =?UTF-8?q?Nuno=20S=C3=A1?= , Sasha Levin Subject: [PATCH 5.19 0679/1157] iio: dac: ad5755: Fix alignment for DMA safety Date: Mon, 15 Aug 2022 20:00:35 +0200 Message-Id: <20220815180506.830901031@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Cameron [ Upstream commit d0c167ceff2d833ee493dd58164dc87bd36e48aa ] ____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition. Update the comment to include 'may'. Fixes: c499d029d805 ("iio:dac: Add ad5755 driver") Signed-off-by: Jonathan Cameron Acked-by: Nuno Sá Link: https://lore.kernel.org/r/20220508175712.647246-51-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/dac/ad5755.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c index 1a63b8456725..beadfa938d2d 100644 --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -189,14 +189,14 @@ struct ad5755_state { struct mutex lock; /* - * DMA (thus cache coherency maintenance) requires the + * DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. */ union { __be32 d32; u8 d8[4]; - } data[2] ____cacheline_aligned; + } data[2] __aligned(IIO_DMA_MINALIGN); }; enum ad5755_type { -- 2.35.1