Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3260565rwb; Mon, 15 Aug 2022 22:35:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR7WzZfWh6jxNiMmaQMYn+olFi9Q7JHvVcoeQ4WIePi2UyJ9WZ0uj4uXsAietoh5oHfX+TAP X-Received: by 2002:a17:907:3ea5:b0:730:8b95:dc69 with SMTP id hs37-20020a1709073ea500b007308b95dc69mr12453880ejc.34.1660628106181; Mon, 15 Aug 2022 22:35:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660628106; cv=none; d=google.com; s=arc-20160816; b=efqVebE520k248TwRgetWZmAbLvhPSwhdOfiY5Ot0bLtwERYVozXw9evL1kZVRhNXI p/y/PE8kR2YiglZ0BWnBtsdjU5AhKOcsRsChMnAAzlLdDPsDW1xxSGSZeEWe7zahunNM sp4ERiILoQCzNySmr60PzFOWlhahHTOQIb7pLAunoDYbCPfxb1r58kukraXxgIRKbLJt 6s+Lxfvczk3KWT8I4cdHQbVXNyrqX4UYliw4pK6FW6mQCPScYsMLFH/7QOtMU24OuDWi w7bOMDC/P6FeKYbvHtwNFeYb5HUEGRsuSnw6wsP/dUffvGEEt/xe1lJMqj2HezVQjRM7 LK6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OFnXRpzDu3kMkz1qfELLQjlCaIOBbrv3FRZdQXPrtcQ=; b=qGjpwAunTxBYwHd+M5rJF9OvqmO5J1s3Gvd19IstC8+zfM3RQcpwNfrveEQhQFkHcn xF4UR8IUZkN8So9t1QdOVx7gHf3eHQCAlVokBeQ0ly8sm8HYn4OGLsUAMckHcIPRL1Q8 0q4MHqFuoJOFM8yDq0Mnq3E1VCQDHgIcpn0CjAk9UBvF/sbSpqYkUI7NYDnPEG4Ue7LI P/DSEkPo2x6Mtvip0Nxcha2lgBUwsFR5lNZZuM32Tp4BM3n+f1HISonBmvCNP82YHdcj iqEQlKBXlVHxnHWB+SuYZKl5mrqF0KkBLOp8BCnlhEuppb9cocAwd16+8u2BXBGBnzOq p8YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xm8jB3pj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a05640227c700b0043be28d93adsi10349185ede.261.2022.08.15.22.34.41; Mon, 15 Aug 2022 22:35:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xm8jB3pj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232075AbiHPEm6 (ORCPT + 99 others); Tue, 16 Aug 2022 00:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231795AbiHPEk0 (ORCPT ); Tue, 16 Aug 2022 00:40:26 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57021A50D0; Mon, 15 Aug 2022 13:31:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A8D6CCE1345; Mon, 15 Aug 2022 20:31:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96331C433C1; Mon, 15 Aug 2022 20:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660595498; bh=ULVdn1u+eHqJzYIKptQEe/KzAAMdb1EsJ3McvUFHKhg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xm8jB3pjjGvX/q25U/ifYlzgQOEyxKGLYwtiYC1iFcz+Pa92CoH5jPMeVjRPtaVG6 q/Rl2VPd1uQ1K/e08SPwrqe5swlD0JYnddnLBzFDxCtgn/ZniWO8NBEZbIHhqZ8QV4 yTKQkY9S/KwvCYLhScWjzAzpHtpN38mMzzusKOcE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.19 0783/1157] scsi: qla2xxx: Check correct variable in qla24xx_async_gffid() Date: Mon, 15 Aug 2022 20:02:19 +0200 Message-Id: <20220815180510.811465162@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 7c33e477bd883f79cccec418980cb8f7f2d50347 ] There is a copy and paste bug here. It should check ".rsp" instead of ".req". The error message is copy and pasted as well so update that too. Link: https://lore.kernel.org/r/YrK1A/t3L6HKnswO@kili Fixes: 9c40c36e75ff ("scsi: qla2xxx: edif: Reduce Initiator-Initiator thrashing") Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_gs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c index 574251b2e0ef..c914b5df9c12 100644 --- a/drivers/scsi/qla2xxx/qla_gs.c +++ b/drivers/scsi/qla2xxx/qla_gs.c @@ -3386,9 +3386,9 @@ int qla24xx_async_gffid(scsi_qla_host_t *vha, fc_port_t *fcport, bool wait) sp->u.iocb_cmd.u.ctarg.rsp_allocated_size, &sp->u.iocb_cmd.u.ctarg.rsp_dma, GFP_KERNEL); - if (!sp->u.iocb_cmd.u.ctarg.req) { + if (!sp->u.iocb_cmd.u.ctarg.rsp) { ql_log(ql_log_warn, vha, 0xd041, - "%s: Failed to allocate ct_sns request.\n", + "%s: Failed to allocate ct_sns response.\n", __func__); goto done_free_sp; } -- 2.35.1