Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3261662rwb; Mon, 15 Aug 2022 22:36:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR6+KeAOoEHG80OCjXM78/HUIC0Itlr3ixCFC8eKSOsmHxibu6XOxpKc+fZxFrVhJrHejwwa X-Received: by 2002:a17:907:eaa:b0:730:c780:f71e with SMTP id ho42-20020a1709070eaa00b00730c780f71emr11802033ejc.770.1660628219196; Mon, 15 Aug 2022 22:36:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660628219; cv=none; d=google.com; s=arc-20160816; b=GJVX8My8X2J//zGTAErzyOD3zZ1g69j8KJODNFiFVcF1F8yx28/E60z7wUZdWhOXk8 xL4QwcKAUqrGe4R+MZTk06LQ+epAYS4seMp2I5emZarUbPcSf2kph/IIcQPHwnk0Qfwh jlaixYBoUsz9p0u6saP9Gw9QyNoTOwRJVjZK0O9GNziJerZZNyFNrQXdbGt2E9ywdyNq JPQy9fu++ikYxXb6RPD1twkcAK+4WAmV+hPxs8feXJX5msf4S2IWawDKlyImf1wTB4Za LIjlmjgb5L06s938ubruL8sAIdpykNiKKkpWLFQApZ2e8hEzqQMQc/1JDYI+Vh/3OkrF GDLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZTWkRYk7XC9EvZTZhAknYn+XW52/YqxOLh2FGt51B38=; b=XMGecAGpxP8ca8soZWJDeTn/HmK+cuxEZpff08W8NIOSEvPrVBGwHh2EoRTeCpsa+B 5/ZHJqsH1eDTiku6OG1/LqtzTpFrA2x3xrzVHzcySmnSl0ZKoXfrwS4xYZFO5CtCytJS xDcc2R9XSaIlewn5dgsjxk7GABXoYzsraqJTkf432mTOYzS9x+XAXHKI+M6qSvFGxXji 0Xhyi6GDlBIx6OoixyPO8uuW1qp2XM2LFyxcjwTgOv1fr/m4DuIXYv2ztfq23qLVjTn6 MG3d0brNeixB4OffB6EfrK+ogS+JpxjQocPjNhP/liyxK61ZFzPwKY5nbXQTVLBYIc9y Gy9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jroDEiiu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc23-20020a1709078a1700b0073045237fd2si9284640ejc.751.2022.08.15.22.36.33; Mon, 15 Aug 2022 22:36:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=jroDEiiu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231208AbiHPEhR (ORCPT + 99 others); Tue, 16 Aug 2022 00:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbiHPEgg (ORCPT ); Tue, 16 Aug 2022 00:36:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 104164D4D1; Mon, 15 Aug 2022 13:26:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A062560EE9; Mon, 15 Aug 2022 20:26:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 953FEC433D6; Mon, 15 Aug 2022 20:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660595198; bh=x7EQv7AD4LMoZ4EMaiSnO2H0ly6bAUK3LBIgSix3a/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jroDEiiu8nzSsMXc56M0wfiiW3T7jcEjcfb5aINhiz1NDyN8D3/CRFeDkeBwEZXVu jCXu5tuzzM0urFx2ikQz/SMrqY0el/MNP7CG2Fuhq1nHDFp23nRW/3Uy5ScYbFPPp6 e6Li/060ARG/4zLa5+B7WMxR+W2qlqoH6Iyv3P+A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan Cameron , Michael Welling , =?UTF-8?q?Nuno=20S=C3=A1?= , Sasha Levin Subject: [PATCH 5.19 0656/1157] iio: adc: mcp320x: Fix alignment for DMA safety Date: Mon, 15 Aug 2022 20:00:12 +0200 Message-Id: <20220815180505.977146149@linuxfoundation.org> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220815180439.416659447@linuxfoundation.org> References: <20220815180439.416659447@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan Cameron [ Upstream commit e770f78036ce4327caf285873f4b20564a8b4f0f ] ____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_DMA_MINALIGN definition. Worth noting the fixes tag refers to the same issue being observed on a platform that probably had only 64 byte cachelines. Fixes: 0e81bc99a082 ("iio: mcp320x: Fix occasional incorrect readings") Signed-off-by: Jonathan Cameron Cc: Michael Welling Acked-by: Nuno Sá Link: https://lore.kernel.org/r/20220508175712.647246-28-jic23@kernel.org Signed-off-by: Sasha Levin --- drivers/iio/adc/mcp320x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c index b4c69acb33e3..f3b81798b3c9 100644 --- a/drivers/iio/adc/mcp320x.c +++ b/drivers/iio/adc/mcp320x.c @@ -92,7 +92,7 @@ struct mcp320x { struct mutex lock; const struct mcp320x_chip_info *chip_info; - u8 tx_buf ____cacheline_aligned; + u8 tx_buf __aligned(IIO_DMA_MINALIGN); u8 rx_buf[4]; }; -- 2.35.1