Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <a9daea363991c023d0364be22a762405b6c6f5c4.1660281458.git-series.apopple@nvidia.com>
 <YvqsoL7fKJzEqTA3@xz-m1.local>
User-agent: mu4e 1.6.9; emacs 27.1
From:   Alistair Popple <apopple@nvidia.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>, linuxram@us.ibm.com,
        paulus@ozlabs.org
Subject: Re: [PATCH 1/2] mm/migrate_device.c: Copy pte dirty bit to page
Date:   Tue, 16 Aug 2022 10:51:57 +1000
In-reply-to: <YvqsoL7fKJzEqTA3@xz-m1.local>
Message-ID: <87zgg5uhy7.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sxqkMsr6ZQelvVMMbkFTB9DQ2+vY2BalfyUTaMHL0bX+RjWjxj2Lnoqwd835?=
 =?us-ascii?Q?9ni6jAQe+6xmzmALVB9KAEcgrL2QTO5ZceYIGwR9IAfhRn+V46+nHcJ3oBJ4?=
 =?us-ascii?Q?5k6jpUQ5qTyaRym0XK5S9Y3V5u+hp+EZGx1u+pDdF5kM9EktBp6AqOeMgL59?=
 =?us-ascii?Q?IFz0cw+M6iyjJUquPe9HRoWpVI4Nog2DFMZajIz97oHRPfyot1QbtA6psNPM?=
 =?us-ascii?Q?E/8jeRhH+1VtS+53/bGWRmuZNZwqAc7SUyKvn6aKLJJ+aalh1HstnNQWID9V?=
 =?us-ascii?Q?s6znbirl0Rdt8pjgLnleAqO8mEENhb4ppYzzHOpDIVKA16cborMIIDiZuifR?=
 =?us-ascii?Q?J7liTiP7788e8rUu4fODFN39XGEDOsVT62LdwXpWbDjDvckBP6caPqZjHWXk?=
 =?us-ascii?Q?DywgK/QG1A676IHwvpEfKTCT1mOPEHdZYx3RRqD0X0IgdIS9fsTPrOAoXz/N?=
 =?us-ascii?Q?dOv2ZKMD2rSyhit13fI/9V5Av0Ss9Iya7i3fAhGrYUYrsnUS/5abY9nhgdMH?=
 =?us-ascii?Q?3Vnue67lkFgb0S8fF/j013AosrzdTpgiWJUcZ/+T8A1v6XGwGy7xv2Qetkqa?=
 =?us-ascii?Q?JEW8Uy83DAiQbjT+dLKgQ623TRrcKA/9+N/JdtjQSfB7K9N/LqbYhTGp5blc?=
 =?us-ascii?Q?Uo1rHsBbnfcCWN5Y7OLbC9kFLGnf8kzOPq16vuWGo+XkBzQXft/zL09MUvcY?=
 =?us-ascii?Q?y63znSgeOfkJF8w6FVZxKT78pHaehRTR8ub5Xme/AUPnhtIgmp/PdkgsqvEz?=
 =?us-ascii?Q?VvueqYyw0WnBlY1+A+3USF/e9UxQr72UpfhRzYtrkEDsEHl533W5pZsWy4OT?=
 =?us-ascii?Q?+dZB9kaPUAenKUl1ES3n/wZ0r9513xq8CPSCnu4h3RG96pF9C05MZsGU39UF?=
 =?us-ascii?Q?5PRBc29Rpn31AY06iP5r6apa3HdKq8FisMoaiihBNnq7CM7TL6rBRVY2Q7EA?=
 =?us-ascii?Q?t9jxnnZwgR6wixJohTiNnGeScq/1/AFi8Oz97dBFkDvw6wjqd6v+CD/ujNv5?=
 =?us-ascii?Q?KlFvDv999mq1Z9tLjy2pFhCky5vcwXKsRp1/bX2T0UPZJcMLoHGzeOl+Qr6t?=
 =?us-ascii?Q?V6Ak6N3nfNddVLdyfRParlCdSiyu0hyAkTJD/UivEDb0ShGL057sfa79SPOJ?=
 =?us-ascii?Q?xrgZLtxAaRugYYVeCLrWgoCvWu5Y0Uw9c7ppDgd3reLhDl1ZeEHgLcl0IA43?=
 =?us-ascii?Q?3pNcXoRpAHvtTQLNfhC0YVNiDd2vqf7ZzSldIEw72QK+VFr8lohdLGbm/Nh5?=
 =?us-ascii?Q?/LVYHYoVW3Nfxhpas0wQoBXYteYfKgi9uLh0Oqa6gUIRKXc9ecTyhmSpFWh8?=
 =?us-ascii?Q?TFIPnPEfRcqrTWP3fsI8MrOh+1BUogobfthZWoiySw5BXCD6vz1HrJno99ul?=
 =?us-ascii?Q?Fgu3sf7/C9FG95CeIccxqRcsOy03fnZX2v0BJq/HbtafP007jDJdORlZ+PaO?=
 =?us-ascii?Q?u+799DaC78TX7kyGwZl/r8gKUa4HtUUZ4XwrAMxd/iZWxSmAdgQx7p1z/SAZ?=
 =?us-ascii?Q?poi/FDmobEV8mMMmkaFfh3aEr2mKQDUDP05YHf6qzEnfZgpu/vD/AI2N0ch4?=
 =?us-ascii?Q?KR27DuVf0MEPiesUrYTv5GD5gq4+uqF0aP+r/Vrw?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b28c564-d6b5-4a02-771b-08da7f21cb8b
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 00:53:55.3472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ygr1KD5F79MJhn+N2G7CZZh0Z7gVjAg7OppJ+oFA9sW3HHJGtwAVD+cd/0jVvYAtSmKzTPAUNbMKmhO/UhIwSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6349
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Peter Xu <peterx@redhat.com> writes:

> Hi, Alistair,
>
> On Fri, Aug 12, 2022 at 03:22:30PM +1000, Alistair Popple wrote:
>> migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that
>> installs migration entries directly if it can lock the migrating page.
>> When removing a dirty pte the dirty bit is supposed to be carried over
>> to the underlying page to prevent it being lost.
>>
>> Currently migrate_vma_*() can only be used for private anonymous
>> mappings. That means loss of the dirty bit usually doesn't result in
>> data loss because these pages are typically not file-backed. However
>> pages may be backed by swap storage which can result in data loss if an
>> attempt is made to migrate a dirty page that doesn't yet have the
>> PageDirty flag set.
>>
>> In this case migration will fail due to unexpected references but the
>> dirty pte bit will be lost. If the page is subsequently reclaimed data
>> won't be written back to swap storage as it is considered uptodate,
>> resulting in data loss if the page is subsequently accessed.
>>
>> Prevent this by copying the dirty bit to the page when removing the pte
>> to match what try_to_migrate_one() does.
>>
>> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>> Reported-by: Peter Xu <peterx@redhat.com>
>
> This line should be:
>
> Reported-by: Huang Ying <ying.huang@intel.com>
>
> Please also feel free to add:
>
> Acked-by: Peter Xu <peterx@redhat.com>

Thanks Peter, my bad. I assume Andrew can fix up the tags if I don't
need to re-spin this series.

> Thanks,