Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b5444ddd-78b3-b420-d902-1411ed016793@intel.com>
Date:   Tue, 16 Aug 2022 09:46:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.12.0
Subject: Re: [PATCH 7/8] memblock tests: add tests for memblock_*bottom_up
 functions
Content-Language: en-US
To:     Rebecca Mckeever <remckee0@gmail.com>,
        Mike Rapoport <rppt@kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
CC:     David Hildenbrand <david@redhat.com>
References: <cover.1660454730.git.remckee0@gmail.com>
 <69524966ac92d93b45a8a8e739434d5fb31e3084.1660454730.git.remckee0@gmail.com>
From:   "Huang, Shaoqin" <shaoqin.huang@intel.com>
In-Reply-To: <69524966ac92d93b45a8a8e739434d5fb31e3084.1660454730.git.remckee0@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0pZeGkxOGdtWHZUSnhXR3dBTE8zaTRkQ2hLMTh0akw4WkRVa3lidFdxR28z?=
 =?utf-8?B?VU5WbnJUODFra0lzQUlIeGozQzF6RVJkRS9HOGNxV1g0MHB0VXVGekJYb3lN?=
 =?utf-8?B?SWVtM3R5VHB4VUpBbm1McEtTWHcrUTYrZTdXQUdVQVhNaHhpZEgxTzZ1YUdz?=
 =?utf-8?B?ZHFqZEpSRUcwN2RVSGZ6TDl3VFRWMmErSWIzSWtCdGdGMm9LUThpZWErdVZZ?=
 =?utf-8?B?Q1pwakdSVlZIMkg4d3JUTE1XdTc5NU1IRUdteEpURjdJR1oremh3WEh6enVC?=
 =?utf-8?B?cXgxYUI3b2pBUkQ4c1IwKzBUU3k4blg1dmRnZ3hYZ2dDV2FsOFVQb2FKSUZ1?=
 =?utf-8?B?SEJVM1Fhc09mMEJGZThuMERhdDZWZTlNN1RZQzJXbVVMdDRhQ2diazBWZXpX?=
 =?utf-8?B?YWtCTHFNdmRQa3ExQ0ZTc1lZMW5JVEVrdi81TmhsRjJLUnpxWUFQUjlTVlpK?=
 =?utf-8?B?NGYwbEtxR04wR3FrS0traU0xVExLWkViaUdSNDJFRHBqQlh2Nlo3NHFsOXhI?=
 =?utf-8?B?b1lsS2dDZTQrR2l1bXpxeFBwZEU1UXpUNHc3SE9BdVNIaVRpdWp1eXZJbXds?=
 =?utf-8?B?MGxPVG4zYy9UUHQwWlpLNWQyUXowd2d1M3Q1MkdtT3oxbEFmZnc3b0pFNnZt?=
 =?utf-8?B?NDNXdzJtL1E1UCtRRmp0aWs3TnJyTFB3RTFaSXNXbGp2VHdQZEYyMHYxZTRB?=
 =?utf-8?B?Y2p1QTdCMVNNdjRxbTdjMVgwNG13U2JvWXJodVgzV0xuR3haTTJjOUg4L3k0?=
 =?utf-8?B?RXFDOVRQR0IvN29TM3hMZnVsQUplbHJxZUlnYkRCYXREUUxNd3J0aExKL3Iv?=
 =?utf-8?B?ZThuajRRTWZiUDNOcE9WSEpONnV1M3gyQUV0clRCV1BVTHEyL0JxczlnWUxk?=
 =?utf-8?B?dVo4TmdWcGtlTUtGSFJZUXFoQ0tyR2hJdm5VeGg0cE1QNGhJN3NOK0tBaVlG?=
 =?utf-8?B?azhjQ0w4OEFIUW9VQXBmWUpxZzdIVnJmRnZJcUM2MHhEM0kyVUZlUzRCUGdh?=
 =?utf-8?B?WFRSSXE4WnNLcE1FNDlUZW1DTkRzVGtqK1ZRYTluQUhjVjRhNHFHZ3hCeDRQ?=
 =?utf-8?B?N3lPejczTnNGNjI4cTdpbVdRNGZoNzZDSlJOT3JSdndRdEd2NGZJRUdCZ3Jh?=
 =?utf-8?B?SjBUK2s1bWpKNTJhOUk4R0JqUFNNYlh1YU92NkZmYm12RTQ3SlFHTnREek1K?=
 =?utf-8?B?dW1kU2crRm1ROFI1a2c1d1daa0Y5TEYrL1AzZXpuZkl5Mi9CNVZLRXNPamt6?=
 =?utf-8?B?alo3d29pdHd5cFVzbUZYbFU5b2dXbXI1QmRYK2daanhUTTgvQ2RPeFU2emtZ?=
 =?utf-8?B?S05WMndES0lGaC8wN2VsTXBrTFdnZDZMNHRhanBGUGtqbUxQajB3ZCs5S0d4?=
 =?utf-8?B?T2FybEg4QSt6TUxLcWJLSUdzMC9mbllBNll5OG03dVJNMGhubHppSUlFSGYx?=
 =?utf-8?B?aVZuVGhnSnRXaDViV09VNUhSelZXY09Id0JPRUFaa0F5bU5vbUpZS2QxUWNH?=
 =?utf-8?B?MUhSSm81cEZqd0JjRVcvNi9aSGJaMDFtamtVbHlvdVZjaU5MQjh0eXcwNW5K?=
 =?utf-8?B?NDAvNXRNcVorM1BtY1RDRzdhUWJzaHgvKzd5MU9mZGo3RDlUcUgrUzJOTXhp?=
 =?utf-8?B?dXFUbk93TjlXNTNubXVvUjR4WVpkTjRQbkg4VzFjNE5nbHVJZDNJd1o3TVVl?=
 =?utf-8?B?TFMzRWhkVkFNREl6SEVxYk1LTzlZMDVYNVVhSWZBU3Q2bjBtNTkycjQzTlhC?=
 =?utf-8?B?TC9OK3Y1NzgwTzUwQzFwVHBQZlJtVTZsK011SUFGTE1GOGtkVi9xdWpGN0hx?=
 =?utf-8?B?dHlTSEc5Zy9YY1huSTcwRlJkTzNkd0ZCY2YxVkNZenVOc3hGcGRlZTJhUHJU?=
 =?utf-8?B?Ny9aQXdmUWhMNVVnZ2dmMUFZVGNQVXA5aXludUtGdGFRaFdqRXpDbHl1aDFj?=
 =?utf-8?B?bm5aRVhka3E0cEJ0V2hlaE9uS051N3hYd0QxN0FGTlpEcmxMQzkyNjdRdlJl?=
 =?utf-8?B?Z1g3RnFZWG55Ni9sUVpWdE5ac3VZYmdzbEwvdEZoZms1eUFyQ3VrWngxRmJy?=
 =?utf-8?B?dE03elhQaG9Da1Bza2YzSHpUWWtORkhNWk05cUFJZVhmVE90S0s5a01HWVpp?=
 =?utf-8?B?MXNVR1A2TWtwNURPZ1pZQ094OThGRUJwNVlHUzNtTWJ2dHh6WjFvbXdZSjBj?=
 =?utf-8?B?NHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0f72ba6-0501-45b7-2e4d-08da7f293970
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3870.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 01:47:06.3979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SN0fIa3y5Pl3QXuELyNrr36fggtQjrlOZIEekgIrYDyvOc/yLHAQ3oOy2SPlSFOu2yrezwhBrxh6ImM1HbQGgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3800
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Shaoqin Huang <shaoqin.huang@intel.com>

On 8/14/2022 1:53 PM, Rebecca Mckeever wrote:
> Add simple tests for memblock_set_bottom_up() and memblock_bottom_up().
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
> ---
>   tools/testing/memblock/tests/basic_api.c | 45 ++++++++++++++++++++++++
>   1 file changed, 45 insertions(+)
> 
> diff --git a/tools/testing/memblock/tests/basic_api.c b/tools/testing/memblock/tests/basic_api.c
> index ef5642d0863b..d7f008e7a12a 100644
> --- a/tools/testing/memblock/tests/basic_api.c
> +++ b/tools/testing/memblock/tests/basic_api.c
> @@ -1679,6 +1679,50 @@ static int memblock_free_checks(void)
>   	return 0;
>   }
>   
> +static int memblock_set_bottom_up_check(void)
> +{
> +	prefix_push("memblock_set_bottom_up");
> +
> +	memblock_set_bottom_up(false);
> +	ASSERT_EQ(memblock.bottom_up, false);
> +	memblock_set_bottom_up(true);
> +	ASSERT_EQ(memblock.bottom_up, true);
> +
> +	reset_memblock_attributes();
> +	test_pass_pop();
> +
> +	return 0;
> +}
> +
> +static int memblock_bottom_up_check(void)
> +{
> +	prefix_push("memblock_bottom_up");
> +
> +	memblock_set_bottom_up(false);
> +	ASSERT_EQ(memblock_bottom_up(), memblock.bottom_up);
> +	ASSERT_EQ(memblock_bottom_up(), false);
> +	memblock_set_bottom_up(true);
> +	ASSERT_EQ(memblock_bottom_up(), memblock.bottom_up);
> +	ASSERT_EQ(memblock_bottom_up(), true);
> +
> +	reset_memblock_attributes();
> +	test_pass_pop();
> +
> +	return 0;
> +}
> +
> +static int memblock_bottom_up_checks(void)
> +{
> +	test_print("Running memblock_*bottom_up tests...\n");
> +
> +	prefix_reset();
> +	memblock_set_bottom_up_check();
> +	prefix_reset();
> +	memblock_bottom_up_check();
> +
> +	return 0;
> +}
> +
>   int memblock_basic_checks(void)
>   {
>   	memblock_initialization_check();
> @@ -1686,6 +1730,7 @@ int memblock_basic_checks(void)
>   	memblock_reserve_checks();
>   	memblock_remove_checks();
>   	memblock_free_checks();
> +	memblock_bottom_up_checks();
>   
>   	return 0;
>   }