Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <a9daea363991c023d0364be22a762405b6c6f5c4.1660281458.git-series.apopple@nvidia.com>
 <CAC=cRTON4s6LJ+09mg4SxMjNirBih3QSt6cr10gNjs3k0o+BgQ@mail.gmail.com>
User-agent: mu4e 1.6.9; emacs 27.1
From:   Alistair Popple <apopple@nvidia.com>
To:     huang ying <huang.ying.caritas@gmail.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>, linuxram@us.ibm.com,
        paulus@ozlabs.org, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH 1/2] mm/migrate_device.c: Copy pte dirty bit to page
Date:   Tue, 16 Aug 2022 12:28:56 +1000
In-reply-to: <CAC=cRTON4s6LJ+09mg4SxMjNirBih3QSt6cr10gNjs3k0o+BgQ@mail.gmail.com>
Message-ID: <87r11gvrx6.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P9/Stfl4McLaI6HGh4hQsMUNioPpJueDccGgJ83EN/+rchJbhn6yjJWeZ+WY?=
 =?us-ascii?Q?k603vB/EJsfuNAXj1URtsvfrXY1s1MWhfMW7JmYpPTCqGqixZktuHs+2VlWl?=
 =?us-ascii?Q?qbExyAoDB0Ss9zFy9MA26OcleTYcPYNh8QVNsPj/3ZNu0qOaKLE8S+g3Zlto?=
 =?us-ascii?Q?A29L2r+tQlnnjubb0uyNLdFVV4rlf9b0hK97k/bRys+ed7525/gbsPIlN8e2?=
 =?us-ascii?Q?nBqyqe8KOUG35JU8TFxh9JY+q+Hz4CGnxcA/3E0qyQNVNjb+tXxRR0kart75?=
 =?us-ascii?Q?WDvPsCFmDQMbSIMw2lpWsNiVdJNxrtVN1K4cEj9lrQpi/BHFrjGoGbMoMFWC?=
 =?us-ascii?Q?zXgWSZgpvHglgM4zKG93YpeRNYrRbICM7bdlG4Bovx1i923+ddZ/mqCQ/jcC?=
 =?us-ascii?Q?DQWRzV9paBvuGOEaTVZNgC7vyrpLLF/I9pu8NbgyGes+ZivDMWoBHV4c09ct?=
 =?us-ascii?Q?ddV6RkT3nvxvYVJqcqri1yg8e/aKh52V4965yLIli92lCI+zBxQDhCIGwM4/?=
 =?us-ascii?Q?jS/KNMLlLwfMMeF83M/y7uvhPPW3AjLtwjcdo1cRqNfw4q1AUudLAreBVLjE?=
 =?us-ascii?Q?CoIfVFXc0hPhD0elPYbgLpg8yknVdDr8vC4I1JNWZHP/EQ2oTnRibpojLb4v?=
 =?us-ascii?Q?ad02tyI7h3LgicG52wlOTuaJ+Nuh73pIFleVoQFR/+eBnLGL0GeSDMI82oGk?=
 =?us-ascii?Q?HYLyzuVca48CYVPnWbPWVn57++Mam5+rOIVo4XYmjA8DEzAhJzK9l9y0Q96H?=
 =?us-ascii?Q?a9iWX7+GOKT3T9BTpI4Njxf0uJGbwxHo2iAv7H7RjM/J5shw5oTjV8m5SF1n?=
 =?us-ascii?Q?Al7gI47IUkUAUVXPHXGc8NBj/PAg2CFcZUo2CqPfEvK/KwV/8XkJvgPloGdk?=
 =?us-ascii?Q?7iO09roKQcmEgNg1hwoJ3wdLpiYGtqYxujYf+QMB3awWQJnxqNQrfthFHyio?=
 =?us-ascii?Q?TotwsL+DopX/bDiMCrLv9nc6jT1K+TtndZnGOu8PzMouwePqS0SyxQGfbgkW?=
 =?us-ascii?Q?IGnRK+iARS73nQgkJylOgE4GcMHFxauhVedIR/1E/XHpp+U40mKGtpcOiwMR?=
 =?us-ascii?Q?owfx70LkZ/VrV5bfJyb5oB5Hn94U9E4kkOH9U1YFmWnbxirj8KU6coTSf6Jl?=
 =?us-ascii?Q?/HdInQqDIeWUseJbLxDB6Ne6lS7QZ7abUUIGiMJpaEUtuP49GwGWd/k2GoBb?=
 =?us-ascii?Q?uXSPotws9gwyG/wk0JJielDR2IjRbk8fWTlRf4SqmlZxM7VUxDPyFYHEdPEN?=
 =?us-ascii?Q?bTzbKW4RxZAjB+YunrYAoV5EZ7ZGHGYie1xW/yH4xmMY7Un+ypTmOY39WNp/?=
 =?us-ascii?Q?1c3ZRTI7GWyWKp9dVz7ns/fVPVHGLGrcwzNXoZv97H9imdAa0T8JioKNYVtJ?=
 =?us-ascii?Q?Z6J2p7YTbOm3aXkHoKRW3D6X1kWcVnXWRJlC2Nm21HEvky940Mv9B7DOIbbB?=
 =?us-ascii?Q?prhXxjMsLznWAfTpBFDTPkyzd7QHjCx1Oc0JRGLWCL+4tSsx8O6pauggjOLn?=
 =?us-ascii?Q?4kkyS5Y6Xh6hebZ3WJrWuSVB4YYEcbKg5znwzGGBRw/+3dXqxF6DwyFKtWCF?=
 =?us-ascii?Q?fjA7+CMycG/XXVku4ZyZK7r7CiMglPvmM4Yvcr2h?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91c81508-ed97-44db-1aeb-08da7f2faa63
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 02:33:12.6408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1O42AvrEHfjJs/arK1lPqGjtFnLQKBnwArAyK35NTQ76ORdbScZTqRDlIdspYeUhZj+GFVIm/UHJweIzF0/Mpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1330
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


huang ying <huang.ying.caritas@gmail.com> writes:

> Hi, Alistair,
>
> On Fri, Aug 12, 2022 at 1:23 PM Alistair Popple <apopple@nvidia.com> wrote:
>>
>> migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that
>> installs migration entries directly if it can lock the migrating page.
>> When removing a dirty pte the dirty bit is supposed to be carried over
>> to the underlying page to prevent it being lost.
>>
>> Currently migrate_vma_*() can only be used for private anonymous
>> mappings. That means loss of the dirty bit usually doesn't result in
>> data loss because these pages are typically not file-backed. However
>> pages may be backed by swap storage which can result in data loss if an
>> attempt is made to migrate a dirty page that doesn't yet have the
>> PageDirty flag set.
>>
>> In this case migration will fail due to unexpected references but the
>> dirty pte bit will be lost. If the page is subsequently reclaimed data
>> won't be written back to swap storage as it is considered uptodate,
>> resulting in data loss if the page is subsequently accessed.
>>
>> Prevent this by copying the dirty bit to the page when removing the pte
>> to match what try_to_migrate_one() does.
>>
>> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>> Reported-by: Peter Xu <peterx@redhat.com>
>> ---
>>  mm/migrate_device.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/mm/migrate_device.c b/mm/migrate_device.c
>> index 27fb37d..d38f8a6 100644
>> --- a/mm/migrate_device.c
>> +++ b/mm/migrate_device.c
>> @@ -7,6 +7,7 @@
>>  #include <linux/export.h>
>>  #include <linux/memremap.h>
>>  #include <linux/migrate.h>
>> +#include <linux/mm.h>
>>  #include <linux/mm_inline.h>
>>  #include <linux/mmu_notifier.h>
>>  #include <linux/oom.h>
>> @@ -211,6 +212,10 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
>>
>>                         migrate->cpages++;
>>
>> +                       /* Set the dirty flag on the folio now the pte is gone. */
>> +                       if (pte_dirty(pte))
>> +                               folio_mark_dirty(page_folio(page));
>> +
>
> I think that this isn't sufficient to fix all issues.  Firstly, "pte"
> is assigned at the begin of the loop, before the PTE is cleared via
> ptep_clear_flush() or ptep_get_and_clear().  That is, the pte isn't
> changed atomically.  Between "pte" assignment and PTE clear, the PTE
> may become dirty.  That is, we need to update pte when we clear the
> PTE.

Oh good catch, thanks. Will fix.

> And I don't know why we use ptep_get_and_clear() to clear PTE if
> (!anon_exclusive).  Why don't we need to flush the TLB?

We do the TLB flush at the end if anything was modified:

	/* Only flush the TLB if we actually modified any entries */
	if (unmapped)
		flush_tlb_range(walk->vma, start, end);

Obviously I don't think that will work correctly now given we have to
read the dirty bits and clear the PTE atomically. I assume it was
originally written this way for some sort of performance reason.

 - Alistair

> Best Regards,
> Huang, Ying
>
>>                         /* Setup special migration page table entry */
>>                         if (mpfn & MIGRATE_PFN_WRITE)
>>                                 entry = make_writable_migration_entry(
>>
>> base-commit: ffcf9c5700e49c0aee42dcba9a12ba21338e8136
>> --
>> git-series 0.9.1
>>