Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <18b4f424-c21a-5da7-5049-b643965cd885@amd.com>
Date:   Tue, 16 Aug 2022 09:58:37 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v7 00/14] KVM: mm: fd-based approach for supporting KVM
 guest private memory
Content-Language: en-US
To:     Chao Peng <chao.p.peng@linux.intel.com>
Cc:     "Gupta, Pankaj" <pankaj.gupta@amd.com>,
        Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
        Hugh Dickins <hughd@google.com>,
        Jeff Layton <jlayton@kernel.org>,
        "J . Bruce Fields" <bfields@fieldses.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>, Mike Rapoport <rppt@kernel.org>,
        Steven Price <steven.price@arm.com>,
        "Maciej S . Szmigiero" <mail@maciej.szmigiero.name>,
        Vlastimil Babka <vbabka@suse.cz>,
        Vishal Annapurve <vannapurve@google.com>,
        Yu Zhang <yu.c.zhang@linux.intel.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com,
        ak@linux.intel.com, david@redhat.com, aarcange@redhat.com,
        ddutile@redhat.com, dhildenb@redhat.com,
        Quentin Perret <qperret@google.com>,
        Michael Roth <michael.roth@amd.com>, mhocko@suse.com,
        Muchun Song <songmuchun@bytedance.com>, bharata@amd.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        linux-api@vger.kernel.org, linux-doc@vger.kernel.org,
        qemu-devel@nongnu.org, linux-fsdevel@vger.kernel.org
References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com>
 <b21f41e5-0322-bbfb-b9c2-db102488592d@amd.com>
 <9e86daea-5619-a216-fe02-0562cf14c501@amd.com>
 <9dc91ce8-4cb6-37e6-4c25-27a72dc11dd0@amd.com>
 <422b9f97-fdf5-54bf-6c56-3c45eff5e174@amd.com>
 <1407c70c-0c0b-6955-10bb-d44c5928f2d9@amd.com>
 <1136925c-2e37-6af4-acac-be8bed9f6ed5@amd.com>
 <1b02db9d-f2f1-94dd-6f37-59481525abff@amd.com>
 <20220815130411.GA1073443@chaop.bj.intel.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <20220815130411.GA1073443@chaop.bj.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0VjY3FEMUdFT2dJdTA3TjQ3RlYwUkhUdUYrb0R4QzViVGZQTVFHVFFES0JL?=
 =?utf-8?B?R2V3ZW5TREVGR1dzcTd5cFVPWVJ6VTJ1T3dPUG1QbUkxRE1rTEQxYkxoWEx4?=
 =?utf-8?B?MDlRVUtWOW4yc0J5aUcxS3BKNmlUZ1F2SFhFbVpFalUxTnFWZGJhRWRFVkpL?=
 =?utf-8?B?K2NvcVBZWHZsdWVONnd3UmtUY2Q3MjFrMHJwVHg1cEsvTUsrcFJqdGdrWkpD?=
 =?utf-8?B?K0lDY0ZQZUtFekh1UFBtRUNCbVJQY1YrYjRqQXNTZjZTMDVqMkZUY0ZmU0RV?=
 =?utf-8?B?YlpZTW5BY1BBaDJpeGgzaGJqOHVibS9QcGZYZW51clJML25VM0UyTis0QlVF?=
 =?utf-8?B?R1QzRjErYjYzQlRBRWMxMzFidU10MWNPOHlJNkwxOEJpMEZkQmFnNi9BaTNL?=
 =?utf-8?B?SnFyZWtMNDVXQ0UrR2RwVzJOSEJBMzNEVTdpeVpuMTBqVjhnbUI0bFl2M3Ix?=
 =?utf-8?B?RTJJdUdqQ1l1RmhDaHpLSnVzcE9EdllkWDRRQnNuTXdtaXJadm5tYi9iTnh1?=
 =?utf-8?B?c0p6M01Vd2M4eDRrRlJNUGdjU093bklidllCd1ZEeTZCU0dqQ215eTh1akg5?=
 =?utf-8?B?RHYzM1E2R29hOXZrS2Z0NmNMcWFtTDFuWFNwOTdZNmtZTjNqYzJORElVYkFJ?=
 =?utf-8?B?Q0IwVEZrRGFuT2RHVVlDMmJ4V0ZpQkVIbVppMWxybU9kTWlFWnE5OWlhMC8w?=
 =?utf-8?B?TWJ0Mm9GOUp3OFMzZEFVT2gxNUFYUnFEa0NUcnp2eUkwNEtYSzJpc016bWtX?=
 =?utf-8?B?LzBYVVNmRmV4YTF5Zy9zeXhqRm9yblFzZlJ6Z0g5SHl4L25FajZhVUVHbXJi?=
 =?utf-8?B?MW1keDVneVhTS3FRdmZRaXExcnVRYURRZGlmOFlwaWNkdjh2eU5FZUFEWUpO?=
 =?utf-8?B?U2ovSFptUFljeXR5VHFGZTRVcUtOT2p0MUg4d3JOUlpBalU2dEduQ0UxYnIx?=
 =?utf-8?B?NDMrLzJIZ3JOUDJYWlFZU3JrQTd6c2FxV1JVd1hsMkFoSzlBMXJJQmp0N2xL?=
 =?utf-8?B?a1pYWStZak1kQTY3dElCdzYzcCs2NzE0cmJrQUI5OEc3SFFSVUM0bUMxUUZz?=
 =?utf-8?B?cmYxcHV5VUtrWis4Z2lhTTV1SW54OFFkT29uSFNmOUVuWFI3TTZtSnBvREJ3?=
 =?utf-8?B?T01OZlg3MTZUejRhakU3cmJZMTU1SVBCMXFvbnlic0F2T3VUY3VRNXoxYU5X?=
 =?utf-8?B?Z2JzNUFra0RwMmIybXpqWldTKzB5Snk5MzVPWUVuS1hWYjlNREo0ZWVhQ0Fo?=
 =?utf-8?B?TmxRVDR4M3RmL1EveGE5SitBTVZHVUFKVVFHWEZVS2pQMUVJMHpiKzZtUnp2?=
 =?utf-8?B?eVJXczY2ZC9POEpZTnAzMXN1YlpEV01VTXIvVndpYXBPTU9WaGhOM3hieXI0?=
 =?utf-8?B?MGZBZVdpNnFJZStkYmtMVVpFbzhGQjUvd0lweWd5T3h1aUkyVzNUVlVySjJK?=
 =?utf-8?B?TUhYSGVVN2FOZkdlQ2tFZnBjUi9NUjdqZi9KUjBWbjZGcGpMU21qNUM3azNJ?=
 =?utf-8?B?Q0ovUmV2NWZLODdta1VPYS93Q1YwMytLZVU5N2hwV1dMb1kzQks5V1VaTGFU?=
 =?utf-8?B?TVhkdXUxRkt5c1BqTkpiNzBPQ3BrK2E2VmpNVXl3NjZRZ2ZkYWxLK2dwekp3?=
 =?utf-8?B?Z0ZkWm85VFpQMHZkRGdhb2xkV2k3QTR0dDJ6M1ovcGpDZjhtNUpJUUo2THZI?=
 =?utf-8?B?SEtqcFlFNVZ3YlZFbFgxMEd5QnY3alVJY0FzYTZZMXlSTkNXdDRhY2gyMVBB?=
 =?utf-8?B?RHlGY1Uyam9YZmQ3bittM2JPb0hiRnlYSTVmNHNuMW4wenRuZlhwWFRqVHRP?=
 =?utf-8?B?S1lwK2JTY1Y5UC9tODVjZTZQS25wMEVscm93VDREOXFBSHdXQUVwbEVDVHQr?=
 =?utf-8?B?VGxLcTJrUHB1MUJ1VXhSc1AxNEkxcnBodk40VWxUc05mbkNBQnNNRDFOTXhC?=
 =?utf-8?B?VWdRS21MNG9pRG9sRTlqU01DK0Y2YldCbnJQYWw3NmZOb2J6WTdudlZOOGJh?=
 =?utf-8?B?Q3Q5aDkwMGdFZVBNTjg0VUw2Rm9ESXd0dlZaZWIxQURsL0Y1NTQxODZXbnE2?=
 =?utf-8?B?ZjR1QXRYZWNtZnpSTDN6VEhqblVVK3F4OXhoY1k5eXdZd0h1emwxWnF1ZUZo?=
 =?utf-8?Q?WGMrvBpJttfeY3FwNaT/pTKct?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3835707-d6fa-48b5-a51f-08da7f3fe6ba
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 04:29:25.9035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iJ4cLwtf84R4TXTXAw+0dQREY10Q8DbILl2sdPaP/2AdOM2Rb5XYwMEadvxl01KvD9UqQq+RsS3KSOC6jfevTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB4749
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15/08/22 18:34, Chao Peng wrote:
> On Fri, Aug 12, 2022 at 02:18:43PM +0530, Nikunj A. Dadhania wrote:
>>
>>
>> On 12/08/22 12:48, Gupta, Pankaj wrote:
>>>
>>>>>>>>
>>>>>>>> However, fallocate() preallocates full guest memory before starting the guest.
>>>>>>>> With this behaviour guest memory is *not* demand pinned. Is there a way to
>>>>>>>> prevent fallocate() from reserving full guest memory?
>>>>>>>
>>>>>>> Isn't the pinning being handled by the corresponding host memory backend with mmu > notifier and architecture support while doing the memory operations e.g page> migration and swapping/reclaim (not supported currently AFAIU). But yes, we need> to allocate entire guest memory with the new flags MEMFILE_F_{UNMOVABLE, UNRECLAIMABLE etc}.
>>>>>>
>>>>>> That is correct, but the question is when does the memory allocated, as these flags are set,
>>>>>> memory is neither moved nor reclaimed. In current scenario, if I start a 32GB guest, all 32GB is
>>>>>> allocated.
>>>>>
>>>>> I guess so if guest memory is private by default.
>>>>>
>>>>> Other option would be to allocate memory as shared by default and
>>>>> handle on demand allocation and RMPUPDATE with page state change event. But still that would be done at guest boot time, IIUC.
>>>>
>>>> Sorry! Don't want to hijack the other thread so replying here.
>>>>
>>>> I thought the question is for SEV SNP. For SEV, maybe the hypercall with the page state information can be used to allocate memory as we use it or something like quota based memory allocation (just thinking).
>>>
>>> But all this would have considerable performance overhead (if by default memory is shared) and used mostly at boot time. 
>>
>>> So, preallocating memory (default memory private) seems better approach for both SEV & SEV SNP with later page management (pinning, reclaim) taken care by host memory backend & architecture together.
>>
>> I am not sure how will pre-allocating memory help, even if guest would not use full memory it will be pre-allocated. Which if I understand correctly is not expected.
> 
> Actually the current version allows you to delay the allocation to a
> later time (e.g. page fault time) if you don't call fallocate() on the
> private fd. fallocate() is necessary in previous versions because we
> treat the existense in the fd as 'private' but in this version we track
> private/shared info in KVM so we don't rely on that fact from memory
> backstores.

Thanks for confirming Chao, in that case we can drop fallocate() from qemu 
in both the case
* Once while creating the memfd private object
* During ram_block_convert_range() for shared->private and vice versa.
 
> Definitely the page will still be pinned once it's allocated, there is
> no way to swap it out for example just with the current code. 

Agree, at present once the page is brought in, page will remain till VM shutdown.

> That kind of support, if desirable, can be extended through MOVABLE flag and some
> other callbacks to let feature-specific code to involve.

Sure, that could be future work.

Regards
Nikunj