Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3349533rwb; Tue, 16 Aug 2022 00:57:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR5MpPU5Yn2qCOs3jr00ItTIM8MxJR8ghI/zibr/APDTEtjIzknnCASoplQBDhZxPXTd9AVs X-Received: by 2002:a17:90a:4887:b0:1f7:7676:e46e with SMTP id b7-20020a17090a488700b001f77676e46emr31712214pjh.107.1660636652545; Tue, 16 Aug 2022 00:57:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660636652; cv=none; d=google.com; s=arc-20160816; b=i/+wex8JnoE6xfS6KyfdaREwUxK4Flbym6dxoM21tIkZjt9igH5TugJGS1WAt9sZfl j/cS5f7JyudgT8fzPfUR0H3V2mHftzXDXfT969mrgNHz/8raNV0GKNt2t1pD2nZ7ytla U/lRfIfvuVqkH8vZtZfi0xpoeF9Go0VJ0VpRxeGXg8I4V3V2TzkS0AaBG5Bk9BksFKaQ GhIntVwVr4V86Q4nE2wl0yzYL5tYDEGTTycugCSSetyi8zoQ9wdLYQTS9J/dVyYkqKbu cSRK/CEmCeuOi9g8T6VEuyqRMPVpFOtD4osWk9ygSgWXhsyqhT2pJeDdUU0fQFkd8LpV 7j4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PmP4Hf7tJng10no+htIMM8RmAOpQCFsGAslDASJ9mXg=; b=Ul+oz3diHHNa+bWwv+a15eZ4i5hDFApEqL2PEteEphLqWjvtpTHrRPU5j8F2ct0NdK T0lU8EAej+A53/GwquSWBgxqFyiyEWlOt1o2iPwh5CDr3vINE/Ho+HKR9XhXLojrVf8L 01Inj6FsYhCoi8JEFQJFdHogFNv6Yqf0gVhQQwrfPJXCL+yUP4nxe8arefHL7bThRx0J 8J4cBZWtlGpreCpvKspx55+faBBO4ZSnhV/pOhfc2j0Z3dH8H40oEs8EqIalUX5bHAmu tEj3ESGByavGFlBnJOjAW3Md7VG7wbSqZ4l9ubu6Fwf7/92OEDzkheUuW3TFHW5Qh4te igng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TVrqc6oh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d185-20020a6368c2000000b0042975482cf7si4613728pgc.596.2022.08.16.00.57.21; Tue, 16 Aug 2022 00:57:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TVrqc6oh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231824AbiHPHTr (ORCPT + 99 others); Tue, 16 Aug 2022 03:19:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231817AbiHPHT2 (ORCPT ); Tue, 16 Aug 2022 03:19:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BD9A312F5E; Mon, 15 Aug 2022 21:53:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 112E76123B; Tue, 16 Aug 2022 04:52:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 884CEC433D7; Tue, 16 Aug 2022 04:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660625554; bh=GE52hG4m2Wbk4kwiM1hwpls8Mi0EjJtP8LLC42lj3Rc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TVrqc6ohjA38jANmJ6jP0l1mlldINfu8EUQr842wVtm01mYuGm119krD5gh6un0uV Qh0jM2BHrfiQM0mUWRn5zmz0Me+9xD0aoUbZJpxp8jVCkyeIMngQsD9ndpvxGx2cQG EJAqVbu8QQodyBP5A6ZGzy8y0DEAuhxBblUU4J4c= Date: Tue, 16 Aug 2022 06:52:30 +0200 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , stable@vger.kernel.org Subject: Re: [PATCH v1] usb: typec: tcpm: Return ENOTSUPP for power supply prop writes Message-ID: References: <20220816033355.1259400-1-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220816033355.1259400-1-badhri@google.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 15, 2022 at 08:33:55PM -0700, Badhri Jagan Sridharan wrote: > When the port does not support USB PD, prevent transition to PD > only states when power supply property is written. In this case, > TCPM transitions to SNK_NEGOTIATE_CAPABILITIES > which should not be the case given that the port is not pd_capable. > > [ 84.308251] state change SNK_READY -> SNK_NEGOTIATE_CAPABILITIES [rev3 NONE_AMS] > [ 84.308335] Setting usb_comm capable false > [ 84.323367] set_auto_vbus_discharge_threshold mode:3 pps_active:n vbus:5000 ret:0 > [ 84.323376] state change SNK_NEGOTIATE_CAPABILITIES -> SNK_WAIT_CAPABILITIES [rev3 NONE_AMS] > > Signed-off-by: Badhri Jagan Sridharan > --- > drivers/usb/typec/tcpm/tcpm.c | 7 +++++++ > 1 file changed, 7 insertions(+) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.