Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3349750rwb; Tue, 16 Aug 2022 00:57:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR6t95iWNE9qD19orzzCmedqx4kzY8UHEG4grWkPFKGmM0J4M9OXTk8aC9YXMf9zRi1wzGbg X-Received: by 2002:a17:90b:164d:b0:1f6:a38b:91e9 with SMTP id il13-20020a17090b164d00b001f6a38b91e9mr22512030pjb.211.1660636679119; Tue, 16 Aug 2022 00:57:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660636679; cv=none; d=google.com; s=arc-20160816; b=v6GcUTDgAbMKvjm5hP3IfqioAZvyR4z5/YHgVNxiUQOhzWs8DZTFHFoKfjqa8SztMR V7Of0uxgrjsQpnJDkDWoPm5m8qi7XEwUzSTDdBNLieZIYNHFuiaNP1HPMIEtoBG9yOqj waCfbOBi8MKRsxrcBYuTzV1Wd4mkKCgPOJUTdoM5ieN8ONanm8OoItaGNSVbrEHvtEjV p11NG4xa4pnXMF0QlPpQ50DF3/J7z56d/Jnb0YP8div6z4/e3AEXpgGj5gt9Adcqonb/ zTV3POOWmrwSBhAsQCmyPmHO58+xyKF8SYW56uuwxA9Yz6jhB+ucx14JIa9k4M3xpTj5 2QAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TmG0k6JPUjEPAuHW9xANQcahfddd8zg1KbieKiNAerU=; b=Ge1NiYnAkUgvUqsOgm17sDujDyaMt9KuTy9QUMUZcgVnzdp6Wf3ld9v7ggDY+flA92 J++THh+lE52eDNeHyvY8n5rjcfrYaIZ/wOgXDXLec5AiFU6U7t7z/Ij3LFFBCitGbpHE E3QjlpLrgX0ttHc6CGvUQ6EhCsvCUKuwdPrMQssBtC/BKLWsHWRMM/O/DmvuG5kU+Wa5 CNtnW5+wZqTtHRmp3FvRTTtAX76qvrFlfnVi01ZhXtbBDvovn/epgPoGygaa0E6e8GXX AeCGmcadMijd0uxNpTQ1o3SOwaU9HE7wpprqivmks0sF49NCkVJb81qMQ3ofnAemC7JI ygng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TYP5oayw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bj5-20020a170902850500b0016c3f3acbaasi11792710plb.441.2022.08.16.00.57.48; Tue, 16 Aug 2022 00:57:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=TYP5oayw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229891AbiHPG6h (ORCPT + 99 others); Tue, 16 Aug 2022 02:58:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231248AbiHPG54 (ORCPT ); Tue, 16 Aug 2022 02:57:56 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE88DE992E for ; Mon, 15 Aug 2022 19:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660616447; x=1692152447; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MvtxoyXdbD8IhpYSw22bukxIMLJ6r6tkTtWGcsAxUc8=; b=TYP5oaywmshxrErYdmjzU+hM8bL4gkmFHuG0dQJitEyS09Y8jUDYkAVW SuHoVs9kEomqasJwzpS/Z39BT4zekD7kpSMa3vd4v19oHchKsnGWpEQms rk9mnWN9lyr6fltN8ODxDOTnGzGo+uhTBWlCYAy3xRRF1oJB9Wu/7NQS7 rWorgJiziYkBtvPAGE4J85EGFglzIrnIOjsxso8UJmHgGx3lL/hl2jGhZ yvpWw/PG1GYQGsS/AUnAwmm73YVlMwuP97EQ9DEVItBkKfIBx6uPV6QKX EFKpumE0u/hshjo5gR3/xd6hUrCTQoBJbYnuG/I7PoXhbwFhzdwSj5xjQ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10440"; a="378396205" X-IronPort-AV: E=Sophos;i="5.93,240,1654585200"; d="scan'208";a="378396205" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2022 19:20:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,240,1654585200"; d="scan'208";a="934706641" Received: from sse-cse-haiyue-nuc.sh.intel.com ([10.239.241.114]) by fmsmga005.fm.intel.com with ESMTP; 15 Aug 2022 19:20:45 -0700 From: Haiyue Wang To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, david@redhat.com, apopple@nvidia.com, linmiaohe@huawei.com, ying.huang@intel.com, songmuchun@bytedance.com, naoya.horiguchi@linux.dev, alex.sierra@amd.com, Haiyue Wang Subject: [PATCH v6 0/2] fix follow_page related issues Date: Tue, 16 Aug 2022 10:20:59 +0800 Message-Id: <20220816022102.582865-1-haiyue.wang@intel.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20220812084921.409142-1-haiyue.wang@intel.com> References: <20220812084921.409142-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_ENVFROM, HK_RANDOM_FROM,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v6: Simplify the multiple layers of conditionals for if {} - if (page) { - err = !is_zone_device_page(page) ? page_to_nid(page) - : -ENOENT; - if (foll_flags & FOLL_GET) - put_page(page); - } else { - err = -ENOENT; - } + err = -ENOENT; + if (!page) + goto set_status; + + if (!is_zone_device_page(page)) + err = page_to_nid(page); + + if (foll_flags & FOLL_GET) + put_page(page); v5: reword the commit message for FOLL_GET with more information. v4: add '()' for the function for readability. add more words about the Non-LRU pages fix in commit message. v3: Merge the fix for handling Non-LRU pages into one patch. Drop the break_ksm zone device page check. v2: Add the Non-LRU pages fix with two patches, so that 'mm: migration: fix the FOLL_GET' can be applied directly on linux-5.19 stable branch. Haiyue Wang (2): mm: migration: fix the FOLL_GET failure on following huge page mm: fix the handling Non-LRU pages returned by follow_page mm/huge_memory.c | 4 ++-- mm/ksm.c | 12 +++++++++--- mm/migrate.c | 23 +++++++++++++++++------ 3 files changed, 28 insertions(+), 11 deletions(-) -- 2.37.2