Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43c7ea8b-f0ca-7f06-02b7-acf677a6f21d@ti.com>
Date:   Tue, 16 Aug 2022 09:56:17 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2 net-next] net: ethernet: ti: davinci_mdio: Add
 workaround for errata i2329
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <linux-omap@vger.kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <kishon@ti.com>,
        <vigneshr@ti.com>
References: <20220810111345.31200-1-r-gunasekaran@ti.com>
 <YvRNpAdG7/edUEc+@lunn.ch> <9d17ab9f-1679-4af1-f85c-a538cb330d7b@ti.com>
 <YvT8ovgHz2j7yOQP@lunn.ch> <ed3554bc-af62-78ce-a3eb-ff5f27ade6a2@ti.com>
 <YvZ3uc0xi18C1g5t@lunn.ch>
From:   Ravi Gunasekaran <r-gunasekaran@ti.com>
In-Reply-To: <YvZ3uc0xi18C1g5t@lunn.ch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/08/22 9:24 pm, Andrew Lunn wrote:
>> sh_eth is not configured for autosuspend and uses only pm_runtime_put().
> 
> I don't know the runtime power management code very well. We should
> probably ask somebody how does. However:
> 
> https://elixir.bootlin.com/linux/latest/source/drivers/base/power/runtime.c#L168
> 
> This suggests it should be safe to perform an auto suspend on a device
> which is not configured for auto suspend. To me, it looks like is
> should directly suspend.

I checked the pm_runtime_put() and pm_runtime_put_autosuspend() and I 
have quite a few unanswered questions. I do not have much knowledge 
about the runtime PM, so I'm not confident about adding the runtime PM 
mdiobb_read/mdiobb_write variants in the mdio bitbang core. I would 
rather take a safe approach for now and stick with the implementation 
submitted in this v2 patch.

Thanks for your feedback on this submission so far. I will fix the two 
other comments and send out a v3 patch.

-- 
Regards,
Ravi