Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Message-ID: <14bed619e6a884f37403ec58aead34ff86525f26.camel@ljones.dev>
Subject: Re: [PATCH 1/6] Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable
 method")
From:   Luke Jones <luke@ljones.dev>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     markgross@kernel.org, platform-driver-x86@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 16 Aug 2022 18:23:13 +1200
In-Reply-To: <657998b3-0f26-9a66-8191-713715622c01@redhat.com>
References: <20220812222509.292692-1-luke@ljones.dev>
         <20220812222509.292692-2-luke@ljones.dev>
         <fc250b82-c7c7-9215-f3dd-be87e0a72edd@redhat.com>
         <657998b3-0f26-9a66-8191-713715622c01@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-08-15 at 15:40 +0200, Hans de Goede wrote:
> Hi,
>=20
> On 8/15/22 15:25, Hans de Goede wrote:
> > Hi Luke,
> >=20
> > On 8/13/22 00:25, Luke D. Jones wrote:
> > > The dgpu_disable attribute was not documented, this adds the
> > > required documentation.
> > >=20
> > > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> >=20
> > Thanks for the patch. Note that the Fixes tag should be above your
> > signed-off-by and then the patch should otherwise have a normal
> > subject + body. I've changed the commit msg to the following
> > while merging this:
> >=20
> > """
> > platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute
> > =C2=A0=C2=A0=C2=A0=20
> > The dgpu_disable attribute was not documented, this adds the
> > required documentation.
> > =C2=A0=C2=A0=C2=A0=20
> > Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > """
>=20
> While merging this I noticed that this is also using spaces
> instead of tabs for indentation, where as the rest of
> the file is using tabs.
>=20
> I've also fixed this up while merging, but next time
> please make sure to use spaces.
>=20
> I will make similar spaces -> tabs changes to patch 2/6 and 3/6
>=20

I ran these through ./scripts/checkpatch.pl... I'm really not sure what
happened. I'll triple-check that in future.

> Regards,
>=20
> Hans
>=20
>=20
>=20
>=20
> > > ---
> > > =C2=A0Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++
> > > =C2=A01 file changed, 9 insertions(+)
> > >=20
> > > diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > index 04885738cf15..0f932fd60f4a 100644
> > > --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> > > @@ -57,3 +57,12 @@ Description:
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
* 0 - default,
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
* 1 - overboost,
> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
* 2 - silent
> > > +
> > > +What:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /sys/dev=
ices/platform/<platform>/dgpu_disable
> > > +Date:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Aug 2022
> > > +KernelVersion: 5.17
> > > +Contact:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "Luke Jones" <luke@ljon=
es.dev>
> > > +Description:
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 Disable discrete GPU:
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * 0 - En=
able dGPU,
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * 1 - Di=
sable dGPU,
> > > \ No newline at end of file
> >=20
> > Next time please make sure the file always ends with a newline
> > even in intermediate patches.
> >=20
> > Regards,
> >=20
> > Hans
> >=20
> >=20
>=20