Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3368243rwb; Tue, 16 Aug 2022 01:24:52 -0700 (PDT) X-Google-Smtp-Source: AA6agR4x5XvigU/wwvsxz3VG7tiKxIp9fUKT/P4fgdGam6Tw4JPT5Uk/PWxPTyGpbjOHCyvkZW5g X-Received: by 2002:a05:6402:5489:b0:43b:b935:db37 with SMTP id fg9-20020a056402548900b0043bb935db37mr18221376edb.347.1660638292031; Tue, 16 Aug 2022 01:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660638292; cv=none; d=google.com; s=arc-20160816; b=GcgA9gw2ZNNccC46GSMBGiVm2ElK9jHgaWZnUnUhzzUeJghdyDVj2/pT0N3Gj+2lGd Ge6NXuyXLMLWum/ZlIvqB/Y2bn1HwitqZ8XPqAmX0Fqxx4NEVltOb1IlEVWVlQTFBrsl LY7hzPWzw68kP/X5MJJg8IcKo7OKSE8lvkpcs5X0S/rTUe8MQuBXWPjXrhKszNAWboKG ucf+vRlCmuAvza23s2NxKi+bs8kccNMbVs9kwxLnMknZw2ndGqSLHpvBC8rs/irP7ZWP Hdrqj7R30grSw6Iv1ea7Giq65qI4NFOXpLifrIBctwAx93538kSX+YyTfQypLh6e6myo Zb9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=n8bWLRAjIHlbdQt28PJjzumM4XdGGn+8swvssjGZUGI=; b=HvQSCBzZrEWzHaAbXbVKPOCl489As2XRU9B6Wel0nV72bULuk0+MdUeUqlKC4KkggS 47JgJm+hHjhw7+9DJaTAtER2kujP8zf2AjPwggA4GiFSEGJxrkpQxv3HWl5w2aqeELIw MB/47yOccm0w2pfNG7Jec4DjboM3NjKLaDNIyiulWT8I5YD7/siKQe5nMmIojAY0wBQV RNqY/kyr9RW+k+kahWT7OrrpRWQnoHl6owObEy8WtyTmOO25N4ye//hFmdnDBj/wN7Mc gTSRAg3NWlUstewNrMvY8rglMv6oMxuAv5lj3IG4AQ3gJDTXGT1gjH8d/4HEkPoKztiz Sj7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=lUXmOJK1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp5-20020a1709073e0500b0072a8fcb3683si10226695ejc.20.2022.08.16.01.24.26; Tue, 16 Aug 2022 01:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=lUXmOJK1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbiHPIDJ (ORCPT + 99 others); Tue, 16 Aug 2022 04:03:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230383AbiHPICj (ORCPT ); Tue, 16 Aug 2022 04:02:39 -0400 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE853105204; Mon, 15 Aug 2022 22:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1660627464; x=1692163464; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=n8bWLRAjIHlbdQt28PJjzumM4XdGGn+8swvssjGZUGI=; b=lUXmOJK1xCbUbIy4WxeGzoFaP3AwvlFgP0hy2ZDTXqMRyDk3MMS4X+je ywWJYAtO6sBoZi7qsUEURM3MdsJqn+E/V9vvK0Ze+8hjROTmXcGxbHZde IL0IBD1NaFr8CMujaun0d/1h/jFW4euWRfu1RF85FOv7tMmoqEi351LMA A=; X-IronPort-AV: E=Sophos;i="5.93,240,1654560000"; d="scan'208";a="230038836" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-iad-1a-b09d0114.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-2101.iad2.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2022 05:24:13 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-b09d0114.us-east-1.amazon.com (Postfix) with ESMTPS id 9E48C81280; Tue, 16 Aug 2022 05:24:10 +0000 (UTC) Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Tue, 16 Aug 2022 05:24:09 +0000 Received: from 88665a182662.ant.amazon.com (10.43.160.55) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.12; Tue, 16 Aug 2022 05:24:07 +0000 From: Kuniyuki Iwashima To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni CC: Kuniyuki Iwashima , Kuniyuki Iwashima , , Subject: [PATCH v1 net 00/15] sysctl: Fix data-races around net.core.XXX (Round 1) Date: Mon, 15 Aug 2022 22:23:32 -0700 Message-ID: <20220816052347.70042-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.160.55] X-ClientProxiedBy: EX13D24UWB003.ant.amazon.com (10.43.161.222) To EX19D004ANA001.ant.amazon.com (10.37.240.138) X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series fixes data-races around 22 knobs in net_core_table. These knobs are skipped: - netdev_rss_key: Written only once by net_get_random_once() and read-only knob - rps_sock_flow_entries: Protected with sock_flow_mutex - flow_limit_cpu_bitmap: Protected with flow_limit_update_mutex - flow_limit_table_len: Protected with flow_limit_update_mutex - default_qdisc: Protected with qdisc_mod_lock - warnings: Unused Note 9th patch fixes net.core.message_cost and net.core.message_burst, and lib/ratelimit.c does not have an explicit maintainer. The next round is the final round for net.core.XXX and starts from netdev_budget_usecs. Kuniyuki Iwashima (15): net: Fix data-races around sysctl_[rw]mem_(max|default). net: Fix data-races around weight_p and dev_weight_[rt]x_bias. net: Fix data-races around netdev_max_backlog. bpf: Fix data-races around bpf_jit_enable. bpf: Fix data-races around bpf_jit_harden. bpf: Fix data-races around bpf_jit_kallsyms. bpf: Fix a data-race around bpf_jit_limit. net: Fix data-races around netdev_tstamp_prequeue. ratelimit: Fix data-races in ___ratelimit(). net: Fix data-races around sysctl_optmem_max. net: Fix a data-race around sysctl_tstamp_allow_data. net: Fix a data-race around sysctl_net_busy_poll. net: Fix a data-race around sysctl_net_busy_read. net: Fix a data-race around netdev_budget. net: Fix data-races around sysctl_max_skb_frags. Documentation/admin-guide/sysctl/net.rst | 2 +- arch/arm/net/bpf_jit_32.c | 2 +- arch/arm64/net/bpf_jit_comp.c | 2 +- arch/mips/net/bpf_jit_comp.c | 2 +- arch/powerpc/net/bpf_jit_comp.c | 5 +++-- arch/riscv/net/bpf_jit_core.c | 2 +- arch/s390/net/bpf_jit_comp.c | 2 +- arch/sparc/net/bpf_jit_comp_32.c | 5 +++-- arch/sparc/net/bpf_jit_comp_64.c | 5 +++-- arch/x86/net/bpf_jit_comp.c | 2 +- arch/x86/net/bpf_jit_comp32.c | 2 +- include/linux/filter.h | 16 ++++++++++------ include/net/busy_poll.h | 2 +- kernel/bpf/core.c | 2 +- lib/ratelimit.c | 8 +++++--- net/core/bpf_sk_storage.c | 5 +++-- net/core/dev.c | 16 ++++++++-------- net/core/filter.c | 13 +++++++------ net/core/gro_cells.c | 2 +- net/core/skbuff.c | 2 +- net/core/sock.c | 18 ++++++++++-------- net/core/sysctl_net_core.c | 10 ++++++---- net/ipv4/ip_output.c | 2 +- net/ipv4/ip_sockglue.c | 6 +++--- net/ipv4/tcp.c | 4 ++-- net/ipv4/tcp_output.c | 2 +- net/ipv6/ipv6_sockglue.c | 4 ++-- net/mptcp/protocol.c | 2 +- net/netfilter/ipvs/ip_vs_sync.c | 4 ++-- net/sched/sch_generic.c | 2 +- net/xfrm/espintcp.c | 2 +- net/xfrm/xfrm_input.c | 2 +- 32 files changed, 85 insertions(+), 70 deletions(-) -- 2.30.2