Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 Aug 2022 07:24:17 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Greg Ungerer <gerg@linux-m68k.org>
Cc:     Xin Gao <gaoxin@cdjrlc.com>, geert@linux-m68k.org,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Complete variable type
Message-ID: <Yvs4EUfVUdOgEW4f@ZenIV>
References: <20220815194806.3487-1-gaoxin@cdjrlc.com>
 <4ae72d0b-b197-f9d8-5cbe-ce7cfaf3affc@linux-m68k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4ae72d0b-b197-f9d8-5cbe-ce7cfaf3affc@linux-m68k.org>
Sender: Al Viro <viro@ftp.linux.org.uk>
Precedence: bulk

On Tue, Aug 16, 2022 at 09:37:19AM +1000, Greg Ungerer wrote:
> On 16/8/22 05:48, Xin Gao wrote:
> > @@ -169,7 +169,7 @@ void q40_sched_init (void)
> >    *
> >   */
> > -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> > +struct IRQ_TABLE{ unsigned int mask; int irq };
> >   #if 0
> >   static struct IRQ_TABLE iirqs[]={
> >     {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
> 
> This last change doesn't match the commit message.
> It should be a separate patch.

	The last change is not a valid C.  Never had been.
In C semicolon is *NOT* a separator - it's a part of declaration.

-- 
improve the kernel quality - git rm scripts/checkpatch.pl