Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c411c5c5-0a8b-c85c-2d57-1a387eb0d28f@linaro.org>
Date:   Tue, 16 Aug 2022 10:14:55 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl
 nodes
Content-Language: en-US
To:     Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
Cc:     Project_Global_Chrome_Upstream_Group@mediatek.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        Guodong Liu <guodong.liu@mediatek.com>
References: <20220815122503.2768-1-allen-kh.cheng@mediatek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220815122503.2768-1-allen-kh.cheng@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15/08/2022 15:25, Allen-KH Cheng wrote:
> There are 8 GPIO physical address bases in mt8186, corresponding to the
> items of 'reg-names' with the pinctrl driver. but the order of

New sentences start with capital letter.

> 'reg-names' is not correct. The mt8186 pinctrl driver would get the
> wrong address, causing the system to restart when regulator initializes
> . we 

^^^ Something is missing. Sentence looks unfinished, full stop is in new
line, next sentence does not start with capital letter.


> fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
> in bindings.
> 
> Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
> ---
Best regards,
Krzysztof