Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alistair Popple <apopple@nvidia.com>
To:     linux-mm@kvack.org, akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>, paulus@ozlabs.org,
        Alistair Popple <apopple@nvidia.com>,
        Peter Xu <peterx@redhat.com>, linuxppc-dev@lists.ozlabs.org,
        Huang Ying <ying.huang@intel.com>, stable@vger.kernel.org
Subject: [PATCH v2 1/2] mm/migrate_device.c: Copy pte dirty bit to page
Date:   Tue, 16 Aug 2022 17:39:24 +1000
Message-Id: <6e77914685ede036c419fa65b6adc27f25a6c3e9.1660635033.git-series.apopple@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OGVN7n2W7iglX1nV+3XwRdGtzWRvPJka5/0RqqiPqZVYBRdY+V+oye897wb/?=
 =?us-ascii?Q?USzHM4U8WpZlIojJAl5g2bsNbJ5MjwusO730aoQxVo14rBqdD9kGTZ3DMeb4?=
 =?us-ascii?Q?PxenRvtpe3zXgpCWt5sK6flHp6ifFkYb0wfpF4MjB1xqUbWtPBIUSTCmR75Y?=
 =?us-ascii?Q?xOYvC4/fOJ++vjB2mCycp0kpr9PgaEsz7VKKEORAIBz6XpvrCQewbojGPNto?=
 =?us-ascii?Q?CZjl2B7bXBxP45/E2Mx8Q0zBc8VU9XeSRwW23ZvKeKtJolhx5zEOcLOqaMlz?=
 =?us-ascii?Q?QeOKmWOdtGbRE4xjUzgfvkZxwlJfLR53LXOiKxi3b90xPVg3eQ+D4GfABg+l?=
 =?us-ascii?Q?71kUkM7J5PUkuQTeHcU7plOOsQcE9fTdtCoGlsabZNlF9fovYr4RpPmPaqYT?=
 =?us-ascii?Q?AHi3A5FYWoesB7LUiriqgh4I7+0Yejt7rpMhc2tpF4cBt3P4gSGh/u46ZtoK?=
 =?us-ascii?Q?jOTzkm/76vMed/uQ0zQLju2w23G/OO5ruAEwsaazLyPMAD/Iub9iTTBjUVIV?=
 =?us-ascii?Q?ZtMI/WcMZXWt8FpCCdrBUuht2VLbEu9qRLkVnvlFBKdT6/cVQc2RTXrvhVCz?=
 =?us-ascii?Q?W1oL12tYNTon7H4Jsg/D2jTexX2RClzesT53R7uyu1LmGcuWeCLIPfPdO6hU?=
 =?us-ascii?Q?bVBfBgZRMHJTm0UxKovWjn+ISLf4wJnwfke+u47f4nJaD32tZiF9ELIZjixY?=
 =?us-ascii?Q?xnJUb/RWJ3FPfXq9pf8K3AtRu8s03Mztd4H8mWVHboEZTUwumfU5oo6Sg+Ks?=
 =?us-ascii?Q?sn+q8sxXz1tZtzLKPfEOHK+vII1VcEreAF0Kxv3p5LoK1a2IebATRGHm02nA?=
 =?us-ascii?Q?TIAJIvZZo2UWQaT3Nz3SBa6T1cL4r821D550xvoP/d3S+9R1i7ZWA++4GGvC?=
 =?us-ascii?Q?EL6lcfGzVsUp49sxyIGWsYj5q26QszrJlCvQGmn0jZ7e/rb5rNakZ0yv0U53?=
 =?us-ascii?Q?wx/a2bQ4ApaJ0fQDcgBHv2d35QxcPg4z7ZOuWX4fiJsUN+K4AIiN4IP4yvMR?=
 =?us-ascii?Q?pmFxLU3+nWoXChgilDaEzMhO3xbm2lLJAifC0Xv78e+ubCWzLYr2lqP36jCj?=
 =?us-ascii?Q?XQ4EGA5KFh6kmGFFnDtf5yrnmoXZRrEWkP3i0CCzmqrErWQCNng1iOdj4i2U?=
 =?us-ascii?Q?i5nGmJoAyqW6kx1rsXsZLc3qrBYvOlwZlLI1KuJHICt5JzcbAeSwMqz2lbcr?=
 =?us-ascii?Q?uUz15yZy1EDaeSqseqa4d+C4+Ic48bHwPDlULEbvZulgzNN7CXAZ/hhIao6n?=
 =?us-ascii?Q?cY3foIg/xOUzySKSzeBpWpX78xCxTr6XD91ZNOn3NBxWAqtHA4dUQ2B8ygPn?=
 =?us-ascii?Q?i237yiCoNrVb6lZ0OXWgpMSTKr2IIPl2/nvifpas3I2KC3KSsW9pah3UX7ev?=
 =?us-ascii?Q?yiqbeiVznnBowYzl78POt3umtnDhkfvgsuXCZNVMBRhl3rN2ea43mVZzqgXr?=
 =?us-ascii?Q?yxvIO5fHCdYLCbL+E1Z54j4vv8x3r4jpjz2QqdCg9SzKyDqfMRRwztKQOH6x?=
 =?us-ascii?Q?/RQylKxUCtkKKUBLKVC8r2mH8XmI8SENV0VFOD86cME3u3jwrWRWo+w4OHe0?=
 =?us-ascii?Q?E9Od7FnFxvj5gyoh0mj2EAa8+QosKdBhfM8mhuRl?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07719a87-772e-44be-62f2-08da7f5a7ef5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 07:39:48.1547
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PiK60TEN8R6uB4XT1pHCuAfm+yhtMaEB4ASHtIH6sbvQsQ35AoIq6dYWyIH4BxZdyMUBgXWKZhx9T9v2sHwOrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4722
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

migrate_vma_setup() has a fast path in migrate_vma_collect_pmd() that
installs migration entries directly if it can lock the migrating page.
When removing a dirty pte the dirty bit is supposed to be carried over
to the underlying page to prevent it being lost.

Currently migrate_vma_*() can only be used for private anonymous
mappings. That means loss of the dirty bit usually doesn't result in
data loss because these pages are typically not file-backed. However
pages may be backed by swap storage which can result in data loss if an
attempt is made to migrate a dirty page that doesn't yet have the
PageDirty flag set.

In this case migration will fail due to unexpected references but the
dirty pte bit will be lost. If the page is subsequently reclaimed data
won't be written back to swap storage as it is considered uptodate,
resulting in data loss if the page is subsequently accessed.

Prevent this by copying the dirty bit to the page when removing the pte
to match what try_to_migrate_one() does.

Signed-off-by: Alistair Popple <apopple@nvidia.com>
Acked-by: Peter Xu <peterx@redhat.com>
Reported-by: Huang Ying <ying.huang@intel.com>
Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages")
Cc: stable@vger.kernel.org

---

Changes for v2:

 - Fixed up Reported-by tag.
 - Added Peter's Acked-by.
 - Atomically read and clear the pte to prevent the dirty bit getting
   set after reading it.
 - Added fixes tag
---
 mm/migrate_device.c | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/mm/migrate_device.c b/mm/migrate_device.c
index 27fb37d..e2d09e5 100644
--- a/mm/migrate_device.c
+++ b/mm/migrate_device.c
@@ -7,6 +7,7 @@
 #include <linux/export.h>
 #include <linux/memremap.h>
 #include <linux/migrate.h>
+#include <linux/mm.h>
 #include <linux/mm_inline.h>
 #include <linux/mmu_notifier.h>
 #include <linux/oom.h>
@@ -61,7 +62,7 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
 	struct migrate_vma *migrate = walk->private;
 	struct vm_area_struct *vma = walk->vma;
 	struct mm_struct *mm = vma->vm_mm;
-	unsigned long addr = start, unmapped = 0;
+	unsigned long addr = start;
 	spinlock_t *ptl;
 	pte_t *ptep;
 
@@ -193,11 +194,10 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
 			bool anon_exclusive;
 			pte_t swp_pte;
 
+			flush_cache_page(vma, addr, pte_pfn(*ptep));
+			pte = ptep_clear_flush(vma, addr, ptep);
 			anon_exclusive = PageAnon(page) && PageAnonExclusive(page);
 			if (anon_exclusive) {
-				flush_cache_page(vma, addr, pte_pfn(*ptep));
-				ptep_clear_flush(vma, addr, ptep);
-
 				if (page_try_share_anon_rmap(page)) {
 					set_pte_at(mm, addr, ptep, pte);
 					unlock_page(page);
@@ -205,12 +205,14 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
 					mpfn = 0;
 					goto next;
 				}
-			} else {
-				ptep_get_and_clear(mm, addr, ptep);
 			}
 
 			migrate->cpages++;
 
+			/* Set the dirty flag on the folio now the pte is gone. */
+			if (pte_dirty(pte))
+				folio_mark_dirty(page_folio(page));
+
 			/* Setup special migration page table entry */
 			if (mpfn & MIGRATE_PFN_WRITE)
 				entry = make_writable_migration_entry(
@@ -242,9 +244,6 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
 			 */
 			page_remove_rmap(page, vma, false);
 			put_page(page);
-
-			if (pte_present(pte))
-				unmapped++;
 		} else {
 			put_page(page);
 			mpfn = 0;
@@ -257,10 +256,6 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp,
 	arch_leave_lazy_mmu_mode();
 	pte_unmap_unlock(ptep - 1, ptl);
 
-	/* Only flush the TLB if we actually modified any entries */
-	if (unmapped)
-		flush_tlb_range(walk->vma, start, end);
-
 	return 0;
 }
 

base-commit: ffcf9c5700e49c0aee42dcba9a12ba21338e8136
-- 
git-series 0.9.1