Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759556AbXFJQXW (ORCPT ); Sun, 10 Jun 2007 12:23:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751972AbXFJQXO (ORCPT ); Sun, 10 Jun 2007 12:23:14 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:39063 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbXFJQXN (ORCPT ); Sun, 10 Jun 2007 12:23:13 -0400 Message-ID: <466C256C.9040509@garzik.org> Date: Sun, 10 Jun 2007 12:23:08 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Tejun Heo CC: Linus Torvalds , Gregor Jasny , Linux Kernel Mailing List , linux-ide@vger.kernel.org, Alan Cox , Andrew Morton Subject: Re: [PATCH] libata: limit post SRST nsect/lbal wait to ~100ms References: <9d2cd630705270801m2826be60p3f802c502b26c531@mail.gmail.com> <466196AD.3090502@garzik.org> <9d2cd630706031046n2bd77585o7c0df1c5fea5167f@mail.gmail.com> <46667466.4010500@gmail.com> <9d2cd630706062322v2d73b32dp1da56f97e2069fff@mail.gmail.com> <4667B347.9040900@gmail.com> <20070607224746.GA23290@havoc.gtf.org> <466AF98C.80101@garzik.org> <20070610052620.GH29122@htj.dyndns.org> In-Reply-To: <20070610052620.GH29122@htj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 32 Tejun Heo wrote: > After SRST, libata used to wait for nsect/lbal to be set to 1/1 for > the slave device. However, some ATAPI devices don't set nsect/lbal > after SRST and the wait itself isn't too useful as we're gonna wait > for !BSY right after that anyway. > > Before reset-seq update, nsect/lbal wait failure used to be ignored > and caused 30sec delay during detection. After reset-seq, all > timeouts are considered error conditions making libata fail to detect > such ATAPI devices. > > This patch limits nsect/lbal wait to around 100ms. This should give > acceptable behavior to such ATAPI devices while not disturbing the > heavily used code path too much. > > Signed-off-by: Tejun Heo > --- > Okay, here it is. Sorry for the delay. > > drivers/ata/libata-core.c | 32 +++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 13 deletions(-) Thanks. Maybe Gregor can confirm this fixes his problem? I'll ACK and push upstream then... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/