Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3473204rwb; Tue, 16 Aug 2022 03:49:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR4PdyqWa+el6fDzDRxud99e2Qx2ZU2IHRvvhJgP/ax3edXLHch58S2oQ7ijk13FYAat8bLG X-Received: by 2002:a17:903:2305:b0:16f:2420:dddf with SMTP id d5-20020a170903230500b0016f2420dddfmr21147786plh.138.1660646990343; Tue, 16 Aug 2022 03:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660646990; cv=none; d=google.com; s=arc-20160816; b=Hwr+3p7HRg+xcOhukXYSnGA+u3aabtUWA4YwbVqoRafFMSkjjxfFsuL/9YR3DY0Yn7 pdJFp1tUXvCZKnkk9XKCtj0FEb0knU2EzBpXtZuJ4tnrnqZIdhhOyI4B41WrJotcZB9q VbSCBdLiIUdr9ANOsKB6ZaR73xHVHMlhkfrc3O2ZC9EDP8m/tBwrxoScveJ2MgSczNT8 hCbV1K584HQyE824mLumrEe8x1hRFEIKzYsBwJ2lwXPEPi3tFqvCnQBgiD3DDc6E/c/c EfdT8MkT5IWUERRFvDfbdf5dMDrDBRsjv3EwPbIRhcyw2MOHQIVCVBLcOYcZf73VplRB 1IyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=9HxXIhlJ8egb+tUhCrrqxA/twApe2EwzTrM2sMlQQzE=; b=Ifc0OBnZav3di1djWIKyN4ukHYRzyCRYX+micAcpRAnii0xNZmL81dAeuCyOqXHSSl uID+xKz4AVKyPPBjHiPOathhFd3acm31JNh2KIWeQ86ukSxlknqeL+YrkhFMrcDQSbTD eczLqjd/+JzGK7+5VDsVDofzULDAd4+oY+RKaeqgFlROravj1XmJOj20E4CCMYrirabz N703xC+khDy9jcDIbiKCu/pZvBfaX0PXHgDfJD4i4L4xrrv5eRJg+Pk6A/ktFRNTaXTg TJ0qhZSegO0zaRjTwXvqjvuYMjvPLed6R72GZZD251Ictuo+a4Xx7nHU6c16eGUMloRl t9NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GhjmGk3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a170903230100b0016362d70cf1si15601943plh.50.2022.08.16.03.49.39; Tue, 16 Aug 2022 03:49:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=GhjmGk3S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233952AbiHPJ5T (ORCPT + 99 others); Tue, 16 Aug 2022 05:57:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234113AbiHPJ4Q (ORCPT ); Tue, 16 Aug 2022 05:56:16 -0400 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A71E30556; Tue, 16 Aug 2022 02:02:30 -0700 (PDT) Received: by mail-il1-x12d.google.com with SMTP id o14so5055579ilt.2; Tue, 16 Aug 2022 02:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=9HxXIhlJ8egb+tUhCrrqxA/twApe2EwzTrM2sMlQQzE=; b=GhjmGk3SkLWdGC6hiDpPT7eKuLZO8Lx9BJgpNsKi16+G1De2HNSVvNTleAnQpbWgFe /lpzlSCy7JYg+wjvpiuoqUYNhkq4hVMsnK/1DA16tZkfO77VUgjGispkBUAx+1xiDnCz aec0AKrdXZDsRMoLNmfeNwkK0R6sy7GeARPAUll6nYxFpopNLG+CNNLOqyF7msEnseCY rV9vuvtQCzrI0EID1KS9KvSJ3wgmIGBNmRk1fDUSFbwQNu3bPFzrwN78uQO2yMZBm+mi NpOKtL3CvkD6oeF5xR6Fj6Ld1ahlv1jZgAf9qs8LwRuwHzD/ke9fSg0h4MbUwyGUSslb VyLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=9HxXIhlJ8egb+tUhCrrqxA/twApe2EwzTrM2sMlQQzE=; b=vVG2nUVDVcP9vbeusOC1dODXytBMmtbt6TyfP68MVU+1LFzcFb/veF7n2akE7mm2Ee VILicmJYsoBf5LlZCxn+MiMsyhlNBsFWS+AhgU5yZYu1Pp9LYJe/hAm61P1ikbjONYDm dL5Ft33gqHBg+Zg3Dt6bPLedcgeD0EyhK+eSjF1EPQiKAoFg4fheGTL0dhqmwp0oSfxK zzExiBJxz5KzB4bNuAX+W0AXCdLUWN2Eul4oLML/ItzDcR//DI5+UMkjsqxJnLSyO6gq 4FEYO3TVEOFUxAJZFOuWEzIT9002FnFjGdY/I65VpKAC24Zrz8zV+ky6fzDLJTd98JEv YLvg== X-Gm-Message-State: ACgBeo1F8VBL8q5GHNwcZuzRlZC4qlkVQ+WWXFFhFj/KZk7rlIjivoin swHCif8sBKZvVn4W4WWZCgXhkK/DvDGJ2Uybqo8= X-Received: by 2002:a05:6e02:1c26:b0:2e0:d8eb:22d6 with SMTP id m6-20020a056e021c2600b002e0d8eb22d6mr9161577ilh.151.1660640550007; Tue, 16 Aug 2022 02:02:30 -0700 (PDT) MIME-Version: 1.0 References: <20220816032846.2579217-1-imagedong@tencent.com> In-Reply-To: <20220816032846.2579217-1-imagedong@tencent.com> From: Miguel Ojeda Date: Tue, 16 Aug 2022 11:02:19 +0200 Message-ID: Subject: Re: [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc To: menglong8.dong@gmail.com Cc: kuba@kernel.org, ojeda@kernel.org, ndesaulniers@google.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, asml.silence@gmail.com, imagedong@tencent.com, luiz.von.dentz@intel.com, vasily.averin@linux.dev, jk@codeconstruct.com.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022 at 5:29 AM wrote: > > Reported-by: Miguel Ojeda Hmm... Why did you add me as a reporter? > + * Optional: not supported by clang. > + * Optional: not supported by icc. Much better, thank you! Please add the links to GCC's docs, like in most attributes (some newer attributes may have been added without them -- I will fix that). In any case, no need to send a new version just for this for the moment, I would recommend waiting until others comment on whether they want `__optimize__` used here as the workaround. Cheers, Miguel