Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 Aug 2022 11:57:31 +0200
Message-ID: <87wnb8y0hg.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     zhaoxiao <zhaoxiao@uniontech.com>
Cc:     perex@perex.cz, tiwai@suse.com,
        pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
        peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
        ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
        daniel.baluta@nxp.com, broonie@kernel.org,
        guennadi.liakhovetski@linux.intel.com,
        sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: intel: Replace scnprintf() calls with sysfs_emit_at()
In-Reply-To: <20220816085502.25295-1-zhaoxiao@uniontech.com>
References: <20220816085502.25295-1-zhaoxiao@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 16 Aug 2022 10:55:02 +0200,
zhaoxiao wrote:
> 
> For sysfs outputs, it's safer to use a new helper, sysfs_emit(),
> instead of the raw sprintf() & co.  This patch replaces the open-code
> with a new helper, sysfs_emit_at(), by passing the string offset.

Well, the function you've changed isn't used for sysfs at all...


Takashi

> 
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> ---
>  sound/soc/sof/intel/hda.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c
> index 6d4ecbe14adf..917d639671a7 100644
> --- a/sound/soc/sof/intel/hda.c
> +++ b/sound/soc/sof/intel/hda.c
> @@ -574,7 +574,7 @@ static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, const char *le
>  	chip = get_chip_info(sdev->pdata);
>  	for (i = 0; i < HDA_EXT_ROM_STATUS_SIZE; i++) {
>  		value = snd_sof_dsp_read(sdev, HDA_DSP_BAR, chip->rom_status_reg + i * 0x4);
> -		len += scnprintf(msg + len, sizeof(msg) - len, " 0x%x", value);
> +		len += sysfs_emit_at(msg, len, " 0x%x", value);
>  	}
>  
>  	dev_printk(level, sdev->dev, "extended rom status: %s", msg);
> -- 
> 2.20.1
>