Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3498601rwb; Tue, 16 Aug 2022 04:16:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR42FEROQKkKyFT/sp9EGsUasJwQFL3hsOBU3sMOgaizxxKZ066ckjCrVz4493TzSmsvlhJ5 X-Received: by 2002:a17:906:4795:b0:733:1d3:3d33 with SMTP id cw21-20020a170906479500b0073301d33d33mr13633074ejc.200.1660648615571; Tue, 16 Aug 2022 04:16:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660648615; cv=none; d=google.com; s=arc-20160816; b=j1vapAPHPPduWc8ZGF6IfHo9eKkcOB8Y3kg0WZzAulOdXKWljqsFSo3uXkUTEi5HU3 sdKfmykul2tGtwSK7XeFvgzAntkYSAfn3RRsAIj4j4LF5PUgFTqT4d2XJYPXbtwOLTNp DWtIRjA9xRBGzigqN3ovshV8EEC3I+C5YCedD0O2hzAgcYlHcnkGX/siQDbZ7n7OUfsy NdnK5WrjV2EHDLxG7qkTDBeT3z+67oI/FftVR5KAi0CuXhLBnC2Sg1DPQazEtpcnCGux eN3vTpax4HJjy8ps8YIVS3qPBWfUDooru7mhS4iUglRbxYcuMPvU9Kz050vD5T0xApuB E9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=N21IrFoF+c3Uz8gbDUqJNJKQFeftZ1grSPLtq6SWU6s=; b=BUj2G+lUehjv2gTp3BCaIHmPS91Yq6pPP1R4JynTVmkEUNu9HM9VoKjc5XycxZIdCs cFeLS/DvwK8GTbXp4qLTtoMQYfw6XA1VL3WE2elZIucA82wOELguVSgOoTsifQeEymnt Kg/+yssJ6U0/kSDKDL8ZOQZ+eJ2SU9DjcnzM+R2rkaOxNezgyz4gyZdb9hzvrvkyU40j cklCMHtZtaD5JVwOzD2G69GRqLwsfLw4W4pDrG4mC/EOXfRubdC1PFiBk5WKviZdPynX Y+AU84AuuaSDB/vzgj+K3051tL/V6I8nVlMTEIBHVSd3HKLgwwanvZ0iJnJAPgpDXp+M u0qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dAE+Zn7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a50fe07000000b00445a524aaefsi180003edt.210.2022.08.16.04.16.29; Tue, 16 Aug 2022 04:16:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dAE+Zn7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233482AbiHPKrR (ORCPT + 99 others); Tue, 16 Aug 2022 06:47:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234824AbiHPKqV (ORCPT ); Tue, 16 Aug 2022 06:46:21 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7399EEE6B2 for ; Tue, 16 Aug 2022 03:09:02 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id by6so10007798ljb.11 for ; Tue, 16 Aug 2022 03:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=N21IrFoF+c3Uz8gbDUqJNJKQFeftZ1grSPLtq6SWU6s=; b=dAE+Zn7Q6q2G9v+tf5/mblVh57atpAB6AzzHGn0zME2jXFSpJjfjNlRJRNFkNi1dya NUD3vhxtgCqrMz7vHX3+MMXQwTKnCD1kXjLE3+H/KJ4MrHTdrAzJafgGiFyMg1wz/hjb JdCVskrChS9leLIFnT1AUn160zF8iJQOej0RAqSf+6ZFttDlOUjySc+SwYZAAM2QDCL9 2neNwhjkLK+LOZU72iKIFW1mv6huqUlUYVX48jjxuNlrsZm6M22cby9hKsE1l6Jdphv/ h8DIKyycuQ0WyU0k0RVxsbW5fsfI4KcpZtgkv3gViTjirl2fA32X/o6O+CYA2IvXcAMG /b6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=N21IrFoF+c3Uz8gbDUqJNJKQFeftZ1grSPLtq6SWU6s=; b=uNr3kv0sYLnUIR1GcccOuBPHMQ0o8hbyafMNtiBQzxxBzOfX8bhI4r5bKrKBh3rlA8 gFJOr7btJeK4cV8NO2owMB6u+es58D9WUYvSttp9OcFoJlLoLmgKdCi/PS3+0aZmJPiV zxAopLvtOCeCTcdxK1q3zW06R1T7EAo9e+ROTvbc68DywB6cj+gXNo+Iln8EV52QLMOe nN/qyDxmkCL1gRu/xl66cR5sU0YbQSIP+8V2mj365nFAdCqy7cP4RKd2ifaR/XC1TIqJ hnVjh8L02SMgNTJ7pca8xqQf18L860OHrOePuFOLZl4m0mnoyACMVQh+s4l5NdBtG5a1 UTPw== X-Gm-Message-State: ACgBeo3hg0Aw0FeQY9+g80/7XyIPBRBRcng5zTx2VimP4L2Ty6Tu7IXU mixr+OhKF9O2B69tjCBFGkHtAw== X-Received: by 2002:a2e:b8ca:0:b0:25f:df8b:f867 with SMTP id s10-20020a2eb8ca000000b0025fdf8bf867mr5970635ljp.269.1660644540627; Tue, 16 Aug 2022 03:09:00 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id v8-20020a2ea608000000b0026182c4a5c6sm954903ljp.120.2022.08.16.03.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 03:09:00 -0700 (PDT) Message-ID: <265b2a5f-fcf7-53a0-5de0-1cb753581515@linaro.org> Date: Tue, 16 Aug 2022 13:08:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v5 3/3] gpio: imx-scu: add imx-scu GPIO driver Content-Language: en-US To: Bartosz Golaszewski , Shenwei Wang Cc: Rob Herring , Krzysztof Kozlowski , Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , devicetree , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Linux ARM , imx@lists.linux.dev References: <20220812133012.7283-1-shenwei.wang@nxp.com> <20220812133012.7283-4-shenwei.wang@nxp.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/2022 12:06, Bartosz Golaszewski wrote: > On Fri, Aug 12, 2022 at 3:31 PM Shenwei Wang wrote: >> >> The SCU firmware on i.MX8 platforms provides a set of APIs to >> control the GPIO PINs on the SCU domain. This patch implements the >> standard GPIO driver interface to access those PINs on the >> SCU domain over the SCU APIs. >> >> Signed-off-by: Shenwei Wang >> --- > > This looks good to me - Krzysztof: do you have any other comments? > Otherwise, I'll pick it up soon. No, I acked/reviewed bindings, so entire set is for you. Thanks! Best regards, Krzysztof