Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d8d5481b-efd3-9b54-3fa6-3f6272472e6d@huawei.com>
Date:   Tue, 16 Aug 2022 18:13:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] mm: memory-failure: cleanup try_to_split_thp_page()
Content-Language: en-US
To:     =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= 
        <naoya.horiguchi@nec.com>
CC:     Miaohe Lin <linmiaohe@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220809111813.139690-1-wangkefeng.wang@huawei.com>
 <20220816054716.GA496220@hori.linux.bs1.fc.nec.co.jp>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <20220816054716.GA496220@hori.linux.bs1.fc.nec.co.jp>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/8/16 13:47, HORIGUCHI NAOYA(堀口 直也) wrote:
> On Tue, Aug 09, 2022 at 07:18:13PM +0800, Kefeng Wang wrote:
>> Since commit 5d1fd5dc877b ("mm,hwpoison: introduce MF_MSG_UNSPLIT_THP"),
>> the action_result(,MF_MSG_UNSPLIT_THP,) called to show memory error event
>> in memory_failure(), so the pr_info() in try_to_split_thp_page() is only
>> needed in soft_offline_in_use_page().
>>
>> Meanwhile this could also fix the unexpected prefix for "thp split failed"
>> due to commit 96f96763de26 ("mm: memory-failure: convert to pr_fmt()").
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> # Sorry for my late reply, I'm back from summer holiday...
>
> Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Thanks Noaya.