Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220815180439.416659447@linuxfoundation.org> <CA+G9fYtZP_rYnmRyLbMrxKPGtJuoOw4h412dJXBJnzab41CzUw@mail.gmail.com>
 <YvtNZuap/oCKVv9O@kroah.com>
In-Reply-To: <YvtNZuap/oCKVv9O@kroah.com>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Tue, 16 Aug 2022 16:07:58 +0530
Message-ID: <CA+G9fYuqm1NzfhF2B8OXqcH8-c24ZA6UGv3Y94fYuyOKVgqaOQ@mail.gmail.com>
Subject: Re: [PATCH 5.19 0000/1157] 5.19.2-rc1 review
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
        slade@sladewatkins.com, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        clang-built-linux <clang-built-linux@googlegroups.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 16 Aug 2022 at 13:57, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Tue, Aug 16, 2022 at 01:08:26PM +0530, Naresh Kamboju wrote:
> > On Tue, 16 Aug 2022 at 00:58, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 5.19.2 release.
> > > There are 1157 patches in this series, all will be posted as a respon=
se
> > > to this one.  If anyone has any issues with these being applied, plea=
se
> > > let me know.
> > >
> > > Responses should be made by Wed, 17 Aug 2022 18:01:29 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/pa=
tch-5.19.2-rc1.gz
> > > or in the git tree and branch at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-st=
able-rc.git linux-5.19.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > The arm64 clang-14 allmodconfig failed on stable-rc 5.19.
> > This build failure got fixed on the mainline tree two weeks ago.
> >
> > * arm64, build
> >   - clang-12-allmodconfig
> >   - clang-13-allmodconfig
> >   - clang-14-allmodconfig
> >   - clang-nightly-allmodconfig
> >
> >
> > make --silent --keep-going --jobs=3D8
> > O=3D/home/tuxbuild/.cache/tuxmake/builds/2/build LLVM=3D1 LLVM_IAS=3D1
> > ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- 'HOSTCC=3Dsccache clang=
'
> > 'CC=3Dsccache clang' allmodconfig
> > make --silent --keep-going --jobs=3D8
> > O=3D/home/tuxbuild/.cache/tuxmake/builds/2/build LLVM=3D1 LLVM_IAS=3D1
> > ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- 'HOSTCC=3Dsccache clang=
'
> > 'CC=3Dsccache clang'
> > sound/soc/intel/avs/path.c:815:18: error: stack frame size (2192)
> > exceeds limit (2048) in 'avs_path_create'
> > [-Werror,-Wframe-larger-than]
> > struct avs_path *avs_path_create(struct avs_dev *adev, u32 dma_id,
> >                  ^
> > 1 error generated.
> > make[5]: *** [/builds/linux/scripts/Makefile.build:249:
> > sound/soc/intel/avs/path.o] Error 1
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > Steps to reproduce:
> > -------------------------
> > # See https://docs.tuxmake.org/ for complete documentation.
> > # Original tuxmake command with fragments listed below.
> > # tuxmake --runtime podman --target-arch arm64 --toolchain clang-14
> > --kconfig allmodconfig LLVM=3D1 LLVM_IAS=3D1
> >
> > tuxmake --runtime podman --target-arch arm64 --toolchain clang-14
> > --kconfig https://builds.tuxbuild.com/2DPEiUmdALSZq7DeNthZFYoPLaN/confi=
g
> > LLVM=3D1 LLVM_IAS=3D1
>
> What is the commit on mainline that resolved this issue?

commit 1e744351bcb9c4cee81300de5a6097100d835386
Author: Amadeusz S=C5=82awi=C5=84ski <amadeuszx.slawinski@linux.intel.com>
Date:   Fri Jul 22 13:19:59 2022 +0200

    ASoC: Intel: avs: Use lookup table to create modules

    As reported by Nathan, when building avs driver using clang with:
      CONFIG_COMPILE_TEST=3Dy
      CONFIG_FORTIFY_SOURCE=3Dy
      CONFIG_KASAN=3Dy
      CONFIG_PCI=3Dy
      CONFIG_SOUND=3Dy
      CONFIG_SND=3Dy
      CONFIG_SND_SOC=3Dy
      CONFIG_SND_SOC_INTEL_AVS=3Dy

    there are reports of too big stack use, like:
      sound/soc/intel/avs/path.c:815:18: error: stack frame size
(2176) exceeds limit (2048) in 'avs_path_create'
[-Werror,-Wframe-larger-than]
      struct avs_path *avs_path_create(struct avs_dev *adev, u32 dma_id,
                       ^
      1 error generated.

    This is apparently caused by inlining many calls to guid_equal which
    inlines fortified memcpy, using 2 size_t variables.

    Instead of hardcoding many calls to guid_equal, use lookup table with
    one call, this improves stack usage.

    Link: https://lore.kernel.org/alsa-devel/YtlzY9aYdbS4Y3+l@dev-arch.thel=
io-3990X/T/
    Link: https://github.com/ClangBuiltLinux/linux/issues/1642
    Signed-off-by: Amadeusz S=C5=82awi=C5=84ski <amadeuszx.slawinski@linux.=
intel.com>
    Reported-by: Nathan Chancellor <nathan@kernel.org>
    Build-tested-by: Nathan Chancellor <nathan@kernel.org>
    Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
    Link: https://lore.kernel.org/r/20220722111959.2588597-1-amadeuszx.slaw=
inski@linux.intel.com
    Signed-off-by: Mark Brown <broonie@kernel.org>

- Naresh