Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3550388rwb; Tue, 16 Aug 2022 05:13:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR4RgOHMNSN7aarHx4S9Is0NcIFsHnhcnbMkItCZTFL75cYAcadq7m8qby9AG4U9dbeclzNY X-Received: by 2002:a05:6402:28c3:b0:43a:6d78:1b64 with SMTP id ef3-20020a05640228c300b0043a6d781b64mr18802503edb.93.1660652002757; Tue, 16 Aug 2022 05:13:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660652002; cv=none; d=google.com; s=arc-20160816; b=rERkbeGFjGx3tzdp9C637KRzzErcr5xLt8OtnowOMa07yauVV224ILedMp+lhsNHBI zax8NHEcxqrHt15g/KXWpb0CzG+W4/u7a0CJzTNGvm+49ZEOPGz1bW6CKSIL+RiEmVKS raZl3VcdK/ip4RVXOaiprMXzFpbShKn2rFDXkzOnJ+rsN3XPdHj7oQ1wdZyUkkQdSCO3 sxqVuwfCNxYTOdnbJH/1rHTu/jV4MLTQN6Py1sV3XRUvPpPqK70YB20nN9nEtNirfT+i asw7btocBXXXJkCFrWuXEvFXHjgd8jqxnFPDzThxuC6ceFpTYzaqX5c8WFXb9XcyIYFj 71ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=6Jh4QYGMoHo8Uic4iv978KBBZgS0XFbP7zpUkCqVKX4=; b=xlKh0IDgMEez9xzNXtWKJ63emYgwfE2lVAV1YrzgqLFJJy3q+OrJ9sU5VwZoU8ELD7 r8lPQ360rUBC3tQdC0Ld8GYalSyie3I4aGpvKjj8JssY0spAau4Q+gddEtD/Fxbl8kF6 PBHgXjQNk+FZ52g4PlQze9P/bY9chwDWx0WWEm1T5pm/Dx4Ptsbpwk+9k1m79YCtoJTL 1pZVeCZx/eTUC7Vs9xA6xweGfkBZ8V6pDYy6lK2KnB+vaSutBLj0ZmhUPY4U56KxHQb/ yld4xQs/4WSpRLpdaNUIS5AUpvXNgPOiLFt5J0/cQ251MtoII88PR5EPuj7POWDHk4Pn yXEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=FCrHz4ty; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=CqM3xPr+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f24-20020a056402069800b0043d356d8672si9641660edy.133.2022.08.16.05.12.55; Tue, 16 Aug 2022 05:13:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=FCrHz4ty; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=CqM3xPr+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234330AbiHPMIK (ORCPT + 99 others); Tue, 16 Aug 2022 08:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235343AbiHPMHp (ORCPT ); Tue, 16 Aug 2022 08:07:45 -0400 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E178399DF for ; Tue, 16 Aug 2022 04:58:21 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 9EA072B05A10; Tue, 16 Aug 2022 07:58:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 16 Aug 2022 07:58:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1660651098; x=1660658298; bh=6Jh4QYGMoH o8Uic4iv978KBBZgS0XFbP7zpUkCqVKX4=; b=FCrHz4tyUrvT59ofQy8bv49daB b9ddhsClYCYaznQxsUbhQCBUVKiiky2iMysH4vDNk6e/iUUqYXKbv8IkDNRaXAIM HoxDQS2e2jZ2q5Fnraf/cMcYro+04SDBbA14KFWtOsBHwUqyilR4L/9EDqy6PF4h f0oacHQB+zDQc3tsBJIZx2zTRocB4RsdHhchVFcesQqKz8DpAbZxsLcECP1o7mz9 QFsjVo8VF8a9QvEvR+sVrTSwuyM8V+4I3Asm+F26jbXoYHGOjEAkcflOxALaJ9Ls 45R78V68i1ecrqap0yNf+VPtI3gUiE+9O5/ozmGhldRUMQ47DnTxTNYNDcrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660651098; x=1660658298; bh=6Jh4QYGMoHo8Uic4iv978KBBZgS0 XFbP7zpUkCqVKX4=; b=CqM3xPr+nc9UfN/4WjR3csBYhFI33bC+6TTBegRKLKcc k1gQyrqVDgN/Utvni23YWLg8U+C05A+hVUFMlE94Pu2IhF5laKmajz9DIlCvw0oQ HpLXdEpaYJVQDtdfsk/25eEmkI+jcHsRZoEgfoblF06oTC6wj6uiHchXWbrCFtm9 GddW4Dfb5eZQ29viAglGOF4HjtErtdM8zwZ5SmNwDlTD/EQq9/Or0K9kwlXhfTEb 9GGhfL3t6S19YUhq81BnHH+jivbY3fvzeDlWMyN6+99vtQy90UjBjwfU1ZzPqapa Yy3B5sxKVpO5lBEtlvfaiNtSu0Hp04SikV1+0pKtzw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehgedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Aug 2022 07:58:15 -0400 (EDT) Date: Tue, 16 Aug 2022 13:58:14 +0200 From: Maxime Ripard To: Thomas Zimmermann Cc: Jani Nikula , Jernej Skrabec , Martin Blumenstingl , Chen-Yu Tsai , Philipp Zabel , Jerome Brunet , Samuel Holland , Daniel Vetter , Emma Anholt , David Airlie , Maarten Lankhorst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Kevin Hilman , Neil Armstrong , Dom Cobley , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mateusz Kwiatkowski , Geert Uytterhoeven , linux-amlogic@lists.infradead.org, linux-sunxi@lists.linux.dev, Phil Elwell , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 04/35] drm/modes: Introduce 480i and 576i modes Message-ID: <20220816115814.gtdymzjsutu4am7z@houat> References: <20220728-rpi-analog-tv-properties-v1-0-3d53ae722097@cerno.tech> <20220728-rpi-analog-tv-properties-v1-4-3d53ae722097@cerno.tech> <8735eeg31e.fsf@intel.com> <46871a84-3b17-5474-9608-cfbe7e6f4c7f@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="awchg3pjflohp76k" Content-Disposition: inline In-Reply-To: <46871a84-3b17-5474-9608-cfbe7e6f4c7f@suse.de> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --awchg3pjflohp76k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 02, 2022 at 04:16:29PM +0200, Thomas Zimmermann wrote: > Hi >=20 > Am 02.08.22 um 15:58 schrieb Jani Nikula: > > On Fri, 29 Jul 2022, Maxime Ripard wrote: > > > Multiple drivers (meson, vc4) define the analog TV 525-lines and 625-= lines > > > modes in the drivers. > > >=20 > > > Since those modes are fairly standards, and that we'll need to use th= em in > > > more places in the future, let's move the meson definition into the > > > framework. > >=20 > > I think you should always expose interfaces, not data. Data is not an > > interface, and I think this sets a bad example that will be cargo > > culted. >=20 > Although I wrote the opposite wrt patch 8, I agree with Jani here when it > comes to 'official' interfaces. The cases I've seen of exported data > structures often lead to intransparent code. Ack. The improvement Geert suggested would involve that change anyway, so this should be fixed for the next iteration. Maxime --awchg3pjflohp76k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYvuGVgAKCRDj7w1vZxhR xS0WAP47XlF53evVNWhich0B1ptAwy/AePOsskAxEmgx3yqrNQD9E0bjZfOAyvz/ e3gbsh9/yRHjOZuY9N1BqkC04K6VFQE= =ezHC -----END PGP SIGNATURE----- --awchg3pjflohp76k--