Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1349b271-796b-c9d2-a568-f9be84926ed4@linaro.org>
Date:   Tue, 16 Aug 2022 15:57:02 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v3 1/1] regulator: dt-bindings: mediatek: add mt6366
Content-Language: en-US
To:     "zhiyong.tao" <zhiyong.tao@mediatek.com>
Cc:     lee.jones@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com,
        lgirdwood@gmail.com, broonie@kernel.org, eddie.huang@mediatek.com,
        a.zummo@towertech.it, alexandre.belloni@bootlin.com,
        fshao@chromium.org, sen.chu@mediatek.com, hui.liu@mediatek.com,
        allen-kh.cheng@mediatek.com, hsin-hsiung.wang@mediatek.com,
        sean.wang@mediatek.com, macpaul.lin@mediatek.com,
        wen.su@mediatek.com, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20220812092901.6429-1-zhiyong.tao@mediatek.com>
 <20220812092901.6429-2-zhiyong.tao@mediatek.com>
 <cbe761af-5011-83a2-0509-2b3c4fe0a79c@linaro.org>
 <4a49b619deb5453749a47874377cad6a36a9a054.camel@mediatek.com>
 <CAGE=qrohYZ6f9bbEuYfF=2Rz21nbW_8ho3rBQmHt1D+kQG2-jA@mail.gmail.com>
 <9bc148119fc36c34f404091ca0f5a2e37727c285.camel@mediatek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <9bc148119fc36c34f404091ca0f5a2e37727c285.camel@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 16/08/2022 15:54, zhiyong.tao wrote:
> On Fri, 2022-08-12 at 15:55 +0300, Krzysztof Kozlowski wrote:
>> On Fri, 12 Aug 2022 at 15:52, zhiyong.tao <zhiyong.tao@mediatek.com>
>> wrote:
>>>
>>> On Fri, 2022-08-12 at 13:55 +0300, Krzysztof Kozlowski wrote:
>>>> On 12/08/2022 12:29, Zhiyong Tao wrote:
>>>>> Add mt6366 regulator document
>>>>>
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    const: mediatek,mt6366-regulator
>>>>> +
>>>>> +  regulators:
>>>>> +    type: object
>>>>> +    description: List of regulators and its properties
>>>>> +
>>>>> +    patternProperties:
>>>>> +      "^buck-
>>>>> v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$":
>>>>> +        type: object
>>>>> +        $ref: regulator.yaml#
>>>>> +        unevaluatedProperties: false
>>>>> +
>>>>> +      "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$":
>>>>> +        type: object
>>>>> +        $ref: regulator.yaml#
>>>>
>>>> You miss unevaluatedProperties in most of the places.
>>>
>>> Hi Krzysztof,
>>>    Thanks for your suggestion,
>>>    Do you mean that all places should have the
>>> unevaluatedProperties
>>> Properties ?
>>
>> Yes. You put it in some of the places which does not really make
>> sense...
> 
> Hi Krzysztof,
>    Thanks for your suggestion,
>    We find that if there is a properties "compatible = "regulator-
> fixed";" in ldo-vrf12, we should set unevaluatedProperties as true.
> or it will check yaml warning "Unevaluated Properties are not
> allowed('compatible' was unexpected)". is it right?
>    There is a properties "compatible = "regulator-fixed";"in ldo-vrf12.
> It will cause the checking yaml error "ldo-vrf12: 'regulator-name' is a
> required property". Can you help to give a suggestion to fix the
> warning? Add regulator-name for ldo-vrf12 or other suggestion?
> 

And how this regulator is supposed to work? Are you populating DT
children in your driver?

Best regards,
Krzysztof