Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 Aug 2022 22:12:15 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Sang, Oliver" <oliver.sang@intel.com>
CC:     Dmitry Vyukov <dvyukov@google.com>,
        Vlastimil Babka <vbabka@suse.cz>, lkp <lkp@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "lkp@lists.01.org" <lkp@lists.01.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        John Garry <john.garry@huawei.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Andrey Konovalov <andreyknvl@gmail.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        "Alexander Potapenko" <glider@google.com>,
        "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>
Subject: Re: [mm/slub] 3616799128:
 BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten
Message-ID: <Yvulv68VmqCJFVJq@feng-clx>
References: <CACT4Y+Zwg8BP=6WJpQ5cCbJxLu4HcnCjx8e53aDEbTZ5uzpUyg@mail.gmail.com>
 <85ec4ea8-ae4c-3592-5491-3db6d0ad8c59@suse.cz>
 <CACT4Y+asjzrBu8ogRDt9hYYaAB3tZ2pK5HBkzkuMp106vQwKWQ@mail.gmail.com>
 <YukoZEm4Q6CSEKKj@feng-skl>
 <CACT4Y+Y6M5MqSGC0MERFqkxgKYK+LrMYvW5xPH5kUA2mFh5_Xw@mail.gmail.com>
 <YutnCD5dPie/yoIk@feng-clx>
 <CACT4Y+Zzzj7+LwUwyMoBketXFBHRksnx148B1aLATZ48AU9o3w@mail.gmail.com>
 <Yuu6B0vUuXvtEG8b@feng-clx>
 <Yvn1b8y20Mr0gfUQ@feng-clx>
 <YvubS48W0dE7uA4E@xsang-OptiPlex-9020>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YvubS48W0dE7uA4E@xsang-OptiPlex-9020>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kHPOoOMKP/OZyio3hrBd3hpTnZ6JmVig5GFgyqlFHFTjV84eqjdYP4yameyM?=
 =?us-ascii?Q?M2G85hIDaLhcveGS2LzitjOsnKIGVtlIeeFdcytL1stzDrpiGeKQT1GBuKk6?=
 =?us-ascii?Q?Mar07pX2eiHA/1JvwWgwu8VoI9e72wo56sq2kAMO5lZk98BT9X9Dv4HtGbjg?=
 =?us-ascii?Q?wQ37RCCTWWr6d+ByFLNOWsBS2QLMTSIx2kOhpkwZsjCVzRhOqIg3RHzJSlLL?=
 =?us-ascii?Q?PIhgcSIp658WE3QU1Q5rhcfUEwo+og2ogmFeAwBN6mTKZM2yI/c8jFLrnyRs?=
 =?us-ascii?Q?5G+14X8T+5ezdnhwV5zdk/UNuVOkTL0cP/1KBv6vbn+HCUgAcRe2PTt3TRWq?=
 =?us-ascii?Q?BF4Q0o3AF9J/z7xxGGL+M3AgupjpeHrn6lT+NaHekFPakBd2hFiUINKyVZds?=
 =?us-ascii?Q?0HnGameKHZQnCq+wEd3ABKBd0w7FPr3s2VgcudNElAT1l0tWJ5342qbhVPHo?=
 =?us-ascii?Q?FZCpaYYXUQ+KavvajGb2VvPutoGIS5kQa6SJ9+st3l830TYTNU1LKdJf9q7g?=
 =?us-ascii?Q?CcmYWZKYcZT8xDkdd4lKX/AJ3CG+Qh7gK5NOisCSTIgyj9AknXZzwTGUb33a?=
 =?us-ascii?Q?C1QO9BbRhmPSXWcuSmqVdGQYY2IBJuxgumsQUd+gDVf3jIyPOb3nEKLvdJ8j?=
 =?us-ascii?Q?pHvyfh0tmbts8C+IPrVzs8vBBZgGhwKNzfvLK9KmT1Dfr0yqJ4ELrsMEMZKV?=
 =?us-ascii?Q?UOS28sdtGaFcKVGxvvXmR8tbVCxWPcU8wwQ0+bBu6/5kGqPyWIGmgD5I35Js?=
 =?us-ascii?Q?sDzSXNKJ2A5sMBSTOZHWwnaYcAseeVoxU0k/xFyxQHiHvCjlkg949slLSf2M?=
 =?us-ascii?Q?/RwvtmeN1mB65Wf8jcQ+Io0eB+ve7miV9nvWOHeNoZUJKXz0FmF5EuziLfFH?=
 =?us-ascii?Q?drTK3hbUL/RqEKPCcImc2KLT0X5vka/1dqWtnuNq7U5C/8SDCHmIlXJNypMt?=
 =?us-ascii?Q?0hsOJ3kn08ZpzWY0UrcKQrFAn14SwpcUOrv8McVqZ7S28aJRaAE+PlvFKYYH?=
 =?us-ascii?Q?RYaz3bZbsUaFkBTD9QOlpagrLcHOVdX7xYs4yjGKBL3GRVZqzAHN+uzLuPk+?=
 =?us-ascii?Q?yvg4paK/USpIRVtkC0MyV5l+vXuNSPcqi7Ip74yTyG4pSIMNwMJqKU1U5YSf?=
 =?us-ascii?Q?6m67iIAdRgACqQnUrtNxQ5WVAIGm7HWaDBMaDJbtiHTl6WjrOjixdX6caUKo?=
 =?us-ascii?Q?9GIvPBlD0QSrZ4xKw4YUQGNj5X3VbJJ3CbRlBbDdJ5HDZvLilW3cw4ONsi1M?=
 =?us-ascii?Q?9XDMGiLoYwHlKMNkSBYgTSWJDpETA39LAVA6ifH2vofbPG4qvFO0bxnCaBVb?=
 =?us-ascii?Q?9wVekDRqhWz8VEdMjROVJos5cY+KVHQuDg/FT+I8ZzLZcA2JR/DNQoZ7TfYT?=
 =?us-ascii?Q?owH6F0cqjl1oDxqESqxzMu2lVNKf0cavpGA19Vaoek6BO360lA4JHlCxSekW?=
 =?us-ascii?Q?n+RK06NOMOULZw0yjNi062QXIg6Kbhc9tYuTb7nt3w1YxWCE1t/7O6DWCpI9?=
 =?us-ascii?Q?uE4bO7hvr4tAbLcCJK3TlJUmLCZDpt3Yxz7nNiPmBhARCLtsw151mZxD0ZwG?=
 =?us-ascii?Q?b9ke5A8INgpqpoVaRe5D45SFOf5+z56JGQyFfq7g?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 905af6ec-7a8c-4dd6-01e9-08da7f916f63
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 14:13:04.3800
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T8DJD7urJVFnUQKp9oP+TD+INoEtkvyA6J2lZAFwU9ajkzBupPwgHZUvacrHDkfr1Bgj4QgP6i5FzZexiHTuhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5372
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 16, 2022 at 09:27:39PM +0800, Sang, Oliver wrote:
> Hi Feng,
> 
> On Mon, Aug 15, 2022 at 03:27:43PM +0800, Feng Tang wrote:
> > Hi Oliver,
> > 
> > Could you help to check if the below combined patch fix the problem
> > you reported? thanks!
> 
> I applied below patch upon 3616799128:
> 28b34693c816e9 (linux-devel/fixup-3616799128) fix for 3616799128: BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten
> 3616799128612e (linux-review/Feng-Tang/mm-slub-some-debug-enhancements/20220727-151318) mm/slub: extend redzone check to cover extra allocated kmalloc space than requested
> acc77d62f91ccc mm/slub: only zero the requested size of buffer for kzalloc
> 
> 
> confirmed the issue gone:

Many thanks for helping testing!

- Feng


> =========================================================================================
> compiler/kconfig/rootfs/sleep/tbox_group/testcase:
>   gcc-11/x86_64-randconfig-a005-20220117/debian-11.1-x86_64-20220510.cgz/300/vm-snb/boot
> 
> 
> acc77d62f91ccca2 3616799128612e04ed919579e2c 28b34693c816e9fcbe42bdd341e
> ---------------- --------------------------- ---------------------------
>        fail:runs  %reproduction    fail:runs  %reproduction    fail:runs
>            |             |             |             |             |
>            :20          95%          19:20           0%            :22    dmesg.BUG_kmalloc-#(Not_tainted):kmalloc_Redzone_overwritten
>            :20          95%          19:20           0%            :22    dmesg.BUG_kmalloc-#(Tainted:G_B):kmalloc_Redzone_overwritten
> 
> 
> 
> > 
> > - Feng
> > 
> > ---
> > 
> > diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> > index b092277bf48d6..293bdaa0ba09c 100644
> > --- a/include/linux/kasan.h
> > +++ b/include/linux/kasan.h
> > @@ -100,6 +100,8 @@ static inline bool kasan_has_integrated_init(void)
> >  struct kasan_cache {
> >  	int alloc_meta_offset;
> >  	int free_meta_offset;
> > +	/* size of free_meta data saved in object's data area */
> > +	int free_meta_size_in_object;
> >  	bool is_kmalloc;
> >  };
> >  
> > diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> > index c40c0e7b3b5f1..9d2994dbe4e7a 100644
> > --- a/mm/kasan/common.c
> > +++ b/mm/kasan/common.c
> > @@ -200,6 +200,8 @@ void __kasan_cache_create(struct kmem_cache *cache, unsigned int *size,
> >  			cache->kasan_info.free_meta_offset = KASAN_NO_FREE_META;
> >  			*size = ok_size;
> >  		}
> > +	} else {
> > +		cache->kasan_info.free_meta_size_in_object = sizeof(struct kasan_free_meta);
> >  	}
> >  
> >  	/* Calculate size with optimal redzone. */
> > diff --git a/mm/slub.c b/mm/slub.c
> > index added2653bb03..272dcdbaaa03b 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -830,6 +830,16 @@ static inline void set_orig_size(struct kmem_cache *s,
> >  	if (!slub_debug_orig_size(s))
> >  		return;
> >  
> > +#ifdef CONFIG_KASAN_GENERIC
> > +	/*
> > +	 * kasn could save its free meta data in the start part of object
> > +	 * area, so skip the redzone check if kasan's meta data size is
> > +	 * bigger enough to possibly overlap with kmalloc redzone
> > +	 */
> > +	if (s->kasan_info.free_meta_size_in_object * 2 > s->object_size)
> > +		orig_size = s->object_size;
> > +#endif
> > +
> >  	p += get_info_end(s);
> >  	p += sizeof(struct track) * 2;
> >